Re: [DISCUSS] KIP-962 Relax non-null key requirement in Kafka Streams

Hi Florin, thanks for the KIP! This looks good to me. I agree that the precise Java doc wording doesn't have to be discussed as part of the KIP. I would also suggest to include an update to https://kafka.apache.org/documentation/streams/upgrade-guide Cheers, Lucas On Mon, Aug 7, 2023 at 10:51 A

Re: [DISCUSS] KIP-960: Support interactive queries (IQv2) for versioned state stores

Hi Alieh, thanks a lot for the KIP. IQ with time semantics is going to be another great improvement towards having crystal clear streaming semantics! 1. I agree with Bruno and Matthias, to remove the 'bound' term for the timestamps. It's confusing that we have bounds for both timestamps and keys.

Re: [VOTE] KIP-962 Relax non-null key requirement in Kafka Streams

+1 (non-binding) On Fri, Aug 11, 2023 at 1:08 AM Matthias J. Sax wrote: > > +1 (binding) > > On 8/10/23 12:31 PM, Florin Akermann wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams > >

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

Hi Nick, since I last read it in April, the KIP has become much cleaner and easier to read. Great work! It feels to me the last big open point is whether we can implement isolation level as a query parameter. I understand that there are implementation concerns, but as Colt says, it would be a gre

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

Congrats, Justine! On Mon, Sep 25, 2023 at 9:20 AM Bruno Cadonna wrote: > > Congrats, Justine! Well deserved! > > Best, > Bruno > > On 9/25/23 5:28 AM, ziming deng wrote: > > Congratulations Justine! > > > > > >> On Sep 25, 2023, at 00:01, Viktor Somogyi-Vass > >> wrote: > >> > >> Congrats Just

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

Hi Hanyu, Thanks a lot for the KIP! I agree with Bruno's comments about fluent API / keeping the query classes immutable. Apart from that, on the technical side this is looking good already! Two comments on the KIP itself (not the technical part): - The motivation section could be extended by a

Re: [VOTE] KIP-960: Support single-key_single-timestamp interactive queries (IQv2) for versioned state stores

+1 (binding) Thanks for the KIP! Cheers, Lucas On Wed, Oct 11, 2023 at 7:55 PM Walker Carlson wrote: > > +1 (binding) > > Thanks for the kip Alieh! > > Walker > > On Wed, Oct 11, 2023 at 3:52 AM Bruno Cadonna wrote: > > > Thanks for the KIP, Alieh! > > > > +1 (binding) > > > > Best, > > Bruno

Re: [DISCUSS] KIP-988 Streams Standby Task Update Listener

Hi all, it's a nice improvement! I don't have anything to add on top of the previous comments, just came here to say that it seems to me consensus has been reached and the result looks good to me. Thanks Colt and Eduwer! Lucas On Sun, Oct 15, 2023 at 9:11 AM Colt McNealy wrote: > > Thanks, Guoz

Re: [VOTE] KIP-988 Streams StandbyUpdateListener

Hi, thanks again for the KIP! +1 (binding) Cheers, Lucas On Sun, Oct 15, 2023 at 9:13 AM Colt McNealy wrote: > > Hello there, > > I'd like to call a vote on KIP-988 (co-authored by my friend and colleague > Eduwer Camacaro). We are hoping to get it in before the 3.7.0 release. > > https://cw

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

gt;>>>> > > > > >>>>>>> A simple approach, which would potentially open up other > > options, > > > > >>>> would > > > > >>>>> be > > > > >>>>>>> t

Re: [DISCUSS] KIP-989: RocksDB Iterator Metrics

Hi Nick! thanks for the KIP! I think this could be quite useful, given the problems that we had with leaks due to RocksDB resources not being closed. I don't have any pressing issues why we can't accept it like it is, just one minor point for discussion: would it also make sense to make it possib

Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

+1 (binding) Thanks for the KIP! On Tue, Oct 17, 2023 at 2:31 AM Matthias J. Sax wrote: > > +1 (binding) > > > On 10/13/23 9:24 AM, Hanyu (Peter) Zheng wrote: > > Hello everyone, > > > > I would like to start a vote for KIP-985 that Add reverseRange and > > reverseAll query over kv-store in IQv2

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

tTransaction seems > logical, but what if it times out again? Where do we draw the line and > shutdown the instance? > > Regards, > Nick > > On Mon, 16 Oct 2023 at 13:19, Lucas Brutschy > wrote: > > > Hi all, > > > > I think I liked your suggestio

Re: [DISCUSS] KIP-989: RocksDB Iterator Metrics

metric, even on a busy node, because > each time that Iterator is used, it will leak another one. So even in the > presence of many non-leaky Iterators on a busy instance, the metric should > still consistently climb. > > Regards, > > Nick > > On Mon, 16 Oct 2023 at 14:24, Luc

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

n without also wiping state on > timeouts. > > Regards, > Nick > > On Wed, 18 Oct 2023 at 14:48, Lucas Brutschy > wrote: > > > Hi Nick, > > > > I think indeed the better behavior would be to retry commitTransaction > > until we risk running out

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

Hi Hanyu, reading the KIP, I was wondering the same thing as Bill. Other than that, this looks good to me. Thanks for KIP. nit: you have method names `LowerBound` and `UpperBound`, where you probably want to fix the capitalization. Cheers, Lucas On Mon, Oct 23, 2023 at 5:46 PM Bill Bejeck wro

Re: [ANNOUNCE] New Kafka PMC Member: Satish Duggana

Congrats! On Fri, Oct 27, 2023 at 5:06 PM Manikumar wrote: > > Congrats! > > On Fri, Oct 27, 2023 at 8:35 PM Jun Rao wrote: > > > Hi, Everyone, > > > > Satish Duggana has been a Kafka committer since 2022. He has been very > > instrumental to the community since becoming a committer. It's my ple

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

Hi Hanyu, Thanks for the KIP! +1 (binding) Cheers Lucas On Thu, Nov 2, 2023 at 10:19 PM Hao Li wrote: > > Hi Hanyu, > > Thanks for the KIP! > +1 (non-binding) > > Hao > > On Thu, Nov 2, 2023 at 1:29 PM Bill Bejeck wrote: > > > Hi Hanyu, > > > > Thanks for the KIP this LGTM. > > +1 (binding) >

Re: [VOTE] KIP-892: Transactional StateStores

Hi Nick, really happy with the final KIP. Thanks a lot for the hard work! +1 (binding) Lucas On Mon, Nov 13, 2023 at 4:20 PM Colt McNealy wrote: > > +1 (non-binding). > > Thank you, Nick, for making all of the changes (especially around the > `default.state.isolation.level` config). > > Colt M

Re: [DISCUSS] KIP-968: Support single-key_multi-timestamp interactive queries (IQv2) for versioned state stores

Hi Alieh, I agree with Bruno that a weaker guarantee could be useful already, and it's anyway possible to strengthen the guarantees later on. On the other hand, it would be nice to provide a consistent view across all segments if it doesn't come with major downsides, because until now IQ does prov

Re: [VOTE] KIP-968: Support single-key_multi-timestamp interactive queries (IQv2) for versioned state stores

Hi Alieh, thanks for the KIP! +1 (binding) Lucas On Tue, Nov 21, 2023 at 11:26 AM Alieh Saeedi wrote: > > Thanks, Matthias; I changed it to `ANY` which is the shortest and not > misleading. > > Cheers, > Alieh > > On Mon, Nov 20, 2023 at 7:42 PM Matthias J. Sax wrote: > > > Adding an enum is

Re: [DISCUSS] KIP-924: customizable task assignment for Streams

Hi, Looks like a great KIP to me! I'm late, so I'm only going to comment on the last open point 117. I'm against any fallbacks like "use the default assignor if the custom assignment is invalid", as it's just going to hide bugs. For the 4 cases mentioned by Sophie: 117a) I'd fail immediately her

Re: [DISCUSS] KIP-989: RocksDB Iterator Metrics

gt; > >>>>> debate about a subset of them. That said, you do have 3 full weeks, > > so > > >>>>> I would hope that you could get both sets of metrics agreed upon in > > >>>>> that timeframe! > > >>>>

Re: [VOTE] KIP-924: customizable task assignment for Streams

Hi, thanks for the KIP! +1 (binding) Best, Lucas On Tue, May 7, 2024 at 9:37 AM Bruno Cadonna wrote: > > Thanks for the KIP! > > Looking forward to a well-structured task assignor! > > +1 (binding) > > Best, > Bruno > > On 5/3/24 2:44 AM, Matthias J. Sax wrote: > > I left one more nit on the d

Re: [VOTE] KIP-1036: Extend RecordDeserializationException exception

Thanks for the KIP! +1 binding On Tue, May 14, 2024 at 2:44 PM Frédérik Rouleau wrote: > > Hi all, > > I will keep the vote open for a few more hours as I would like to propose > the KIP for the next 3.8.0 release (deadline is the 15th May). > Currently we have +4 binding and +3 non-binding. > T

Re: [VOTE] KIP-989: RocksDB Iterator Metrics

Hi Nick! Thanks for the KIP. +1 (binding) On Tue, May 14, 2024 at 5:16 PM Nick Telford wrote: > > Hi everyone, > > I'd like to call a vote on the Kafka Streams KIP-989: RocksDB Iterator > Metrics: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-989%3A+RocksDB+Iterator+Metrics > > All of

Re: [DISCUSS] KIP-989: RocksDB Iterator Metrics

Hi Nick, you are still referring to oldest-open-iterator-age-ms in the `Proposed Changes` section. Cheers, Lucas On Thu, May 2, 2024 at 4:00 PM Lucas Brutschy wrote: > > Hi Nick! > > I agree, the age variant is a bit nicer since the semantics are very > clear from the name. If

Re: [DISCUSS] Apache Kafka 3.7.1 release

Hi Igor, thanks a lot! +1 Lucas On Thu, May 16, 2024 at 5:21 AM Luke Chen wrote: > > Hi Igor, > > Thanks for volunteering! > +1 > > Luke > > On Wed, May 15, 2024 at 11:15 PM Mickael Maison > wrote: > > > Hi Igor, > > > > Thanks for volunteering, +1 > > > > Mickael > > > > On Thu, Apr 25, 2024

Re: [VOTE] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

+1 (binding) thanks for the KIP! On Thu, Jun 13, 2024 at 2:32 AM Matthias J. Sax wrote: > > +1 (binding) > > On 6/11/24 1:17 PM, Sophie Blee-Goldman wrote: > > +1 (binding) > > > > Thanks for the KIP! > > > > On Tue, Jun 11, 2024 at 5:37 AM jiang dou wrote: > > > >> HI > >> I would like to star

Re: [VOTE] KIP-1035: StateStore managed changelog offsets

Thanks, Nick! +1 (binding) On Wed, Jun 19, 2024 at 10:14 AM Sophie Blee-Goldman wrote: > > +1 (binding) thanks Nick! > > On Thu, Jun 13, 2024 at 12:39 AM Bruno Cadonna wrote: > > > Thanks Nick! > > > > Great KIP! > > > > +1 (binding) > > > > Best, > > Bruno > > > > On 6/13/24 2:31 AM, Matthias

[DISCUSS] KIP-1071: Streams Rebalance Protocol

Hi all, I would like to start a discussion thread on KIP-1071: Streams Rebalance Protocol. With this KIP, we aim to bring the principles laid down by KIP-848 to Kafka Streams, to make rebalances more reliable and scalable, and make Kafka Streams overall easier to deploy and operate. The KIP propos

Re: [VOTE] KIP-1070: Deprecate MockProcessorContext

Sounds good to me! +1 (binding) On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck wrote: > > +1 (binding) > > On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman > wrote: > > > Makes sense to me, +1 (binding) > > > > On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax wrote: > > > > > Hi, > > > > > > I

Re: [DISCUSS] KIP-1068: KIP-1068: New JMX Metrics for AsyncKafkaConsumer

Hey Brenden, thanks for the KIP! These will be great to observe and debug the background thread of the new consumer. LB1. `time-between-network-thread-poll-max` → I see several similar metrics including the unit in the metric name (ms or us). We could consider this, although it's probably not str

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

really understanding what's written when, > I can't do a thorough job of reviewing. > > AS10: In the definitions of the record keys, such as > StreamsGroupCurrentMemberAssignmentKey, the versions of the fields must > match the versions of the types. > > Thanks, &

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

d probably > put all of the gory details in this KIP, but then it’s not my KIP. A future > pointer is fine too. > > Thanks, > Andrew > > > > On 19 Jul 2024, at 13:46, Lucas Brutschy > > wrote: > > > > Hi Andrew, > > > > thanks for gett

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

tant improvement that brings a > > >> difference in behaviour around the static membership: with the classic > > >> protocol, if a static member joins with a group instance already in > > use, it > > >> makes the initial member fail with a FENCED_INSTANCE

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

eric (which wouldn't cover share groups). I think for now, all comments are addressed. Cheers, Lucas On Tue, Aug 6, 2024 at 3:19 PM Lucas Brutschy wrote: > > Hi Lianet and Andrew, > > LM1/LM2: You are right. The idea is to omit fields exactly in the same > situations as in K

Re: [DISCUSS] KIP-1076: Metrics for client applications a KIP-714 extension

Hi Bill! Thanks for the KIP! I like this solution, it's general enough for many kinds of application. LB1: Could we accept an instance of the Metric interface instead of KafkaMetric? No strong reason to do it, it would just make the interface slightly more generic. LB2: What is the behavior is `

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

the tool does it > apply to? I suppose it’s --delete, but it’s not clear to me. > > Thanks, > Andrew > > > On 11 Aug 2024, at 12:10, Lucas Brutschy > > wrote: > > > > Hi Andrew/Lianet, > > > > I have added an administrative command-line tool (rep

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

aviour is that clients will only send > the changelog offsets for the stateful Tasks that they are able to lock > on-disk. Since this is a change in behaviour, perhaps this should be called > out explicitly? > > Regards, > Nick > > On Thu, 15 Aug 2024 at 10:55, Lucas Brutschy

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

or the same Tasks. > > But it sounds like this is not correct, and that the new assignor will make > the same assumptions as the old one? > > Regards, > Nick > > On Fri, 16 Aug 2024 at 10:17, Lucas Brutschy > wrote: > > > Hi Nick! > > > > Thanks for

Re: [VOTE] KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Thanks for the KIP and the cleanup! +1 (binding). Lucas On Sun, Aug 18, 2024 at 7:37 PM Chia-Ping Tsai wrote: > > +1 (binding) > > Kuan Po Tseng 於 2024年8月19日 週一 上午12:41寫道： > > > Hello everyone, > > > > After reviewing the feedback received ( > > https://lists.apache.org/thread/6wvbfkjldm8gnbf9

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

t; > > > Anyway, given your point about it not being possible to guarantee disjoint > > sets, does it make sense to require clients to continue to supply the lags > > for only a subset of the dormant Tasks on-disk? Wouldn't it be simpler to > > just have them supply

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

wouldn't that defy the aim of doing a rolling bounce of the application (in case b)? Cheers, Lucas On Mon, Aug 19, 2024 at 3:59 PM Lucas Brutschy wrote: > > Hi Nick, > > NT4: As discussed, we will still require locking in the new protocol > to avoid concurrent read/write ac

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

accepted and hence in > an rolling bounce upgrade case the new application's topology would > not be executed. And if it keeps happening, operators would use > DescribeStreamsGroup to ping down who are the culprits. > > > > On Mon, Aug 19, 2024 at 7:06 AM Lucas Brutschy > wrot

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

e fine without a topology ID change (this is again where > I'm not sure about). > > If any of those assumptions are not true in practice, then I agree > it's still worth adding the complexity to continue processing for any > processing logic changes. > > Re: initialization st

Re: [DISCUSS] KIP-969: Support range interactive queries for versioned state stores

Hi Alieh, I think we do not have to restrict ourselves too much for the future and complicate the implementation. The user can always store away and sort, so we should only provide the ordering guarantee we can provide efficiently, and we shouldn't restrict our future evolution too much by this. I

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

Congratulations, Divij! On Fri, Dec 29, 2023 at 1:32 AM Colin McCabe wrote: > > Congratulations, Divij! > > best, > Colin > > On Thu, Dec 28, 2023, at 11:38, Bruno Cadonna wrote: > > Congratulations Divij! Well deserved! > > > > Best, > > Bruno > > > > On 12/27/23 12:45 PM, Luke Chen wrote: > >>

Re: Kafka trunk test & build stability

Thanks for all the work that has already been done on this in the past days! Have we considered running our test suite with -XX:+HeapDumpOnOutOfMemoryError and uploading the heap dumps as Jenkins build artifacts? This could speed up debugging. Even if we store them only for a day and do it only fo

Re: Apache Kafka 3.7.0 Release

Hi, we have fixed one memory leak in Kafka Streams, but there is still at least one missing in the code. I created https://issues.apache.org/jira/browse/KAFKA-16089 which is a blocker. Cheers, Lucas On Sun, Jan 7, 2024 at 12:05 PM Apoorv Mittal wrote: > > Hi Colin, > Thanks for the response. Th

Re: Kafka-Streams-Scala for Scala 3

Hi Matthiases, I know Scala 2 fairly well, so I'd be happy to review changes that add Scala 3 support. However, as Matthias S. said, it has to be driven by people who use Scala day-to-day, since I believe most Kafka Streams committers are working with Java. Rewriting the tests to not use Embedded

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

Hey Walker Thanks for the KIP, and congrats on the KiBiKIP ;) My main point is that I'd vote against introducing `reprocessOnRestore`. The behavior for `reprocessOnRestore = false` is just incorrect and should be removed or deprecated. If we think we need to keep the old behavior around, renaming

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

bility, and yes, with great power > comes great responsibility for the users :) > > But this actually highlights a different aspect: the overload not > accepting a custom `Processor` but using a built-in processor, should > not accept a generic `StoreBuilder` but should restrict t

Re: [ANNOUNCE] New committer: Christo Lolov

Congrats! On Tue, Mar 26, 2024 at 2:44 PM Federico Valeri wrote: > > Congrats! > > On Tue, Mar 26, 2024 at 2:27 PM Mickael Maison > wrote: > > > > Congratulations Christo! > > > > On Tue, Mar 26, 2024 at 2:26 PM Chia-Ping Tsai wrote: > > > > > > Congrats Christo! > > > > > > Chia-Ping

Re: [VOTE] KIP-1020 Move `window.size.ms` and `windowed.inner.serde.class` from `StreamsConfig` to TimeWindowedDe/Serializer class

+1 (binding) Thanks, Lucia! On Wed, Apr 3, 2024 at 11:35 PM Sophie Blee-Goldman wrote: > > +1 (binding) > > Thanks Lucia! > > On Tue, Apr 2, 2024 at 12:23 AM Matthias J. Sax wrote: > > > +1 (binding) > > > > > > -Matthias > > > > On 4/1/24 7:44 PM, Lucia Cerchie wrote: > > > Hello everyone, > >

Re: [DISCUSS] KIP-1038: Add Custom Error Handler to Producer

Hey Alieh, some comments: * "Compatibility" section wasn't clear to me. Are we just introducing the interfaces or are we changing the default behavior? If so, that should be explained in more detail. * If we are introducing a new interface `ClientExceptionHandler`, what is it going to be used for

Re: [ANNOUNCE] New Kafka PMC Member: Greg Harris

Congrats! On Thu, Apr 18, 2024 at 6:50 PM Justine Olshan wrote: > > Congratulations Greg! > > On Thu, Apr 18, 2024 at 12:03 AM Matthias J. Sax wrote: > > > Congrats Greg! > > > > On 4/15/24 10:44 AM, Hector Geraldino (BLOOMBERG/ 919 3RD A) wrote: > > > Congrats! Well deserved > > > > > > From: d

Re: [DISCUSS] KIP-1034: Dead letter queue in Kafka Streams

Hi! Thanks for the KIP, great stuff. L1. I was a bit confused that the default configuration (once you set a DLQ topic) is going to be fail-and-send-to-DLQ, if I understood correctly. Is this something that will be a common use-case, and is it a configuration that we want to encourage? It expecte

Re: [VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

+1 (binding) On Thu, Aug 22, 2024 at 11:27 PM Bill Bejeck wrote: > > +1 (binding) > > On Thu, Aug 22, 2024 at 2:15 PM Matthias J. Sax wrote: > > > +1 (binding) > > > > On 8/21/24 11:09 PM, 黃竣陽 wrote: > > > +1 (non-binding) > > > > > > Best regard, > > > Jiunn Yang > > > > >

Re: [DISCUSS] KIP-1027 Add MockFixedKeyProcessorContext

Hi everybody, this KIP is looking good to me. Just note that the release version is set to 3.8 and should probably be updated. Are we ready to open a vote on this one? I do not have any additional comments. Cheers, Lucas On Mon, Jun 24, 2024 at 12:55 AM Shashwat Pandey wrote: > > Totally agree

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

Hi Sophie, Thanks for your detailed comments - much appreciated! I think you read a version of the KIP that did not yet include the admin command-line tool and the Admin API extensions, so some of the comments are already addressed in the KIP. S1. StreamsGroupHeartbeat and StreamsGroupInitialize

Re: [DISCUSS] KIP-1087: Removing intermediateTopicsOption from StreamsResetter

Hi Arnav, thanks for the KIP! I agree with it, I don't have any comments. I think it could be an option to open the vote immediately, since it's not going to be a controversial change. Cheers Lucas On Sun, Sep 1, 2024 at 10:19 PM Arnav Dadarya wrote: > > Hi all, > > I would like to start a di

Re: [VOTE] KIP-1076: Metrics for client applications a KIP-714 extension

Hi Bill, thanks for the KIP! +1 (binding) Lucas On Tue, Sep 3, 2024 at 4:49 PM Bill Bejeck wrote: > > Hi All, > > I'd like to call for a vote on KIP-1076 > > (discussion can be fo

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

sticky assignors implemented on the brokers, > and could still define all the Streams configs as broker configs to be > passed into the streams custom broker assignors. That feels like a lot less > work than redoing our own group protocol from scratch? > > I don't want you guys to think I&#x

Re: [ANNOUNCE] New Kafka PMC Member: Josep Prat

Hi Josep, congratulations! Well deserved! Cheers, Lucas On Fri, Sep 6, 2024 at 6:25 PM Chris Egerton wrote: > > Hi all, > > Josep has been a Kafka committer since December 2022. He has remained very > active and instructive in the community since then, and it's my pleasure to > announce that he

Re: New release branch 3.9

Hi Colin, about KAFKA-17489, the bug Bruno mentioned. This needs to be fixed in 3.8 as well. The fix is probably small but tricky to get right - Bruno has attempted to fix it, but soaking revealed that the fix is not complete. Bruno is now out with Covid, so I will look into it. I'll update this t

Re: [DISCUSS] KIP-1043: Administration of groups

Hi Andrew, thanks for the KIP! It is looking good from my side! I like the simplification, and that we added the new error but only of the Describe RPCs. It's a good pragmatic improvement of the current state of things. I only have very minor comments: - nit: In `GroupListing`, you seem to impo

Re: [DISCUSS] KIP-878: Autoscaling for Statically Partitioned Streams

Hi Sophie, This looks like a good improvement (given my limited knowledge, at least). As I understand it, in the subset of use cases where it can be used, it will make scaling up the #partitions basically frictionless. Three questions, and forgive me if something doesn't make sense at all: 1) Fr

Re: [DISCUSS] KIP-878: Autoscaling for Statically Partitioned Streams

Hi all, thanks, Sophie, this makes sense. I suppose then the way to help the user not apply this in the wrong setting is having good documentation and a one or two examples of good use cases. I think Colt's time-based partitioning is a good example of how to use this. It actually doesn't have to

Re: [VOTE] KIP-869: Improve Streams State Restoration Visibility

We need this! + 1 non binding Cheers, Lucas On Tue, Nov 1, 2022 at 10:01 AM Bruno Cadonna wrote: > > Guozhang, > > Thanks for the KIP! > > +1 (binding) > > Best, > Bruno > > On 25.10.22 22:07, Walker Carlson wrote: > > +1 non binding > > > > Thanks for the kip! > > > > On Thu, Oct 20, 2022 at 1

Re: [ANNOUNCE] New Kafka PMC Member: Bruno Cadonna

Wow, congratulations! On Tue, Nov 1, 2022 at 8:55 PM Chris Egerton wrote: > > Congrats! > > On Tue, Nov 1, 2022, 15:44 Bill Bejeck wrote: > > > Congrats Bruno! Well deserved. > > > > -Bill > > > > On Tue, Nov 1, 2022 at 3:36 PM Guozhang Wang wrote: > > > > > Hi everyone, > > > > > > I'd like to

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

Hi Nick, I'm just starting to read up on the whole discussion about KIP-892 and KIP-844. Thanks a lot for your work on this, I do think `WriteBatchWithIndex` may be the way to go here. I do have some questions about the latest draft. A) If I understand correctly, you propose to put a bound on th

Re: [VOTE] KIP-907: Add Boolean Serde to public interface

+1 (non-binding) Thank you! On Wed, Mar 1, 2023 at 9:03 PM Matthias J. Sax wrote: > > +1 (binding) > > Thanks for the KIP! > > On 3/1/23 10:59 AM, Walker Carlson wrote: > > +1 Binding > > > > On Mon, Feb 27, 2023 at 1:46 PM Chia-Ping Tsai wrote: > > > >> +1 (binding) > >> > >

Re: [VOTE] KIP-904: Kafka Streams - Guarantee subtractor is called before adder if key has not changed

+1 (non-binding) Thanks! On Wed, Mar 1, 2023 at 9:03 PM Matthias J. Sax wrote: > > +1 (binding) > > Thanks for the KIP! > > On 3/1/23 10:58 AM, Walker Carlson wrote: > > +1 Binding > > > > On Mon, Feb 27, 2023 at 12:48 PM Guozhang Wang > > wrote: > > > >> +1. > >> > >> On Sun, Feb 26, 2023 at 4

Re: [ANNOUNCE] New Kafka PMC Member: David Arthur

Congratulations! On Thu, Mar 9, 2023 at 8:37 PM Manikumar wrote: > > Congrats David! > > > On Fri, Mar 10, 2023 at 12:24 AM Josep Prat > wrote: > > > > Congrats David! > > > > ——— > > Josep Prat > > > > Aiven Deutschland GmbH > > > > Alexanderufer 3-7, 10117 Berlin > > > > Amtsgericht Charlotten

Re: [ANNOUNCE] New Kafka PMC Member: Chris Egerton

Congratulations! On Thu, Mar 9, 2023 at 8:48 PM Roman Schmitz wrote: > > Congratulations Chris! > > Am Do., 9. März 2023 um 20:33 Uhr schrieb Chia-Ping Tsai >: > > > Congratulations Chris! > > > > > Mickael Maison 於 2023年3月10日 上午2:21 寫道： > > > > > > Congratulations Chris! > > > > > >> On Thu,

Re: Fwd: [VOTE] KIP-914 Join Processor Semantics for Versioned Stores

Hi, No concerns at all, just a clarifying question from my side: for detecting out-of-order records, I need both new and old timestamp, I suppose I get it for the new record via timestamp extractor, can I not get it the same way from the old record that is passed down to the aggregation after KIP-

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

HI Walker, thanks for the KIP! We definitely need this. I have two questions: - Have you considered allowing the customization of the underlying buffer implementation? As I can see, `StreamJoined` lets you customize the underlying store via a `WindowStoreSupplier`. Would it make sense for `Joine

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

> > > -Matthias > > > > > > > > > > > > > > > On 5/2/23 2:06 PM, Victoria Xia wrote: > > > > Cool KIP, Walker! Thanks for sharing this proposal. > > > > > > > > A few clarifications: > > >

Re: [VOTE] KIP-923: Add A Grace Period to Stream Table Join

Hi Walker, +1 (non-binding) Cheers, Lucas On Mon, Jun 5, 2023 at 4:20 PM Bruno Cadonna wrote: > > Hi Walker, > > Thank you for the KIP! > > +1 (binding) > > Best, > Bruno > > On 24.05.23 23:00, Walker Carlson wrote: > > Hello everybody, > > > > I'm opening the vote on KIP-923 here > >

Re: [ANNOUNCE] New committer: Divij Vaidya

Congrats!! On Wed, Jun 14, 2023 at 11:02 AM Federico Valeri wrote: > > Congrats Divij! > > On Wed, Jun 14, 2023 at 10:02 AM Divij Vaidya wrote: > > > > Thank you everyone! I promise to shoulder this new responsibility to the > > best of my abilities. > > > > -- > > Divij Vaidya > > > > > > > > O

Re: [VOTE] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

+1 (binding) Thanks for the KIP! Lucas On Fri, Oct 4, 2024 at 2:29 AM Matthias J. Sax wrote: > > +1 (binding) > > On 10/3/24 4:35 PM, Kirk True wrote: > > +1 (non-binding) > > > > On Wed, Oct 2, 2024, at 12:41 PM, Alieh Saeedi wrote: > >> Hi all > >> > >> I would like to call a vote for KIP-1094

Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

Hi Frank, thanks for the KIP! 1) For consistency, should we do the same for kafka-share-groups.sh, ShareGroupDescription, etc. ? Even if we do not implement it right now if the share group implementation may still be incomplete, it may make sense to include it in the KIP. 2) Why call it CONSUMER

Re: [DISCUSS] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

Hi, 1. I don't think we can/should break backwards compatibility. 2. Have you considered using `BiFunction foreignKeyExtractor` ? This should work without renaming the method. 3. I don't see the benefit of deprecating it. I agree, we wouldn't add both overloads normally, but the value-only overloa

Re: [VOTE] KIP-1043: Administration of groups

Hi Andrew, thanks for the KIP! +1 (binding) Cheers, Lucas On Mon, Sep 23, 2024 at 9:27 AM Andrew Schofield wrote: > > Hi, > I would like to start voting for KIP-1043: Administration of groups. This KIP > enhances the command-line tools to make it easier to administer groups on > clusters wit

Re: [VOTE] KIP-1034: Dead letter queue in Kafka Streams

Thanks for the KIP! +1 (binding) Cheers, Lucas On Thu, Sep 26, 2024 at 3:22 PM Bill Bejeck wrote: > > Thanks for the KIP, this will be a great addition. > > +1(binding) > > Regards, > Bill > > On Thu, Sep 26, 2024 at 9:19 AM Bruno Cadonna wrote: > > > Thanks Loïc, Sebastien, and Damien, > > >

Re: [VOTE] KIP-1090 Flaky Test Management

+1 (binding) Thanks, David, for all the hard work on this On Fri, Sep 27, 2024 at 2:21 AM David Arthur wrote: > > > Could you please add the KIP link to KAFKA-17629 > > Done. > > On Thu, Sep 26, 2024 at 8:11 PM Bill Bejeck wrote: > > > +1 > > > > On Thu, Sep 26, 2024 at 8:08 PM Lianet M. wrote

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

> building off 848 vs introducing a separate Streams group protocol. This > > really helped me understand the motivations behind this decision. No notes! > > > > On Fri, Sep 6, 2024 at 7:17 AM Lucas Brutschy > > wrote: > > > >> Hi Sophie, > >&

Re: [VOTE] KIP-1091: Improved Kafka Streams operator metrics

Hey Bill, thanks for the KIP! +1 (binding) Cheers, Lucas On Wed, Nov 6, 2024 at 2:00 AM Bill Bejeck wrote: > > Hi All, > > I'd like to call for a vote on KIP-1091 > > (discussion thread > <

Re: [DISCUSS] KIP-655: Add deduplication processor in kafka-streams

Hi Ayoub, I see that there was already a very long discussion thread, I won't start nitpicking names here. I think we are ready to move on to a vote. The agreed upon solutioins sound very reasonable to me, I especially like how you handled the ALOS case. Not deduplicating late records is a defensi

Re: [VOTE] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

Hi, thanks for the KIP! +1 (binding) Cheers, Lucas On Thu, Nov 7, 2024 at 7:31 AM Chu Cheng Li wrote: > > Hi all, > > I'd like to call for a vote on KIP-1104 > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1104%3A+Allow+Foreign+Key+Extraction+from+Both+Key+and+Value+in+KTable+Joins > <

Re: [DISCUSS] KIP-1104: Allow Foreign Key Extraction from Both Key and Value in KTable Joins

Hey, this makes sense to me! Thank you for the KIP. I think the change is straightforward, and I think we can just vote this through. The only thing we could discuss is whether we want to keep the old overloads. I thought about it, but I think I agree that it's nicer to simplify the API a bit eve

Re: [DISCUSS] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics

Hi all, Thanks for the KIP! Super useful. No new comments, let me just voice my opinion on the suggestions being made. A1: When I read `require.auto.generated.topic.names`, it sounds like explicit naming is not allowed if the config is true. This is not what we are doing here. So to avoid the ne

Re: [VOTE] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

Hi PoAn, a minor follow-up question. The isClassic boolean in the Admin API, seems to use a boxed type `Boolean` instead of an unboxed boolean. It seems we could use the unboxed type here. Cheers, Lucas On Tue, Nov 26, 2024 at 1:55 AM PoAn Yang wrote: > > Hi everyone, > > Thanks for your voting

Re: [VOTE] KIP-1112: allow custom processor wrapping

Thanks! +1 (binding) Lucas Bill Bejeck schrieb am Di., 19. Nov. 2024, 00:06: > Thanks for the KIP, Sophie, seems like a useful addition. > > +1(binding) > > -Bill > > On Mon, Nov 18, 2024 at 3:23 PM Sophie Blee-Goldman > > wrote: > > > Since there have been no concerns about this proposal I'm

Re: [DISCUSS] KIP-1112: allow custom processor wrapping

Hey, I'm a bit confused since the motivation promises a cleanup of topologyconfig/streams config, but this doesn't seem to be part of this kip. But on the whole, this change looks fine for me. Thanks for the KIP! Cheers, Lucas, Sophie Blee-Goldman schrieb am Di., 19. Nov. 2024, 00:48: > One m

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

och is not valid, that means > >> > the topology ID is an old one and the group coordinator does not > >> > re-initialize the topology. > >> > > >> > The current topology epoch can be retrieved with the describe RPC. > >> > > >> > Acc

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

ogy with member.topology_ID for purposes of > verification (eg detecting the STREAMS_INVALID_TOPOLOGY_EPOCH case) and get > verification on every heartbeat without all the extra bytes. Probably not > an issue most of the time but people can run some truly huge topologies. > > On Tue,

Re: [VOTE] KIP-655: Add deduplication processor in kafka-streams

Hi, thanks for the KIP! +1 (binding) Cheers, Lucas Ayoub Omari schrieb am Di., 19. Nov. 2024, 13:40: > Hi everyone, > > I would like to start a vote on KIP-655 which adds deduplication processor > in kafka-streams: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-655%3A+Windowed+Dist

Re: [ANNOUNCE] New committer: Andrew Schofield

Congrats! Well deserved. Cheers, Lucas On Mon, Dec 2, 2024 at 4:20 PM Bill Bejeck wrote: > > Congrats Andrew! Well deserved. > > -Bill > > On Mon, Dec 2, 2024 at 10:11 AM Yash Mayya wrote: > > > Congrats Andrew! > > > > On Mon, 2 Dec, 2024, 20:26 PoAn Yang, wrote: > > > > > Congratulations And

  1   2   3   >