Hey Brenden, thanks for the KIP! These will be great to observe and debug the background thread of the new consumer.
LB1. `time-between-network-thread-poll-max` → I see several similar metrics including the unit in the metric name (ms or us). We could consider this, although it's probably not strictly required. However, at least the description should state the unit. Same for the `avg` version. LB2. `unsent-requests-size` → Naming sounds a bit like it's referring to the size of the request. How about `unsent-request-queue-size` or `unsent-request-count` or simply `unsent-requests`? LB3. "the proposed metrics below will be set to null or 0." → which one will be set to null and which ones will be set to 0, and why? nit: "The current number of unsent requests in the consumer network" → Seems to be missing something? Cheers, Lucas On Fri, Jul 12, 2024 at 7:28 PM Brenden Deluna <bdel...@confluent.io.invalid> wrote: > > Hi Andrew, > Thank you for the feedback and your question. > > AS1. Great idea, I will get that added. > > AS2. For unsent-events-age-max, age will be calculated once the event is > sent, so you are correct. > > AS3. I agree, I think that would be a helpful metric to add, thank you! I > will get that added. > > Please let me know if you have any additional feedback, suggestions, or > questions. > > Thanks, > Brenden > > On Fri, Jul 12, 2024 at 11:45 AM Andrew Schofield <andrew_schofi...@live.com> > wrote: > > > Hi Brenden, > > Thanks for the KIP. It fills a gap in the metrics for the new consumer > > nicely. > > > > AS1. If using the CLASSIC protocol, and thus the LegacyKafkaConsumer, > > I would expect that the metrics do not exist at all. Maybe say something > > like > > “These metrics are for the new consumer implementation using the > > CONSUMER protocol”. > > > > AS2. For unsent-events-age-max, when is the age calculated? For example, > > is it calculated at the time that the unsent event is removed from the > > list and sent, or does the metric reflect unsent events which are still > > enqueued? I suspect the former, but thought I’d check. > > > > AS3. I think that unsent-events-age-avg would also be interesting to > > get an idea of how long unsent events tend to sit around before sending. > > Of course, the question from AS2 would also apply to the average. > > > > Thanks, > > Andrew > > > > > On 10 Jul 2024, at 17:44, Philip Nee <p...@confluent.io.INVALID> wrote: > > > > > > Hi all, > > > > > > This is the link to the KIP document. > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+JMX+metrics+for+the+new+KafkaConsumer > > > > > > Any comment is appreciated, > > > > > > > > > On Tue, Jul 9, 2024 at 10:14 AM Brenden Deluna > > <bdel...@confluent.io.invalid> > > > wrote: > > > > > >> Hello everyone, > > >> > > >> I would like to start the discussion thread for KIP-1068. This is a > > >> relatively small KIP, only proposing to add a couple of new metrics. > > >> > > >> If you have any suggestions or feedback, let me know, it will be much > > >> appreciated. > > >> > > > >
