Re: Review Request 30083: Patch for KAFKA-1839

, Jiangjie Qin

Re: Review Request 30083: Patch for KAFKA-1839

--- Thanks, Jiangjie Qin

[KIP-DISCUSSION] Mirror Maker Enhancement

Hi Kafka Devs, We are working on Kafka Mirror Maker enhancement. A KIP is posted to document and discuss on the followings: 1. KAFKA-1650: No Data loss mirror maker change 2. KAFKA-1839: To allow partition aware mirror. 3. KAFKA-1840: To allow message filtering/format conversion Feedbacks are wel

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

he offset commit thread commit thread periodically. It only commit the offsets that have been acked. > >3. Maintaining message order - In which JIRA do we implement this part? KAFKA-1650 > >Again, thanks a lot for documenting this and even more for the >implementation - it is super imp

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

, "Gwen Shapira" wrote: >Thanks for the answers. Much clearer now :) > >Unrelated question: How do you test MirrorMaker (especially around data >loss)? >I didn't see any unit-tests or integration tests in trunk. > >Gwen > >On Wed, Jan 21, 2015 at

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

onsumer get checked in. I¹ll document the changes and can submit follow up patches after the new consumer is available. > >-Jay > >On Tue, Jan 20, 2015 at 4:31 PM, Jiangjie Qin >wrote: > >> Hi Kafka Devs, >> >> We are working on Kafka Mirror Maker enhancement. A

Review Request 30199: Patch for KAFKA-1890

/browse/KAFKA-1890 Repository: kafka Description --- Patch for KAFKA-1890 Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 Diff: https://reviews.apache.org/r/30199/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 30199: Patch for KAFKA-1890

e.org/r/30199/#review69337 --- On 一月 23, 2015, 3:57 a.m., Jiangjie Qin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 30199: Patch for KAFKA-1890

://reviews.apache.org/r/30199/diff/ Testing --- Thanks, Jiangjie Qin

Review Request 30231: Patch for KAFKA-1896

/browse/KAFKA-1896 Repository: kafka Description --- patch for KAFKA-1896 Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala 3ee84ed9cbde5d882cdc7f630b0deca7dd00fc73 Diff: https://reviews.apache.org/r/30231/diff/ Testing --- Thanks, Jiangjie Qin

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

er. I think we can probably just have N threads, each thread has a >> producer and consumer and is internally single threaded. Any reason this >> wouldn't work? >> >> -Jay >> >> >> On Wed, Jan 21, 2015 at 5:29 PM, Jiangjie Qin >> >> wrote: >&g

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

this? Thanks. Jiangjie (Becket) Qin On 1/26/15, 10:35 AM, "Jiangjie Qin" wrote: >Hi Jay and Neha, > >Thanks a lot for the reply and explanation. I do agree it makes more sense >to avoid duplicate effort and plan based on new consumer. I’ll modify the >KIP. > >To Jay

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

gt; >I am not sure if this is right discussion form to bring these to >your/kafka >Dev team attention. This might be off track, > > >Thanks, > >Bhavesh > >On Wed, Jan 28, 2015 at 11:07 AM, Jiangjie Qin >wrote: > >> I’ve updated the KIP page. Feedbacks are wel

Re: [VOTE] 0.8.2.0 Candidate 3

In meetup we said that KAFKA-1650 and follow up patches is included in 0.8.2, but it seems not on the list. On 1/29/15, 1:01 AM, "Magnus Edenhill" wrote: >+1 on librdkafka interop > >Minor nitpick: > KAFKA-1781 (state required gradle version in README) is included in the >Release notes but is

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

cer maintains a connection to each broker within the producer instance. Making producer instances to share the TCP connections is a very big change to the current design, so I suppose we won’t be able to do that. > > >Thanks, > >Bhavesh > >On Thu, Jan 29, 2015 at 11:50 AM, Jiangjie

Re: Review Request 30063: Patch for KAFKA-1840

Diffs (updated) - core/src/main/scala/kafka/tools/MirrorMaker.scala 81ae205ef7b2050d0152f29f8da7dd91b17b8b00 Diff: https://reviews.apache.org/r/30063/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 30063: Patch for KAFKA-1840

low-up patch for KAFKA-1840) - Jiangjie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70523 --- O

Re: Review Request 30063: Patch for KAFKA-1840

ddressed Joel's comments Addressed previous reviews. Diffs (updated) - core/src/main/scala/kafka/tools/MirrorMaker.scala 81ae205ef7b2050d0152f29f8da7dd91b17b8b00 Diff: https://reviews.apache.org/r/30063/diff/ Testing --- Thanks, Jiangjie Qin

Re: kafka.utils.DoublyLinkedList

We added this because in redesigned mirror maker we need a raw linked list so we can removed an acked offset from a linked list in O(1). Java and Scala linked list won¹t work in that case. It was initially put in side mirror maker as a private class, but later on we also want to have unit test for

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

get actual hashcode needs to be computed ?. > > >Thanks, > >Bhavesh > >On Fri, Jan 30, 2015 at 1:41 PM, Jiangjie Qin >wrote: > >> Hi Bhavesh, >> >> Please see inline comments. >> >> Jiangjie (Becket) Qin >> >> On 1/29/15, 7:00 PM, "Bhav

Re: kafka.utils.DoublyLinkedList

move this >>class >> and >> > use those? >> > >> > Also the convention for unit tests is if we have a class Foo.scala >>then >> we >> > would have a test FooTest.scala. So you can definitely write a unit >>test >> > for class

Re: Review Request 30063: Patch for KAFKA-1840

ew71132 ------- On Feb. 1, 2015, 8:17 a.m., Jiangjie Qin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30063

Review Request 30651: Patch for KAFKA-1922

8c3797a964a2760a00ed60530d1a48e3da473769 Diff: https://reviews.apache.org/r/30651/diff/ Testing --- Thanks, Jiangjie Qin

Re: [DISCUSS] KIPs

I¹m having an impression that KIP is mostly for new features but not for bug fixes. But I agree with Joel that it might make sense to have some big patches, even if they are bug fixes, to follow the KIP like process which is more strict. Jiangjie (Becket) Qin On 2/5/15, 4:57 PM, "Gwen Shapira" w

Review Request 30743: Patch for KAFKA-1839

543070f4fd3e96f3183cae9ee2ccbe843409ee58 core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020 Diff: https://reviews.apache.org/r/30743/diff/ Testing --- Thanks, Jiangjie Qin

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

I¹m a little bit concerned about the request routers among brokers. Typically we have a dominant percentage of produce and fetch request/response. Routing them from one broker to another seems not wanted. Also I think we generally have two types of requests/responses: data related and admin related

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

posal? > >Thanks, >Neha > >On Wed, Feb 4, 2015 at 12:12 PM, Jiangjie Qin >wrote: > >> In mirror maker we do not do de-serialization on the messages. Mirror >> maker use source TopicPartition hash to chose a producer to send >>messages >> from the

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

of all retries. I’ve just updated the KIP to explain why we used a list of unasked offsets per partition and what does no data loss mean for mirror maker, including behavior on retry. > >Thanks, >Neha > >On Sun, Feb 8, 2015 at 2:06 PM, Jiangjie Qin >wrote: > >> Hi Neha, >&

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

;> not? It will be easier to think about the design and also make the KIP >> complete if we make a call on the design first. >> 3. Can you explain the need for keeping a list of unacked offsets per >> partition? Consider adding a section on retries and how you plan to >>handle >>

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

-implement all the logics of mirror maker by themselves just in order to add this handling in pipeline. Any thoughts? Thanks. ―Jiangjie (Becket) Qin On 2/8/15, 6:35 PM, "Jiangjie Qin" wrote: >Hi Jay, thanks a lot for the comments. >I think this solution is better. We probably

Review Request 30810: Patch for KAFKA-1937

/browse/KAFKA-1937 Repository: kafka Description --- Fix for KAFKA-1937 Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala 5374280dc97dc8e01e9b3ba61fd036dc13ae48cb Diff: https://reviews.apache.org/r/30810/diff/ Testing --- Thanks, Jiangjie Qin

Re: [DISCUSSION] KIP-2: Refactor Brokers to Allow Multiple Endpoints

+1 on separating the end points for different purposes. On 2/12/15, 5:47 PM, "Gwen Shapira" wrote: >I REALLY like the idea of supporting separate network for inter-broker >communication (and probably Zookeeper too). >I think its actually a pretty typical configuration in clusters, so I'm >surpri

Review Request 31021: Patch for KAFKA-1951

/browse/KAFKA-1951 Repository: kafka Description --- Fix for KAFKA-1951 Diffs - core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 Diff: https://reviews.apache.org/r/31021/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31021: Patch for KAFKA-1951

org/r/31021/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31021: Patch for KAFKA-1951

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31021/#review72514 ------- On Feb. 17, 2015, 12:36 a.m., Jiangjie Qin wrote: > > --

Re: Review Request 30763: Patch for KAFKA-1865

stuff into producer, or commit offsets. For example, In mirror maker: ... for (rec <- recs) producer.send(rec1); producer.flush(); consumer.commitOffsets(); ... The caller thread could have already committed offsets even if something went wrong in callback

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

I'm thinking the flush call timeout will naturally be the timeout for a produce request, No? Currently it seems we don¹t have a timeout for client requests, should we have one? ‹Jiangjie (Becket) Qin On 2/16/15, 8:19 PM, "Jay Kreps" wrote: >Yes, I think we all agree it would be good to add a c

Re: Review Request 30763: Patch for KAFKA-1865

re in order: 1. set up the result 2. invoke callbacks 3. notify threads waiting on flush. Currently both 1 and 3 and done in this.produceFuture.done(), maybe we need to separate them? - Jiangjie Qin On Feb. 21, 2015, 11:37 p.m., Jay

Re: Review Request 30763: Second attempt at flush()

than one batch for a partition? - Jiangjie Qin On Feb. 23, 2015, 12:26 a.m., Jay Kreps wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 30763: Second attempt at flush()

$MirrorMakerProducer.flush(MirrorMaker.scala:373) at kafka.tools.MirrorMaker$MirrorMakerThread.run(MirrorMaker.scala:314) It looks that we should synchronize on the access to incomplete. i.e. when one thread is making a copy of imcomplete set, other thread should not add batches into it. - Jiangjie Qin On

Re: Review Request 30763: Second attempt at flush()

> On Feb. 23, 2015, 8:53 p.m., Jiangjie Qin wrote: > > Hi Jay, I applied the patch and tried to run it in our test environment. I > > got this exception: > > > > java.util.ConcurrentModificationException > > at java.util.HashMap$HashIterator.nextNode(

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

synchronized block around the line where we copy the imcomplete set and it seems worked. Maybe we can do that if you prefer less code. - Jiangjie Qin On Feb. 24, 2015, 2:31 a.m., Jay Kreps wrote: > > --- > This is an automatically ge

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

> On Feb. 24, 2015, 4:22 a.m., Jiangjie Qin wrote: > > LGTM. Thanks, Jay. > > I actually tried just putting a synchronized block around the line where we > > copy the imcomplete set and it seems worked. Maybe we can do that if you > > prefer less code. > > Ja

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

gt; > > > copied >> > > > > > to the target cluster, but that costs network bandwidth >> > unnecessarily, >> > > > > > especially if that is a cross colo mirror. With the handler, >>we >> can >> > > > > > co-locate the mirror maker with sou

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

I forgot to mention that we have tested the entire design in our test environment. The performance looks fine. Jiangjie (Becket) Qin On 2/24/15, 2:53 PM, "Jiangjie Qin" wrote: >I updated the KIP page based on the discussion we had. > >Should I launch another vote or we can

[VOTE] KIP-3 Mirror Maker Enhancement

https://cwiki.apache.org/confluence/display/KAFKA/KIP-3+-+Mirror+Maker+Enhancement +1

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

Sure! Just created the voting thread :) On 2/24/15, 4:44 PM, "Jay Kreps" wrote: >Hey Jiangjie, > >Let's do an official vote so that we know what we are voting on and we are >crisp on what the outcome was. This thread is very long :- > >-Jay > >On Tue

Re: Announcing the Confluent Platform built on Apache Kafka

Congrats! On 2/25/15, 11:30 AM, "Guozhang Wang" wrote: >+1, very nice! > >On Wed, Feb 25, 2015 at 11:20 AM, Sriram Subramanian < >srsubraman...@linkedin.com.invalid> wrote: > >> Congratulations! >> >> On 2/25/15 11:15 AM, "Joe Stein" wrote: >> >> >Awesome! >> > >> >The future of schema manageme

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

e to provide this feature in release version. > >Thanks, > >Bhavesh > > >On Tue, Feb 24, 2015 at 5:31 PM, Jiangjie Qin >wrote: > >> Sure! Just created the voting thread :) >> >> On 2/24/5, 4:44 PM, "Jay Kreps" wrote: >> >> >Hey

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

> On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 91 > > > > > > I still think it is kind of waste to create duplicate

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

correct mirroring behavior. > >Other than that, the KIP looks great! > >Thanks, >Neha > >On Wed, Feb 25, 2015 at 3:56 PM, Jiangjie Qin >wrote: > >> For 1), the current design allow you to do it. The customizable message >> handler takes in a ConsumerRecord and

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

t;(i.e. so existing dployments won't break)? > >Gwen > >On Thu, Feb 26, 2015 at 11:57 AM, Jiangjie Qin >wrote: > >> Hi Neha, >> >> Thanks for the comment. That’s a really good point. >> >> Originally I’m thinking about allowing user to tweak some para

Re: Review Request 31510: Patch for kafka-1400

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31510/#review74415 --- Ship it! Ship It! - Jiangjie Qin On Feb. 27, 2015, 12:15 a.m

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

*--consumer-rebalance-listener* >I don't really know the history of tis but let's move it to normal unix >dashes across the board as well as examine the options for any >other>inconsistencies. > >-Jay > > >On Thu, Feb 26, 2015 at 11:57 AM, Jiangjie Qin >wrote: &

Re: ConsumerTest

+1 On 2/27/15, 1:41 PM, "Harsha" wrote: >+1 > >On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: >> Would anyone object if I commented out the kafka.api.ConsumerTest out >> until >> it is fixed? It hangs and is making accepting patches very >> time-consuming. >> >> -- >> Thanks, >> Neha

Re: Review Request 25995: Patch for KAFKA-1650

NumUnackedMessages the same as UnackedOffsetListSize since they > > are always modified together? Good point! We probably should just use the UnackedOffsetListSize. It is more clear. - Jiangjie --- This is an automatically ge

Re: Review Request 31591: Patch for KAFKA-1992

/cluster/Partition.scala <https://reviews.apache.org/r/31591/#comment121610> This part seems now serving only logging purpose. If that is the case, can we make it even clearer. For example, print all the acked replicas instead of just a number. - Jiangjie Qin On March 1, 2015, 7:

Re: Review Request 29467: Patch for KAFKA-1660

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74833 --- Ship it! LGTM. - Jiangjie Qin On March 2, 2015, 6:41 p.m

Re: Review Request 29467: Patch for KAFKA-1660

elease the caller threads that are waiting on flush() at this point. - Jiangjie Qin On March 2, 2015, 6:41 p.m., Parth Brahmbhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 29467: Patch for KAFKA-1660

> On March 2, 2015, 11:04 p.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 219 > > <https://reviews.apache.org/r/29467/diff/4/?file=882250#file882250line219> > > > > We probably need

Re: [VOTE] KIP-3 Mirror Maker Enhancement

>> > +1 binding >> > >> > On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira >> wrote: >> > >> > > +1 (non-binding) >> > > >> > > On Tue, Feb 24, 2015 at 5:14 PM, Jiangjie Qin >> >> > > wrote: >>

Review Request 31706: Patch for KAFKA-1997

/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020 Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: [VOTE] KIP-7 Security - IP Filtering

+1 (non-binding) On 3/3/15, 1:17 PM, "Gwen Shapira" wrote: >+1 (non-binding) > >On Tue, Mar 3, 2015 at 12:44 PM, Jeff Holoman >wrote: >> Details in the wiki. >> >> >> >>https://cwiki.apache.org/confluence/display/KAFKA/KIP-7+-+Security+-+IP+F >>iltering >> >> >> >> -- >> Jeff Holoman >> System

Re: Review Request 31706: Patch for KAFKA-1997

sumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020 Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31706: Patch for KAFKA-1997

ommit check is outside the inner while loop, and > > hence will only be triggered when iter.hasNext() returns false? Good catch! - Jiangjie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3

Re: Review Request 31706: Patch for KAFKA-1997

enerated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75110 --- On March 4, 2015, 12:28 a.m., Jiangjie Qin wrote: > > --- > This is an automati

Re: Review Request 31706: Patch for KAFKA-1997

> On March 4, 2015, midnight, Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 67 > > <https://reviews.apache.org/r/31706/diff/1/?file=883687#file883687line67> > > > > Are we sure that one producer io thread is sufficient for a

Re: Review Request 31706: Patch for KAFKA-1997

/unit/kafka/consumer/PartitionAssignorTest.scala 543070f4fd3e96f3183cae9ee2ccbe843409ee58 core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020 Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31706: Patch for KAFKA-1997

31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31706: Patch for KAFKA-1997

iff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31706: Patch for KAFKA-1997

does the user override? Good catch! - Jiangjie ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75409 ---

Review Request 31830: Patch for KAFKA-2009

://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin

[DISCUSSION] KIP-15 close(timeout) for producer

Hi, I just created a KIP for adding a close(timeout) to new producer. Most of the previous discussions are in KAFKA-1660 where Parth Brahmbhatt has already done a lot of work. Since this is an interface change so we are going through the KIP process. Here is the KIP link: https://cwiki.apache.or

Create a space template for KIP

I am not sure how others are creating KIP. I just copy/paste the template page to a blank page. I think it would good to add a space template under Apache Kafka so when creating the child page, people can just use that. Is it worth doing? I tried but it requires space administrator permission.

Re: Create a space template for KIP

nfluence/display/KAFKA/KIP-Template > >Guozhang > >On Sat, Mar 7, 2015 at 12:35 PM, Jiangjie Qin >wrote: > >> I am not sure how others are creating KIP. I just copy/paste the >>template >> page to a blank page. I think it would good to add a space template >&

Re: Create a space template for KIP

isplay/KAFKA/KIP-Template > >Guozhang > >On Sat, Mar 7, 2015 at 12:35 PM, Jiangjie Qin >wrote: > >> I am not sure how others are creating KIP. I just copy/paste the >>template >> page to a blank page. I think it would good to add a space template >>under >&g

Re: problems submitting patch set for review and a bit of solution

I saw this a couple of weeks ago, too. It seems to be a bug of review board. Last time I waited for 2-3 days and the problem went away. Jiangjie (Becket) Qin On 3/8/15, 8:45 PM, "Tong Li" wrote: > > >While trying to submit a reviewboard request by running >kafka-patch-review, >I was getting som

Review Request 31850: Patch for KAFKA-1660

, Jiangjie Qin

Re: Review Request 29467: Patch for KAFKA-1660

permission to upload patch to this rb, so I created another one: https://reviews.apache.org/r/31850/ - Jiangjie Qin On March 2, 2015, 6:41 p.m., Parth Brahmbhatt wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 31850: Patch for KAFKA-1660

: https://reviews.apache.org/r/31850/diff/ Testing (updated) --- Unit tests passed. Thanks, Jiangjie Qin

Re: Review Request 31850: Patch for KAFKA-1660

tests passed. Thanks, Jiangjie Qin

Re: Review Request 31850: Patch for KAFKA-1660

re/src/test/scala/integration/kafka/api/ProducerSendTest.scala <https://reviews.apache.org/r/31850/#comment122997> Probably we cannot, because in this case the producer got closed for each iteration. So we have to create a new one. - Jiangjie Qin On March 9, 2015, 7:56 p

Re: Review Request 31850: Patch for KAFKA-1660

scala/integration/kafka/api/ProducerSendTest.scala 3df450784592b894008e7507b2737f9bb07f7bd2 Diff: https://reviews.apache.org/r/31850/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

Re: Review Request 31850: Patch for KAFKA-1660

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/#review75731 --- On March 9, 2015, 7:56 p.m., Jiangjie Qin wrote: &g

Re: [DISCUSSION] KIP-15 close(timeout) for producer

the >Callback. But it doesn't really explain that usage or why other people >would want to do that. It also doesn't list the primary use case for >having >close with a bounded timeout which was to avoid blocking too long on >shutdown. > >-Jay > > > >On Sat, Mar

Re: Review Request 31706: Patch for KAFKA-1997

ectorTest.scala 19640cc55b5baa0a26a808d708b7f4caf491c9f0 Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31706: Patch for KAFKA-1997

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75785 ------- On March 10, 2015, 1:55 a.m., Jiangjie Qin wrote: > > --

Re: Review Request 31706: Patch for KAFKA-1997

wn connector which will be our final design as well. - Jiangjie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75921 ---

Re: Review Request 31706: Patch for KAFKA-1997

/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 19640cc55b5baa0a26a808d708b7f4caf491c9f0 Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

Re: [DISCUSSION] KIP-15 close(timeout) for producer

was to avoid blocking too long on >shutdown. > >-Jay > > > >On Sat, Mar 7, 2015 at 12:25 PM, Jiangjie Qin >wrote: > >> Hi, >> >> I just created a KIP for adding a close(timeout) to new producer. Most >>of >> the previous discussions are in KAFKA-1

Re: Review Request 31830: Patch for KAFKA-2009

/src/main/scala/kafka/tools/MirrorMaker.scala bafa379ff57bc46458ea8409406f5046dc9c973e Diff: https://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin

Re: Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

feature warning(s); re-run with -feature for details I tried ./gradlew jar -feature, but it seems does not work at all. If this is the related issue, can we solve it in this patch? Otherwise we can create another ticket to address it. - Jiangjie Qin On March 11, 2015, 4:35 a.m., Blake Smith wrote

Re: Review Request 31706: Patch for KAFKA-1997

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review76121 ------- On March 11, 2015, 1:31 a.m., Jiangjie Qin wrote: > > ---

Re: Review Request 31706: Patch for KAFKA-1997

src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 19640cc55b5baa0a26a808d708b7f4caf491c9f0 Diff: https://reviews.apache.org/r/31706/diff/ Testing ------- Thanks, Jiangjie Qin

Re: Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

tests passed and compilation warnings went away. - Jiangjie Qin On March 11, 2015, 4:35 a.m., Blake Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30809: Patch for KAFKA-1888

onTest.java <https://reviews.apache.org/r/30809/#comment123655> Can we use KafkaThread here? - Jiangjie Qin On March 9, 2015, 11:55 p.m., Abhishek Nigam wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 30809: Patch for KAFKA-1888

> On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183 > > <https://reviews.apache.org/r/30809/diff/3/?file=889855#file889855line183> > > > > This is essentially a sync approac

Re: Review Request 31706: Patch for KAFKA-1997

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review76189 ------- On March 11, 2015, 10:20 p.m., Jiangjie Qin wrote: > >

Re: Review Request 31706: Patch for KAFKA-1997

rtitionAssignorTest.scala 543070f4fd3e96f3183cae9ee2ccbe843409ee58 core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 19640cc55b5baa0a26a808d708b7f4caf491c9f0 Diff: https://reviews.apache.org/r/31706/diff/ Testing ------- Thanks, Jiangjie Qin

[VOTE] KIP-15 add a close method with timeout to KafkaProducer

https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+producer

<    1   2   3   4   5   6   7   8   9   10   >