----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31925/#review76149 -----------------------------------------------------------
Ship it! Makes sense. Not a committer but looks good to me :) Unit tests passed and compilation warnings went away. - Jiangjie Qin On March 11, 2015, 4:35 a.m., Blake Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31925/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 4:35 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1054 > https://issues.apache.org/jira/browse/KAFKA-1054 > > > Repository: kafka > > > Description > ------- > > Brought the patch outlined [here](https://reviews.apache.org/r/25461/diff/) > up to date with the latest trunk and fixed 2 more lingering compiler warnings. > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala b700110 > core/src/main/scala/kafka/coordinator/DelayedJoinGroup.scala df60cbc > core/src/main/scala/kafka/server/KafkaServer.scala dddef93 > core/src/main/scala/kafka/utils/Utils.scala 738c1af > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala b46daa4 > > Diff: https://reviews.apache.org/r/31925/diff/ > > > Testing > ------- > > Ran full test suite. > > > Thanks, > > Blake Smith > >
