> On Feb. 5, 2015, 2:15 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 687-689 > > <https://reviews.apache.org/r/30063/diff/4/?file=843092#file843092line687> > > > > Is there an expected use case for one-to-many handlers?
Yes, for example some user might want to accumulate a trasaction until it either finishes or aborts. > On Feb. 5, 2015, 2:15 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 182-186 > > <https://reviews.apache.org/r/30063/diff/4/?file=843092#file843092line182> > > > > How about use the "embeded handler config file" as we did for producer > > and consumer, this gives us more flexibility as well as better > > operatibility. I also felt a little bit less strict for this handler argument and thought over this. For producer/consumer config are all key-value pairs, but for handler it might not be the case. In current way, we can let user to decide whether they want to use a config file (they can always put a file name as commandline argument) or just use some simple commandline config parameters without creating a config file. So we let user interpret what the command line argument. What do you think? - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review71132 ----------------------------------------------------------- On Feb. 1, 2015, 8:17 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30063/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2015, 8:17 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1840 > https://issues.apache.org/jira/browse/KAFKA-1840 > > > Repository: kafka > > > Description > ------- > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > KAFKA-1840 > > > Addressed Joel's comments > > > Allow message handler to specify partitions for produce > > > Addressed Joel's comments > > > Addressed previous reviews. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 81ae205ef7b2050d0152f29f8da7dd91b17b8b00 > > Diff: https://reviews.apache.org/r/30063/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
