[DISCUSS] KIP-390: Add producer option to adjust compression level

2018-11-18 Thread Dongjin Lee
Hello dev, I hope to initiate the discussion of KIP-390: Add producer option to adjust compression level <https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Add+producer+option+to+adjust+compression+level>. All feedbacks will be highly appreciated. Best, Dongjin -- *Dongjin Le

Re: [ANNOUNCE] Apache Kafka 2.1.0

2018-11-22 Thread Dongjin Lee
Ron Dagostino, Sam Lendle, Sandor Murakozi, > Simon Clark, Stanislav Kozlovski, Stephane Maarek, Sébastien Launay, Sönke > Liebau, Ted Yu, uncleGen, Vahid Hashemian, Viktor Somogyi, wangshao, > xinzhg, Xiongqi Wesley Wu, Xiongqi Wu, ying-zheng, Yishun Guan, Yu Yang, > Zhanxiang (Patrick) Huang &

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2018-11-27 Thread Dongjin Lee
Is there anyone who is interested in this KIP? Thanks, Dongjin On Mon, Nov 19, 2018 at 7:06 AM Dongjin Lee wrote: > Hello dev, > > I hope to initiate the discussion of KIP-390: Add producer option to > adjust compression level > <https://cwiki.apache.org/confluence/display/KA

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2018-11-28 Thread Dongjin Lee
ant to allow the buffer/block size to be configurable? This has > an impact on memory usage and people may want to trade compression for > less/more memory in some cases. For example, the default for LZ4 is 64KB > which is a bit high. > > Ismael > > On Sun, Nov 18, 2018, 2:07 PM

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2018-12-02 Thread Dongjin Lee
ussed in the PR. The more general point is to rely on > the library defaults instead of choosing one ourselves. > > For point 3, I'm in favour of doing that in this KIP. > > Ismael > > On Wed, Nov 28, 2018 at 7:01 AM Dongjin Lee wrote: > > > Thank you Ismael, here

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-06 Thread Dongjin Lee
/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression Please have a look when you are free. Thanks, Dongjin On Mon, Dec 3, 2018 at 12:50 AM Ismael Juma wrote: > The updated title sounds fine to me. > > Ismael > > On Sun, Dec 2, 2018, 5:25 AM Dongjin Lee

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-06 Thread Dongjin Lee
> > On Sun, Jan 6, 2019, 10:37 AM Dongjin Lee > > Happy new year. > > > > I just updated the title and contents of KIP and Jira issue, with updated > > draft implementation. Now both of compression level and buffer size > options > > are available to producer and

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-14 Thread Dongjin Lee
o handle all kinds of the supported codec. So I added additional options (compression.[gzip,snappy,lz4, zstd].level, compression.[gzip,snappy,lz4, zstd].buffer.size) with handling routines. Please have a look when you are free. Thanks, Dongjin On Mon, Jan 7, 2019 at 6:23 AM Dongjin Lee wrote: > Th

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-15 Thread Dongjin Lee
te the contributions and we are looking forward to more. > > Congrats Vahid! > > > > Jason, on behalf of the Apache Kafka PMC > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https:/

Re: [DISCUSS] Kafka 2.2.0 in February 2018

2019-01-19 Thread Dongjin Lee
gt; > >> release) > > >> > > >> 2) Feature Freeze: Jan 31, 2019 > > >> > > >> Major features merged & working on stabilization, minor features have > > >> PR, release branch cut; anything not in this state will be > automatically > >

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-19 Thread Dongjin Lee
mpression level, and zstd doesn't support buffer size.) If there are no other feedbacks, I hope to put this proposal to the vote by next Monday, Jan 21. Thanks, Dongjin On Tue, Jan 15, 2019 at 3:17 AM Dongjin Lee wrote: > I just realized that there was a missing hole in the KIP, so I fix

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-20 Thread Dongjin Lee
es section, isn't it?) Thanks, Dongjin On Sun, Jan 20, 2019 at 2:33 AM Ismael Juma wrote: > Hi Dongjin, > > For topic level, you can only have a single compression type so the way it > was before was fine, right? The point you raise is how to set broker > defaults that vary

Re: [DISCUSS] KIP-400 - Improve exit status in case of errors in ConsoleProducer

2019-01-20 Thread Dongjin Lee
Thank you for the KIP. In my opinion, this feature must work well with shell scripts, by improving interoperability. Isn't it? Thanks, Dongjin On Fri, Jan 18, 2019, 6:30 AM kamal kaur Hi everyone, > > This is ready for discussion. > > *Jira* - https://issues.apache.org/jira/browse/KAFKA-6812 > >

[VOTE] KIP-390: Allow fine-grained configuration for compression

2019-01-20 Thread Dongjin Lee
://lists.apache.org/thread.html/967980193088e2c8cbb39a4782e358961fee828c6c50d880610a8353@%3Cdev.kafka.apache.org%3E Thanks, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.lin

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-20 Thread Dongjin Lee
th the > defaults. Perhaps we should only support the topic config for the cases > where you are actually recompressing in the broker. > > What do you think? I'd be interested in other people's thoughts too. > > Ismael > > On Sun, Jan 20, 2019 at 2:14 AM Dongjin Lee wr

Re: [VOTE] KIP-396: Add Commit/List Offsets Operations to AdminClient

2019-01-21 Thread Dongjin Lee
> > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fpages%2Fviewpage.action%3FpageId%3D97551484&data=02%7C01%7C%7C47c103e1919142c35d7c08d67f9e4c5d%7C84df9e7fe9f640afb435%7C1%7C0%7C636836715187389495&sdata=ihLaSXvB8C%2BK%2F%2BWjVDqKXgUJoR

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-21 Thread Dongjin Lee
need `compression.[gzip,lz4,zstd].level` and `compression.[gzip,snappy,lz4].buffer.size` anymore, I will revert those changes and update the KIP with the recent discussions. I will complete it in 48 hours from now. Thanks, Dongjin On Mon, Jan 21, 2019 at 4:18 PM Dongjin Lee wrote: > I see. Let

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression

2018-05-30 Thread Dongjin Lee
ormations, tests, additional dependencies, etc. > > > > Is it possible to produce more convincing comparisons? > > > > Thanks, > > Magnus > > > > > > > > > > > > 2017-01-31 10:28 GMT+01:00 Dongjin Lee : > > > > > Ismael &

[DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-06-09 Thread Dongjin Lee
includes some expected problems and their candidate alternatives. Please have a look when you are free, and give me a feedback. All kinds of participating are welcome. Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>gith

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-06-11 Thread Dongjin Lee
tor > > > On Sun, Jun 10, 2018 at 3:02 AM Ivan Babrou wrote: > > > Hello, > > > > This is Ivan and I still very much support the fact that zstd compression > > should be included out of the box. > > > > Please think about the environmen

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-06-12 Thread Dongjin Lee
nks for pointing out this problem, Viktor! Nice catch! Best, Dongjin On Mon, Jun 11, 2018 at 11:50 PM Dongjin Lee wrote: > I greatly appreciate your comprehensive reasoning. so: +1 for b until now. > > For the license issues, I will have a check on how the over projects are > doing and

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-06-13 Thread Dongjin Lee
st, Dongjin On Tue, Jun 12, 2018 at 6:50 PM Dongjin Lee wrote: > Here is the short conclusion about the license problem: *We can use zstd > and zstd-jni without any problem, but we need to include their license, > e.g., BSD license.* > > Both of BSD 2 Clause License & 3 Clau

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-06-13 Thread Dongjin Lee
0.0. This KIP > seems like a great candidate for 2.1.0 and hopefully there will be more of > a discussion next week. :) > > Ismael > > On Wed, 13 Jun 2018, 05:17 Dongjin Lee, wrote: > > > Hello. I just updated my draft implementation: > > > > 1. Rebased to lates

Re: [VOTE] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

2018-06-26 Thread Dongjin Lee
+1. (binding) On Tue, Jun 26, 2018, 2:34 AM Damian Guy wrote: > Thanks Bill! +1 > > On Mon, 25 Jun 2018 at 18:57 Ted Yu wrote: > > > +1 > > > > On Mon, Jun 25, 2018 at 9:45 AM, Guozhang Wang > wrote: > > > > > +1. > > > > > > On Mon, Jun 25, 2018 at 8:12 AM, Matthias J. Sax < > matth...@conflu

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-07-14 Thread Dongjin Lee
here any update on this. The performance improvements are quite > impressive and I really would like to stop forking kafka just to get this > in. > > Thanks, > > Bobby > > On Wed, Jun 13, 2018 at 8:56 PM Dongjin Lee wrote: > > > Ismael, > > > > Oh, I forgot

Re: [ANNOUNCE] Apache Kafka 1.1.1 Released

2018-07-20 Thread Dongjin Lee
ew York Times, Uber, Yelp, and Zalando, among others. > > > > > > A big thank you for the following 29 contributors to this release! > > > > > > Ismael Juma, Rajini Sivaram, Matthias J. Sax, Guozhang Wang, Anna > > Povzner, > > > tedyu, Jagadesh Adireddi,

Re: [ANNOUNCE] Apache Kafka 2.0.0 Released

2018-07-30 Thread Dongjin Lee
f Klukas, Jeremy Custenborder, > > > > Jiangjie (Becket) Qin, Jiangjie Qin, JieFang.He, Jimin Hsieh, Joan > Goyeau, > > > > Joel Hamill, John Roesler, Jon Lee, Jorge Quilcate Otoya, Jun Rao, > > > > Kamal C, khairy, Koen De Groote, Konstantine Karantasis,

Re: zstd support status

2018-02-10 Thread Dongjin Lee
even a PR: > > * https://issues.apache.org/jira/browse/KAFKA-4514 > * > https://cwiki.apache.org/confluence/display/KAFKA/KIP-110%3A+Add+Codec+for+ZStandard+Compression > * https://github.com/apache/kafka/pull/2267 > > What does it take to get it through the finish line? > -- *Dongjin

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-07 Thread Dongjin Lee
ting, commit 6b4fb8152. On Sat, Jul 14, 2018 at 10:45 PM Dongjin Lee wrote: > Sorry for the late reply. > > In short, I could not submit the updated KIP by the feature freeze > deadline of 2.0.0. For this reason, it will not be included in the 2.0.0 > release and all discussion fo

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-12 Thread Dongjin Lee
seems straightforward -- it's just a matter of adding > > the text to the right files as per ASF guidelines. > > > > With regard to the dictionary support, do we really need that in the > first > > version? Hopefully message batches are big enough that this isn't

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-17 Thread Dongjin Lee
e we have to down-convert the message format), or we have an easy > way to tell whether zstandard is in use (the topic has it configured > explicitly). In the latter case, we don't have to handle it specially. But > we do have to decide how we will handle down-conversion to older format

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-08-20 Thread Dongjin Lee
> am > > > happy to announce that Dong is now a member of the > > > Apache Kafka PMC. > > > > > > Congratulation Dong! Looking forward to your future contributions. > > > > > > Ismael, on behalf of the Apache Kafka PMC > > > > > -- &

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-21 Thread Dongjin Lee
sing no > compression > > > > type, or (2) to return an error code. I'm leaning toward the latter > as > > > the > > > > simpler solution, but the challenge is finding a good error code. Two > > > > possibilities might be INVALID_REQUEST or COR

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-22 Thread Dongjin Lee
-conversion and we encounter a zstd compressed message, or 2) if the > > topic is explicitly configured to use zstd. However, if the compression > > type is set to "producer," then the fetched data may or may not be > > compressed with zstd. In this case, we return the d

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-22 Thread Dongjin Lee
, Dongjin On Wed, Aug 22, 2018 at 5:43 PM Dongjin Lee wrote: > Jason, > > > I think we would only use this error code when we /know/ that zstd was > in use and the client doesn't support it? This is true if either 1) the > message needs down-conversion and we encounter a zstd c

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-22 Thread Dongjin Lee
implementations would > either pass through the raw type or convert to an enum using something like > what the java client does. Since we're expecting the client to fail anyway, > I'm probably in favor of using the UNSUPPORTED_COMPRESSION_TYPE error code. > > -Jason > >

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

2018-08-27 Thread Dongjin Lee
ced. > > > > For that we can make use of the implicit parameters in Scala. > > > > > > > > KIP: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-365%3A+Materialized%2C+Serialized%2C+Joined%2C+Consum

Re: [VOTE] KIP-359: Verify leader epoch in produce requests

2018-08-30 Thread Dongjin Lee
art the vote on KIP-359: https://cwiki.apache.org/ > > confluence/display/KAFKA/KIP-359%3A+Verify+leader+epoch+in+ > > produce+requests. > > Thanks in advance for reviewing. > > > > -Jason > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-08-31 Thread Dongjin Lee
logic only. Please have a look when you are free. Thanks, Dongjin [^1]: Please check the last commit here: https://github.com/apache/kafka/pull/2267 On Thu, Aug 23, 2018, 8:55 AM Dongjin Lee wrote: > Jason, > > Great. +1 for UNSUPPORTED_COMPRESSION_TYPE. > > Best, > Dongjin

Re: Provide clients Header implementation without accessing internal package

2018-09-05 Thread Dongjin Lee
der my folk suggested if we really want to hide the implementation > and let end users only refer Header interface. > > If that's only missing spot I'm happy to take it forward. (I might request > contributor role then.) If that's by intention please also let me know that > w

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-09-06 Thread Dongjin Lee
18 at 11:35 PM Dongjin Lee wrote: > I just updated the draft implementation[^1], rebasing against the latest > trunk and implementing error routine (i.e., Error code 74 for > UnsupportedCompressionTypeException.) Since we decided to disallow all > fetch request below version 2.1.0 fo

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-09-09 Thread Dongjin Lee
> > continue fetching past that offset. > > > > So, from the client's perspective it is not really a problem if new error > > codes are added to older API versions. > > > > /Magnus > > > > > > Den tors 6 sep. 2018 kl 09:45 skrev Dongjin Lee : > >

Re: [ANNOUNCE] Kafka Committers Guidelines

2018-09-10 Thread Dongjin Lee
candidates. > > * One of the goals of this guideline is to be transparent about what areas > Kafka PMC is looking for contributions. So for anyone anyone who are > interested in becoming a committer, please feel free to approach to any PMC > members to get feedbacks about areas of improvem

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-10 Thread Dongjin Lee
gt; > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496 > > > > -- > > Chia-Ping > > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://g

Re: [DISCUSS] KIP-110: Add Codec for ZStandard Compression (Updated)

2018-09-12 Thread Dongjin Lee
Hi Ismael, Sure. Thanks. - Dongjin On Wed, Sep 12, 2018 at 11:56 PM Ismael Juma wrote: > Dongjin, can you please start a vote? > > Ismael > > On Sun, Sep 9, 2018 at 11:15 PM Dongjin Lee wrote: > > > Hi Jason, > > > > You are right. Explicit stateme

[VOTE] KIP-110: Add Codec for ZStandard Compression

2018-09-12 Thread Dongjin Lee
-- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <http://kr.linkedin.com/in/dongjinleekr>slideshare: www.slideshare.net/dongjinleekr <http

Re: [DISCUSS] Apache Kafka 2.1.0 Release Plan

2018-09-13 Thread Dongjin Lee
jor features merged & working on stabilization, minor features have > PR, > >>> release branch cut; anything not in this state will be automatically > >> moved > >>> to the next release in JIRA. > >>> > >>> 3) Code Freeze: Oct 15, 2018 (Ten

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-09-15 Thread Dongjin Lee
> > > > > > >>>> wrote: > > > > > >>>> > > > > > >>>>> Congrats Dong! > > > > > >>>>>> > > > > > >>>>>> -James > > > > > >&

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Dongjin Lee
Repartition+Topics+for+Joins+and+Grouping > >> > >> I'll start with my own +1. > >> > >> Thanks, > >> Bill > >> > > > > > > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/do

Re: [VOTE] KIP-110: Add Codec for ZStandard Compression

2018-09-17 Thread Dongjin Lee
> > > Thanks for the KIP. > > > > > > > > On Wed, Sep 12, 2018 at 10:44 PM Ismael Juma > wrote: > > > > > > > > > Thanks for the KIP, +1 (binding). > > > > > > > &g

Re: [VOTE] KIP-110: Add Codec for ZStandard Compression

2018-09-17 Thread Dongjin Lee
. On Tue, Sep 18, 2018 at 9:42 AM Dong Lin wrote: > Hey Dongjin, > > The KIP passes vote after having 3 binding +1 votes and more binding +1 > votes than -1 votes. So it is not necessary to have more vote for this KIP. > > Thanks, > Dong > > On Mon, Sep 17, 2018 at

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-25 Thread Dongjin Lee
Clients Compatibility Policy), > >> KIP-117 > >> > > > (AdminClient), KIP-227 (Incremental FetchRequests to Increase > >> Partition > >> > > > Scalability), the introduction of findBugs and adding Trogdor > (fault > >> >

Re: [DISCUSS] Make org.apache.kafka.clients.Metadata#TOPIC_EXPIRY_MS configurable

2018-09-26 Thread Dongjin Lee
s to make TOPIC_EXPIRY_MS configurable. > > -- > Pavel > +7-903-258-5544 > skype://pavel.moukhataev > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.

Re: [DISCUSS] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-09-26 Thread Dongjin Lee
> experience. > > > > More details added in this KIP page(including code changes): > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-374%3A+Add+%27--help%27+option+to+all+available+Kafka+CLI+commands > > > > I look forward to feedback and comments. >

Re: [DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

2018-09-27 Thread Dongjin Lee
l, > > > > Here is a trivial KIP: > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=93325308 > > > > Suggestions are welcome. > > > > Thanks, > > Yishun > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-27 Thread Dongjin Lee
and such)? If the former, it seems unrelated. > >> > > > > > >> > > > > On Mon, Sep 24, 2018 at 7:25 AM Viktor Somogyi-Vass < > >> > > > > viktorsomo...@gmail.com> > >> > > > > wrote: > >> > >

Re: [VOTE] KIP-349 Priorities for Source Topics

2018-09-30 Thread Dongjin Lee
; > https://cwiki.apache.org/confluence/display/KAFKA/KIP-349%3A+Priorities+for+Source+Topics > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-349:+Priorities+for+Source+Topics > > > > This is the original proposal, sans MessageChooser. > > Cheers, > -- &g

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

2018-09-30 Thread Dongjin Lee
would be highly appreciated. > > Best Regards, > Wladimir Schmidt > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <http

Re: [VOTE] KIP-349 Priorities for Source Topics

2018-10-01 Thread Dongjin Lee
tthias > > On 9/30/18 11:11 AM, n...@afshartous.com wrote: > > > >> On Sep 30, 2018, at 5:16 AM, Dongjin Lee wrote: > >> > >> 1. Your KIP document > >> < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-349%3A+Priorities+for+Source+Topics

Re: Question about fromLogical method in connect/api/src/main/java/org/apache/kafka/connect/data/Date.java

2017-10-30 Thread Dongjin Lee
getInstance(TimeZone.getDefault()); > long reviseMillis = calendar.get(Calendar.ZONE_OFFSET) + > calendar.get(Calendar.DST_OFFSET) / 60; > //revising with reviseMillis >return new java.util.Date(value * MILLIS_PER_DAY - reviseMillis); > } > ``` > > But I wond

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-22 Thread Dongjin Lee
AM Ismael Juma wrote: > Thanks! > > Ismael > > On Mon, Jan 21, 2019 at 6:02 AM Dongjin Lee wrote: > > > Hi Ismael, > > > > After reviewing > `LogValidator#validateMessagesAndAssignOffsetsCompressed`, > > yes, you are right. If source codec and target co

Re: [VOTE] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-23 Thread Dongjin Lee
to enhance the AbstractConfig > base class to support replacing variables in configurations just prior to > parsing and validation. > > > > Link for the KIP: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-421%3A+Support+resolving+externalized+secr

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-24 Thread Dongjin Lee
icular compression type. > 2. Even for the same config, different compression type may have different > terminologies. With the approach we can honor those terminologies instead > of shoehorning them into the same configuration name. > > What do you think? > > Thanks, > > Jiangji

Re: [DISCUSS] KIP-400 - Improve exit status in case of errors in ConsoleProducer

2019-01-26 Thread Dongjin Lee
ate which shell scripts interoperability you are > talking about? > > thanks > > Kamal > > On Sun, Jan 20, 2019 at 9:00 AM Dongjin Lee wrote: > > > Thank you for the KIP. In my opinion, this feature must work well with > > shell scripts, by improving interopera

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-29 Thread Dongjin Lee
cantly simplify the configuration with flexibility and extensibility. If you prefer this way, I hope to carry the ball. If not, please give me an opinion here or the voting thread. Thanks, Dongjin On Fri, Jan 25, 2019 at 1:25 AM Dongjin Lee wrote: > Hi Becket, > > Thank you for your

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-01-31 Thread Dongjin Lee
described in the "Updating SSL Keystore of an Existing Listener" in > the Kafka docs)? > > Also worth noting that we already have configs that effectively take a > map, for example: listener.security.protocol.map so not sure if we > need an additional KIP > > On Wed, Jan 30,

Re: [DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for Producing to Secured Brokers

2019-02-04 Thread Dongjin Lee
s: Is there anyone who worked on the log module or security feature? Best, Dongjin On Sun, Feb 3, 2019 at 2:24 PM Rohan Desai wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers > -- *Do

Re: [VOTE] KIP-425: Add some Log4J Kafka Appender Properties for Producing to Secured Brokers

2019-02-05 Thread Dongjin Lee
er+Properties+for+Producing+to+Secured+Brokers > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <https://kr.linkedin.com/in/dongjinleekr&g

Re: [DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for Producing to Secured Brokers

2019-02-05 Thread Dongjin Lee
just bring the Log4J appender up to the > same configuration we already have elsewhere. So, I support this KIP. > Thanks, Rohan :) > > On Mon, Feb 4, 2019 at 1:54 AM Dongjin Lee wrote: > > > > Hi Rohan, > > > > Thank you for your proposal. Since the release of 2.2.0 i

Re: [DISCUSS] KIP-390: Add producer option to adjust compression level

2019-02-07 Thread Dongjin Lee
s, > > Jiangjie (Becket) Qin > > On Thu, Jan 31, 2019 at 7:47 PM Dongjin Lee wrote: > > > Mickael, > > > > It seems like the majority of the community agrees that the new config > > scheme proposed by Becket is much better. How

Re: [VOTE] KIP-425: Add some Log4J Kafka Appender Properties for Producing to Secured Brokers

2019-02-07 Thread Dongjin Lee
gt; > > > Calling a vote for this since it's pretty trivial/non-controversial > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers > >

Re: [VOTE] KIP-425: Add some Log4J Kafka Appender Properties for Producing to Secured Brokers

2019-02-08 Thread Dongjin Lee
nks! > > Guozhang > > On Thu, Feb 7, 2019 at 7:30 AM Dongjin Lee wrote: > > > binding +1: Gwen, Manikumar > > non-binding +1: Dongjin, Bill > > > > We need one more binding +1. > > > > On Wed, Feb 6, 2019 at 3:41 AM Bill Bejeck wrote: > >

Re: [DISCUSS] KIP-428: Add in-memory window store

2019-02-08 Thread Dongjin Lee
a RocksDB window store, but users > have been requesting an in-memory version. This KIP introduces a design for > an in-memory window store implementation. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-428%3A+Add+in-memory+window+store > -- *Dongjin Lee* *A hi

Re: [ANNOUNCE] New Committer: Bill Bejeck

2019-02-14 Thread Dongjin Lee
ear, including a presentation at Kafka Summit SF. He's also > > authored > > > a book about Kafka Streams ( > > > https://www.manning.com/books/kafka-streams-in-action), as well as > > various > > > of posts in public venues like DZone as well as his per

Re: [ANNOUNCE] New Committer: Randall Hauch

2019-02-15 Thread Dongjin Lee
Congratulations, Randall! You deserve it! Best, Dongjin On Fri, Feb 15, 2019, 6:35 PM Viktor Somogyi-Vass Congrats Randall! :) > > On Fri, Feb 15, 2019 at 10:15 AM Satish Duggana > wrote: > > > Congratulations Randall! > > > > On Fri, Feb 15, 2019 at 1:51 PM Mickael Maison > > > wrote: > > > >

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-19 Thread Dongjin Lee
to data protection laws. For more information about how we > use and disclose your personal data, how we protect your information, our > legal basis to use your information, your rights and who you can contact, > please refer to: www.gs.com/privacy-notices< > http://www.gs.c

Re: [DISCUSS] KIP-436 Add a metric indicating start time

2019-03-03 Thread Dongjin Lee
+indicating+start+time > >> > > > >> > JIRA: KAFKA-7992 <https://issues.apache.org/jira/browse/KAFKA-7992> > >> > Pull Request: 6318 <https://github.com/apache/kafka/pull/6318> > >> > > >> > I look forward to seeing people

Re: [VOTE] KIP-427: Add AtMinIsr topic partition category (new metric & TopicCommand option)

2019-03-06 Thread Dongjin Lee
+1 (non-binding) On Wed, Mar 6, 2019, 3:14 AM Dong Lin wrote: > Hey Kevin, > > Thanks for the KIP! > > +1 (binding) > > Thanks, > Dong > > On Tue, Mar 5, 2019 at 9:38 AM Kevin Lu wrote: > > > Hi All, > > > > I would like to start the vote thread for KIP-427: Add AtMinIsr topic > > partition cat

Re: [VOTE] KIP-436 Add a metric indicating start time

2019-03-08 Thread Dongjin Lee
lt; > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-436%3A+Add+a+metric+indicating+start+time > > > > > > > > > > JIRA: KAFKA-7992 <https://issues.apache.org/jira/browse/KAFKA-7992 > > > > > > > Pull Request

Re: [VOTE] KIP-427: Add AtMinIsr topic partition category (new metric & TopicCommand option)

2019-03-08 Thread Dongjin Lee
7, 2019 at 4:49 AM Vahid Hashemian < > vahid.hashem...@gmail.com> > > > wrote: > > > > > >> Thanks for the KIP Kevin. > > >> > > >> +1 (binding) > > >> > > >> --Vahid > > >> > > >> On Wed, Mar

Re: [VOTE] KIP-436 Add a metric indicating start time

2019-03-08 Thread Dongjin Lee
With 3 binding with 3 non-binding +1, this proposal is now passed. On Sat, 9 Mar 2019 at 2:37 AM Harsha wrote: > +1 (binding) > > Thanks, > Harsha > > On Fri, Mar 8, 2019, at 2:55 AM, Dongjin Lee wrote: > > +1 (non binding) > > > > 2 bindings, 3 non-b

Re: [ANNOUNCE] Apache Kafka 2.2.0

2019-03-26 Thread Dongjin Lee
na, Radai Rosenblatt, Rajini > > Sivaram, Randall Hauch, Renato Mefi, Richard Yu, Robert Yokota, Ron > > Dagostino, ryannatesmith, Samuel Hawker, Satish Duggana, Sayat, seayoun, > > Shawn Nguyen, slim, Srinivas Reddy, Stanislav Kozlovski, Stig Rohde > > Døssing, Suman, Tom

Re: [VOTE] KIP-421: Automatically resolve external configurations.

2019-04-22 Thread Dongjin Lee
t; > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=100829515 > > > DiscussionThread: > > > > https://lists.apache.org/thread.html/a2f834d876e9f8fb3977db794bf161818c97f7f481edd1b10449d89f@%3Cdev.kafka.apache.org%3E > > > > > > Thanks, > > > Tejal > > >

[DISCUSS] KIP-459: Improve KafkaStreams#close

2019-04-23 Thread Dongjin Lee
.org/jira/browse/KAFKA-7996>. In short, this KIP proposes to resolve this problem by improving existing API's semantics, not adding any public API changes. Please have a look when you are free. All opinions will be highly appreciated. Thanks, Dongjin -- *Dongjin Lee* *A hitchhiker in the m

Re: [VOTE] KIP-421: Automatically resolve external configurations.

2019-04-23 Thread Dongjin Lee
It looks > like he isn't on the committers page yet, though. > > Randall, can you add your name to https://kafka.apache.org/committers.html > to help prevent confusion in the future? > > best, > Colin > > > On Mon, Apr 22, 2019, at 16:44, Dongjin Lee wro

Re: [VOTE] KIP-417: Allow JmxTool to connect to a secured RMI port

2019-04-25 Thread Dongjin Lee
> > > I would like to start a vote on KIP-417 which aims at supporting > > JmxTool > > > > to connect to a secured RMI port. > > > > > > > > > > > > The KIP: > > > > > > > > > > > https://cwiki.apache.

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

2019-05-19 Thread Dongjin Lee
? For > example, with EOS enabled, there are multiple Producers that need to be > closed, however, the user might not even be aware of the increased > number of producers (or not know how many there actually are). > > > It seems to be hard for users to reason about those depende

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

2019-05-19 Thread Dongjin Lee
lists.apache.org%2Fthread.html%2F1fc1e3d2cddd8311d3db7c98f0d09a1a137ca4b20d1f3c8ab203a855%40%253Cdev.kafka.apache.org%253E&data=02%7C01%7C%7C82864a9a5f3049e8ca1d08d6d48e5147%7C84df9e7fe9f640afb435aaaa%7C1%7C0%7C636930105039335723&sdata=B2a4Mx9ScWaO3HEEw0LoIRX0ajETAcwUmDxt5Ir5FIs%3D&

Re: [DISCUSS] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-05-21 Thread Dongjin Lee
s, which options could/should they set in > > > > > RocksDBConfigSetter should they discover a particular bottleneck? > > > > > > > > > > I don't think this necessarily needs to go into the KIP, but I do > > > think it > > > > &g

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-27 Thread Dongjin Lee
propose to deprecate the WindowStore#put(key, value), as it does not > have a timestamp as a parameter. The window store requires a timestamp to > map the key to a window frame. This method uses the current record > timestamp(as specified in the description of the method). There is a

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-27 Thread Dongjin Lee
//cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 > > Thanks & Regards > Omkar Mestry > > On Mon, May 27, 2019 at 6:25 PM Dongjin Lee wrote: > > > Hi Omkar, > > > > Thanks for the KIP. However, discussion thread should include a link to >

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

2019-05-29 Thread Dongjin Lee
d. > > I think it would be good to get feedback from people who work on > clients, too. > > > -Matthias > > > On 5/19/19 12:58 PM, Dongjin Lee wrote: > > Hi Matthias, > > > > I investigated the inconsistencies between `close` semantics of > `Producer`,

Re: [VOTE] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-31 Thread Dongjin Lee
pache.org/confluence/pages/viewpage.action?pageId=115526545 > > Thanks & Regards > Omkar Mestry > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https://github.com/dongjinleekr>linkedin: kr.linkedin

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

2019-06-18 Thread Dongjin Lee
t 12:26 PM Dongjin Lee wrote: > I just updated the KIP document reflecting what I found about the clients > API inconsistency and Matthias's comments. Since it is now obvious that > modifying the default close timeout for the client is not feasible, the > updated document

[DISCUSS] KIP-390: Allow fine-grained configuration for compression (Rebooted)

2019-06-24 Thread Dongjin Lee
s of feedbacks are welcomed! Regards, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <https://kr.linkedin.com/in/dongjinleekr>speake

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

2019-07-09 Thread Dongjin Lee
Hi Matthias, Have you thought about this issue? Thanks, Dongjin On Wed, Jun 19, 2019 at 5:07 AM Dongjin Lee wrote: > Hello. > > I just uploaded the draft implementation of the three proposed > alternatives. > > - Type A: define a close timeout constant - > https://gi

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-02 Thread Dongjin Lee
Mitch > > > > -- > Gwen Shapira > Product Manager | Confluent > 650.450.2760 | @gwenshap > Follow us: Twitter | blog > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <https://github.com/

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-09 Thread Dongjin Lee
to do this on > a > > case by case basis to avoid a lot of bikeshedding. The name > > `--bootstrap-sever` is the one the project has generally settled on. It > is > > consistent with the `bootstrap.server` configuration which is used by all > > the clients. > > &

Re: [VOTE] KIP-499 - Unify connection name flag for command line tool

2019-08-09 Thread Dongjin Lee
> > The following command line tools will have the > > > `--bootstrap-server` > > > > > > command line argument added: kafka-console-producer.sh, > > > > > > kafka-consumer-groups.sh, kafka-consumer-perf-test.sh, > > > > > >

Re: [DISCUSS] KIP-505 : Add new public method to only update assignment metadata in consumer

2019-08-13 Thread Dongjin Lee
d get corresponding calls to you > >> >> rebalance > >> >> > > >>>>> listener to learn about it and react accordingly. > >> >> > > >>>>> > >> >> > > >>>>> Maybe you can ex

  1   2   3   4   >