No problem. Thanks! - Dongjin
On Thu, Sep 27, 2018 at 7:28 PM Viktor Somogyi-Vass <viktorsomo...@gmail.com> wrote: > Hi All, > > A technical update: around the time I created this KIP, another one got > created with the same number and therefore to avoid collisions in KIP > numbers I chose to increment my KIP's number, so the new URL where it is > available is: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient > > I will also start a new discussion thread (and link this one), so please > post comments there. Apologies for any confusion. > > Cheers, > Viktor > > On Wed, Sep 26, 2018 at 12:26 PM Viktor Somogyi-Vass < > viktorsomo...@gmail.com> wrote: > > > Hi Manikumar, > > > > Thanks for raising this to my attention. I must have missed this in the > > AdminClient, so you're right, we don't need this new protocol at all. > I've > > moved it to the rejected alternatives section. > > > > Thanks, > > Viktor > > > > On Wed, Sep 26, 2018 at 8:24 AM Manikumar <manikumar.re...@gmail.com> > > wrote: > > > >> Hi Viktor, > >> > >> We already have API (AdminClient.createPartitions, > >> CreatePartitionsRequest/Response ) to increase the number of partitions > of > >> the topics. > >> So, we may not need the protocol changes proposed in the KIP. Let me > >> know, > >> If I am missing anything. > >> > >> Thanks, > >> > >> > >> On Tue, Sep 25, 2018 at 2:45 PM Viktor Somogyi-Vass < > >> viktorsomo...@gmail.com> > >> wrote: > >> > >> > Hi Eno, > >> > > >> > Thanks for the question. Basically KAFKA-5561 aims for a bigger task: > >> not > >> > to add functionality to the existing TopicCommand but rewrite it in > the > >> > tools module in Java. KIP-375 only aims for extending the existing > >> > TopicCommand's capability, so it is a smaller and backward compatible > >> step > >> > in the direction of having the tools communicating via the Kafka > >> protocol. > >> > Other commands, such as ConfigCommand (partly), ConsumerGroupCommand, > >> > LogDirsCommand, DelegationTokenCommand also moved this direction, so I > >> > think it makes sense to do it for TopicCommand as well. > >> > > >> > Cheers, > >> > Viktor > >> > > >> > On Tue, Sep 25, 2018 at 10:48 AM Eno Thereska <eno.there...@gmail.com > > > >> > wrote: > >> > > >> > > This would be very useful. > >> > > Could you clarify a bit the difference to > >> > > https://issues.apache.org/jira/browse/KAFKA-5561 since I didn't get > >> it > >> > > from > >> > > the JIRA notes. It's fine if you pick up that work but wanted to > make > >> > sure > >> > > we're not duplicating efforts. > >> > > > >> > > Thanks > >> > > Eno > >> > > > >> > > On Mon, Sep 24, 2018 at 8:26 PM, Viktor Somogyi-Vass < > >> > > viktorsomo...@gmail.com> wrote: > >> > > > >> > > > Hi Gwen, > >> > > > > >> > > > Thanks for your feedback. It is the latter, so passing extra > >> connection > >> > > > properties for the admin client. I'll try to make that clearer in > >> the > >> > > KIP. > >> > > > The same option name is used in the ConfigCommand, so that's why I > >> > named > >> > > it > >> > > > "command-config". > >> > > > > >> > > > Cheers, > >> > > > Viktor > >> > > > > >> > > > > >> > > > On Mon, Sep 24, 2018 at 8:18 PM Gwen Shapira <g...@confluent.io> > >> > wrote: > >> > > > > >> > > > > The "use admin client" part is amazing and thank you. > >> > > > > > >> > > > > I'm confused about "commandConfig" - is this a list of > >> configurations > >> > > for > >> > > > > use with --config option? Or a list of properties for connecting > >> to > >> > > > brokers > >> > > > > (like SSL and such)? If the former, it seems unrelated. > >> > > > > > >> > > > > On Mon, Sep 24, 2018 at 7:25 AM Viktor Somogyi-Vass < > >> > > > > viktorsomo...@gmail.com> > >> > > > > wrote: > >> > > > > > >> > > > > > Hi All, > >> > > > > > > >> > > > > > I wrote up a relatively simple KIP about improving the Kafka > >> > protocol > >> > > > and > >> > > > > > the TopicCommand tool to support the new Java based > AdminClient > >> and > >> > > > > > hopefully to deprecate the Zookeeper side of it. > >> > > > > > > >> > > > > > I would be happy to receive some opinions about this. In > >> general I > >> > > > think > >> > > > > > this would be an important addition as this is one of the few > >> left > >> > > but > >> > > > > > important tools that still uses direct Zookeeper connection. > >> > > > > > > >> > > > > > Here is the link for the KIP: > >> > > > > > > >> > > > > > > >> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >> > > > 375%3A+TopicCommand+to+use+AdminClient > >> > > > > > > >> > > > > > Thanks, > >> > > > > > Viktor > >> > > > > > > >> > > > > > >> > > > > > >> > > > > -- > >> > > > > *Gwen Shapira* > >> > > > > Product Manager | Confluent > >> > > > > 650.450.2760 | @gwenshap > >> > > > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog > >> > > > > <http://www.confluent.io/blog> > >> > > > > > >> > > > > >> > > > >> > > >> > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <http://kr.linkedin.com/in/dongjinleekr>slideshare: www.slideshare.net/dongjinleekr <http://www.slideshare.net/dongjinleekr>*
