Hi Rohan,

Thank you for your proposal. Since the release of 2.2.0 is imminent, most
committers are on working frenzy now so don't be distressed if there are
few responses for the discussion thread.

Although I am not a committer, here are some notes I would like to share
about submitting a KIP:

1. After searching the mailing list archive, I found that you did not ask
whether this feature is needed or there is another way to achieve the goal
you want. (If not, forgive me.) It is always good to make some prior
discussion about some feature before submitting a KIP. [example
<https://lists.apache.org/thread.html/6cc42d8f994bb1f37a5cad3278369a1800f614ad3d0789ed7a9cab7f@%3Cdev.spark.apache.org%3E>
]

2. After opening a discussion thread like this
<https://lists.apache.org/thread.html/967980193088e2c8cbb39a4782e358961fee828c6c50d880610a8353@%3Cdev.kafka.apache.org%3E>,
please update the KIP with the permalink to the email message. You can find
it in here <https://lists.apache.org/list.html?dev@kafka.apache.org>.

3. It seems like it is much better to provide some detailed reasons or
scenarios where the proposed changes are needed or useful in the Motivation
section.

Here are some examples:

https://cwiki.apache.org/confluence/display/KAFKA/KIP-110%3A+Add+Codec+for+ZStandard+Compression
https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression

So, I made some minor revisions to your Proposal.

@Committers:

Is there anyone who worked on the log module or security feature?

Best,
Dongjin


On Sun, Feb 3, 2019 at 2:24 PM Rohan Desai <desai.p.ro...@gmail.com> wrote:

>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers
>


-- 
*Dongjin Lee*

*A hitchhiker in the mathematical world.*
*github:  <http://goog_969573159/>github.com/dongjinleekr
<https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
<https://speakerdeck.com/dongjin>*

Reply via email to