Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-03 Thread Colin McCabe
On Tue, May 3, 2022, at 19:32, Luke Chen wrote: > Hi Colin, > > So exciting to see the KIP to mark the Kraft production ready! > > Just one comment: We should make sure the period between ZK deprecation > (i.e. v3.4.0) to ZK removal (i.e. v4.0.0) is not too short. > Do we hav

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-03 Thread Colin McCabe
On Tue, May 3, 2022, at 23:16, Colin McCabe wrote: > > To be clear, the proposal here is to have the bridge release be 3.4 and > then move on to a ZK-free 4.0. With a 3.5 release as an option (but not > requirement) if we can't finish everything in time after 3.4. So that &g

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-05 Thread Colin McCabe
culative except for the three proposed changes at the top: 1. Mark KRaft as production-ready for new clusters in the upcoming Kafka 3.3 release. 2. Deprecate ZooKeeper mode in the upcoming Kafka 3.4 release 3. Plan to remove ZooKeeper mode entirely in Kafka 4.0. best, Colin On Wed, May 4,

Re: [DISCUSS] KIP-835: Monitor KRaft Controller Quorum Health

2022-05-11 Thread Colin McCabe
tched and not applied, so we can see if the delta between that and last-applied-offset increases...) regards, Colin On Wed, May 11, 2022, at 12:27, David Arthur wrote: > José, thanks for the KIP! I think this is a good approach for proving > the liveness of the quorum when metadata is not chan

Re: [DISCUSS] KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-05-11 Thread Colin McCabe
he latest fetch. If we take both timestamps directly from the metadata log, we know they'll be comparable even in the presence of clock skew. And we know because of KIP-835 that the metadata log won't go quiet for prolonged periods. best, Colin On Tue, May 10, 2022, at 13:30, Niket Goel

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-05-11 Thread Colin McCabe
in doesn't know what this proxy is doing, and doesn't lock it down...) best, Colin On Mon, May 9, 2022, at 13:21, Omnia Ibrahim wrote: > Hi, I gave the KIP another look after talking to some people at the Kafka > Summit in London. And I would like to clear up the motiva

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-11 Thread Colin McCabe
Hi Andrew, Stretch clusters are possible with the KRaft architecture. For example, if you had a cluster with nodes in us-west-1, us-west-2 and us-central-1, you could put a KRaft controller node in each region. This is similar to how with ZK you'd put a ZK node in each region. best,

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-11 Thread Colin McCabe
On Thu, May 5, 2022, at 15:57, Israel Ekpo wrote: > Thanks Colin. > > I think we may need to update the KIP name to reflect the intent of the KIP > and convey everything it’s about if all the 3 action items will be covered > by the same KIP > > It contains three parts:

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-05-13 Thread Colin McCabe
On Wed, May 11, 2022, at 15:07, Omnia Ibrahim wrote: > Hi Colin, > I don't mind the idea of MM2 users implementing the AdminClient interface. > However, there're two disadvantages to this. > >1. Having around 70 methods definitions to have "NotImplemented"

Re: [DISCUSS] KIP-832 Allow creating a producer/consumer using a producer/consumer config

2022-05-13 Thread Colin McCabe
I agree. I would really like to see a builder interface here. If you changed the KIP to add this, you'd have to do the vote again, but I think it would be well worth it. best, Colin On Thu, May 12, 2022, at 00:13, Bruno Cadonna wrote: > Hi Francois, > > Modifying this KIP or

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-05-16 Thread Colin McCabe
On Mon, May 16, 2022, at 10:24, Omnia Ibrahim wrote: > Hi Colin, > > Thanks for your reply. > > This KIP doesn’t aim to solve any security concerns, but rather a conflict > of responsibilities within any Kafka ecosystem that includes MM2 and any > resource management soluti

[VOTE] KIP-833: Mark KRaft as Production Ready

2022-05-17 Thread Colin McCabe
Hi, I'd like to start the vote on KIP-833: Mark KRaft as Production Ready. https://cwiki.apache.org/confluence/x/8xKhD thanks, Colin

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-22 Thread Colin McCabe
Hi Artem, In ZK mode, the concept of fenced replicas does not exist -- brokers are either in the cluster or out, and if they're out, we scrub all information about them from the metadata. (With the exception of replica sets they are in.) best, Colin On Fri, May 20, 2022, at 10:17,

Re: [DISCUSS] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-22 Thread Colin McCabe
Hi David, Thanks for the KIP. LGTM! best, Colin On Wed, May 18, 2022, at 08:55, David Jacot wrote: > Hi, > > I created a small KIP to strengthen the AlterPartition API in KRaft mode: > https://cwiki.apache.org/confluence/x/phmhD > > Let me know what you think. > > Best, > David

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-05-23 Thread Colin McCabe
Hi José, Yes, that matches my understanding. I added a section on "bridge releases" to the KIP. This section basically reiterates what we discussed in KIP-500, but it's good to have anyway. best, Colin On Wed, May 18, 2022, at 14:49, José Armando García Sancio wrote: > Hi

Re: [VOTE] KIP-833: Mark KRaft as Production Ready

2022-05-25 Thread Colin McCabe
Thanks, everyone! With binding +1 votes from: Jason Gustafson David Jacot John Roesler José Armando García Sancio Bill Bejeck and non-binding +1 votes from: Israel Ekpo Luke Chen the vote passes. thanks, all. Colin On Tue, May 24, 2022, at 08:43, Bill Bejeck wrote: > Hi Colin, > > T

Re: [VOTE] KIP-833: Mark KRaft as Production Ready

2022-05-25 Thread Colin McCabe
In the list below, I accidentally included Luke Chen in the non-binding section. Actually, his vote belongs in the binding section. Sorry about that. best, Colin On Wed, May 25, 2022, at 11:42, Colin McCabe wrote: > Thanks, everyone! > > With binding +1 votes from: > Jason Gusta

Re: [VOTE] KIP-833: Mark KRaft as Production Ready

2022-05-25 Thread Colin McCabe
Hi Ismael, Thanks for reviewing this. I removed the one-sentence comment in the KIP about "GA". I agree it's unrelated to the rest of the stuff discussed here, and potentially distracting. best, Colin On Wed, May 25, 2022, at 12:21, Ismael Juma wrote: > I'm +1 on

Re: [VOTE] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-31 Thread Colin McCabe
added a new field. You will also need to assign yourself a new IBP / MetadataVersion. (For BrokerRegistrationChangeRecord it would be possible to avoid the version bump, since we're using tagged fields, but it's better to have it for consistency, I think.) best, Colin On Tue, May 3

Re: [VOTE] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-05-31 Thread Colin McCabe
> We should add a comment in AlterPartitionResponse about the new error > code INELIGIBLE_REPLICA. This is very important for error codes so we > can track which ones are returned in which RPC version. I also wonder Here I'm referring to AlterPartitionResponse.json cheers, Colin

Re: [VOTE] KIP-841: Fenced replicas should not be allowed to join the ISR in KRaft

2022-06-01 Thread Colin McCabe
Thanks, David. With these changes, I am +1 (binding) Great to see this KIP moving forward! Colin On Wed, Jun 1, 2022, at 02:04, David Jacot wrote: > Hi Colin, > > Thanks for your feedback! Please find my answers below. > >> However, I wonder if this will be feasible for ZK-b

Re: [VOTE] KIP-746: Revise KRaft Metadata Records

2022-06-01 Thread Colin McCabe
Hi all, I updated this with the changes to FeatureLevelRecord that we did in KIP-778. Since the original version was never implemented, it would have been confusing to leave it there, I think. best, Colin On Wed, Jul 21, 2021, at 17:41, Colin McCabe wrote: > Hi all, > > I made an ad

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-06-19 Thread Colin McCabe
ne In JQL terms, that's "project = KAFKA AND labels = kip-500 AND statusCategory != Done" The dynamic configuration piece is a bit tricky. You might consider starting with something like KAFKA-13650, KAFKA-13774, or KAFKA-13620. best, Colin On Sat, Jun 18, 2022, at 23:21, Christo

Re: [VOTE] KIP-840: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer

2022-07-06 Thread Colin McCabe
+1 (binding). thanks, Alexandre. On Mon, Jun 27, 2022, at 05:15, Alexandre Garnier wrote: > Hello! > > A little ping on this vote. > > Thanks. > > Le jeu. 16 juin 2022 à 16:36, Alexandre Garnier a écrit : > >> Hi everyone. >> >> Anyone wants to give a last binding vote for this KIP? >> >> Thanks

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread Colin McCabe
add? The adding behavior is spelled out, but not removing (or maybe I missed it). best, Colin On Thu, Jul 21, 2022, at 09:49, José Armando García Sancio wrote: > Hi all, > > I would like to start the discussion on my design to support > dynamically changing the set of voters in t

Re: [ANNOUNCE] New Kafka PMC Member: A. Sophie Blee-Goldman

2022-08-02 Thread Colin McCabe
Congratulations! best, Colin On Tue, Aug 2, 2022, at 12:09, Matthew Benedict de Detrich wrote: > Congratulations Sophie! > > -- > Matthew de Detrich > Aiven Deutschland GmbH > Immanuelkirchstraße 26, 10405 Berlin > Amtsgericht Charlottenburg, HRB 209739 B > > Geschä

Re: [VOTE] KIP-859: Add Metadata Log Processing Error Related Metrics

2022-08-02 Thread Colin McCabe
ead of one fewer JVM process). best, Colin On Mon, Aug 1, 2022, at 18:05, David Arthur wrote: > Thanks, Niket. > > +1 binding from me > > -David > > On Mon, Aug 1, 2022 at 8:15 PM Niket Goel wrote: >> >> Hi all, >> >> I would like to start a vote on KI

Re: [VOTE] KIP-859: Add Metadata Log Processing Error Related Metrics

2022-08-03 Thread Colin McCabe
have a general controller metadata error metric. How do you feel about: ForceRenounceCount => kafka.controller:type=KafkaController,name=MetadataErrorCount publisher-error-count => metadata-load-error-count listener-batch-load-error-count => metadata-apply-error-count best, Colin On Tu

ARM/PowerPC builds

2022-08-03 Thread Colin McCabe
eds on x86 but breaks on PowerPC or ARM. This would let us have very long timeouts on our ARM and PowerPC builds (they could take all night if necessary), hence avoiding this issue. best, Colin

Re: [VOTE] KIP-859: Add Metadata Log Processing Error Related Metrics

2022-08-03 Thread Colin McCabe
Thanks, Niket. +1 (binding) Colin On Wed, Aug 3, 2022, at 15:24, Niket Goel wrote: > Thanks for the explanation Colin. > >> ForceRenounceCount => >> kafka.controller:type=KafkaController,name=MetadataErrorCount >> publisher-error-count => metadata-load-error-coun

Re: ARM/PowerPC builds

2022-08-04 Thread Colin McCabe
Hi Matthew, Can you open a JIRA for the test failures you have seen on M1? By the way, I have an M1 myself. best, Colin On Thu, Aug 4, 2022, at 04:12, Matthew Benedict de Detrich wrote: > Quite happy to have this change gone through since the ARM builds were > constantly failing how

Re: [DISCISS] KIP-860: Add client-provided option to guard against unintentional replication factor change during partition reassignments

2022-08-05 Thread Colin McCabe
or" to make it clear that it's best-effort. It's sort of debatable which way is better. In principle the UVE sounds nicer, but in practice maybe the other behavior is best? I suspect most systems would turn around and retry without the flag in the event of a UVE... best, Colin

Re: [VOTE] KIP-900: KRaft kafka-storage.sh API additions to support SCRAM for Kafka Brokers

2023-02-21 Thread Colin McCabe
Thanks, Proven. +1 (binding) best, Colin On Thu, Feb 16, 2023, at 07:23, Proven Provenzano wrote: > Hi, > > I'd like to start the vote on KIP-900: KRaft kafka-storage.sh API additions > to support SCRAM for Kafka Brokers. > > The KIP is here: KIP-900 > <https:

Re: [ANNOUNCE] New committer: Lucas Bradstreet

2023-02-21 Thread Colin McCabe
Congratulations, Lucas! best, Colin On Thu, Feb 16, 2023, at 13:54, Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer Lucas > Bradstreet. > > Lucas has been a long time Kafka contributor since Oct. 2018. He has been > e

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-09 Thread Colin McCabe
the JIRA right now). Sorry, but for now I have to vote -1 until I can understand this better best, Colin On Thu, Feb 23, 2023, at 06:48, Divij Vaidya wrote: > Thanks for the KIP Christo. > > Having Zk 3.6 reach EOL in Dec 2022 is a good enough reason to upgrade, > hence I completely

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-09 Thread Colin McCabe
On Wed, Mar 15, 2023, at 04:58, Christo Lolov wrote: > Hello Colin, > > Thank you for taking the time to review the proposal! > > I have attached a compatibility matrix to aid the explanation below - if the > mailing system rejects it I will find another way to share it.

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-14 Thread Colin McCabe
On Sun, Apr 9, 2023, at 19:17, Ismael Juma wrote: > > On Sun, Apr 9, 2023 at 4:53 PM Colin McCabe wrote: > >> We are going to deprecate ZK mode soon. So if this is indeed a requirement >> (no deprecated software in prod), perhaps those users will have to move to >> KR

KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-19 Thread Colin McCabe
Hi all, I wrote a short KIP about allowing AdminClient to talk directly with the KRaft controller quorum. Check it out here: https://cwiki.apache.org/confluence/x/Owo0Dw best, Colin

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-19 Thread Colin McCabe
On Wed, Apr 19, 2023, at 14:37, Ron Dagostino wrote: > Thanks for the KIP, Colin. > > There seems to be some inconsistency between sometimes referring to > "TargetKRaftControllerQuorum" and other times referring to > "DirectToKRaftControllerQuorum". Aside fro

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-20 Thread Colin McCabe
On Wed, Apr 19, 2023, at 20:56, Philip Nee wrote: > Hey Colin, > > I still need to finish reading and understanding the KIP, but I have a > couple of comments despite being ignorant of most of the KRaft stuff. > (Sorry!) > > Firstly, does it make sense to create an ext

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-20 Thread Colin McCabe
On Tue, Apr 18, 2023, at 09:01, Christo Lolov wrote: > Thank you all for the suggestions for improvements on the KIP and the > resulting discussions! > > Since the voting has been opened for ~2 months and I have received 3 > binding +1 (Colin, Ismael, Mickael) and 1 non-binding +1

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-24 Thread Colin McCabe
On Fri, Apr 21, 2023, at 14:17, Jason Gustafson wrote: > Hey Colin, > > The KIP makes sense overall. Nice to clarify the contract between clients > and the controllers. The use of `DirectToKRaftControllerQuorum` will help > prevent misconfiguration. In fact, I wonder if we can retur

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-26 Thread Colin McCabe
On Tue, Apr 25, 2023, at 04:59, Divij Vaidya wrote: > Thank you for the KIP Colin. > > In general, I like the idea of having the ability to interact directly with > the controllers. I agree with your observation that it helps in situations > where you would want to get data di

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-27 Thread Colin McCabe
On Wed, Apr 26, 2023, at 22:08, Luke Chen wrote: > Hi Colin, > > Some comments: > 1. I agree we should set "top-level" errors for metadata response > > 2. In the "brokers" field of metadata response from controller, it'll > respond wit

Re: [VOTE] 3.5.0 RC0

2023-05-24 Thread Colin McCabe
s for these issues and will get them in soon, we think! So unfortunately I have to leave a -1 here for RC0. Let's aim for another RC next week. best, Colin On Wed, May 24, 2023, at 07:05, Mickael Maison wrote: > Hi David, > > We're already quite a bit behind schedule. If you

Re: [VOTE] 3.5.0 RC0

2023-05-24 Thread Colin McCabe
Hi Ismael, I do personally think they are blockers. But just as importantly, KAFKA-14996 is not related to zk to kraft migration, and is a blocker. So we will need another RC in any case. best, Colin On Wed, May 24, 2023, at 11:50, Ismael Juma wrote: > Are all these blockers? For example,

Re: [DISCUSS] Re-visit end of life policy

2023-05-31 Thread Colin McCabe
me bugs that ZK mode had in some cases. We've also put in a lot of work to ensure that migration will not involve any downtime. If there is something broken then let's fix the broken thing and move forward, just as we've always done. And just as Kafka system administrators have a

Re: [DISCUSS] KIP-921 OpenJDK CRaC support

2023-05-31 Thread Colin McCabe
r? Maybe I missed something while reading but I can't see how the end-user benefits. Faster client startup time perhaps? But then the question is how much faster? In general, I would expect Kafka client startup time to be mostly bound by the time it takes to contact the brokers. best, Colin

Re: [VOTE] 3.5.0 RC0

2023-06-01 Thread Colin McCabe
Hi Mickael, Can you start the new RC tomorrow? There's one last PR we'd like to get in. If we can't get it in by tomorrow then let's go ahead anyway. Thanks very much, Colin On Thu, Jun 1, 2023, at 14:15, Mickael Maison wrote: > Hi David, > > The PR you mention

[DISCUSS] KIP-938: Add more metrics for measuring KRaft performance

2023-06-01 Thread Colin McCabe
Hi all, I posted a KIP to add some more metrics for measuring KRaft performance. Take a look at: https://cwiki.apache.org/confluence/x/gBU0Dw best, Colin

Re: [DISCUSS] KIP-938: Add more metrics for measuring KRaft performance

2023-06-02 Thread Colin McCabe
Hi Ron, Thanks for the review. On Fri, Jun 2, 2023, at 11:26, Ron Dagostino wrote: > Thanks for the KIP, Colin. The KIP cals one metric > "NewActiveControllersCount" but we don't append "Count" to the other > metric names (e.g. it is &qu

Re: [DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-06-02 Thread Colin McCabe
7;t block deletion on KRaft. If you delete a topic and then bounce the broker that had the disk full, it will delete the topic directory on startup as part of its snapshot load process. So I'm not sure if we really need this. Maybe we should re-evaluate once we have JBOD + KRaft. best

Re: [DISCUSS] KIP-934: Add DeleteTopicPolicy

2023-06-02 Thread Colin McCabe
ed to enforcce specific topic names or conventions, beyond what ACLs could provide. So it would be good to understand a bit more about why ACLs are not a better solution than deletion policies. One last note: if we do this, we should pass the UUID of the topic as well as the name. best, Colin On Mon

Re: [DISCUSS] Regarding Old PRs

2023-06-02 Thread Colin McCabe
imple approach where we mark PRs as stale after 30 days and email the submitter at that time. And then delete after 60 days. (Of course the exact time periods might be something gother than 30/60 but this is just an initial suggestion) best, Colin On Fri, Jun 2, 2023, at 00:37, Josep Prat wrote: >

Re: [DISCUSS] Regarding Old PRs

2023-06-02 Thread Colin McCabe
That should read "30 days without activity" (I am assuming we have the ability to determine when a PR was last updated on GH) best, Colin On Fri, Jun 2, 2023, at 12:32, Colin McCabe wrote: > Hi all, > > Looking at GitHub, I have a bunch of Kafka PRs of my own that I'

Re: [DISCUSS] KIP-935: Extend AlterConfigPolicy with existing configurations

2023-06-02 Thread Colin McCabe
Java. We should also clarify that if configurations are being proposed for deletion, they won't appear in proposedConfigs. best, Colin On Tue, May 23, 2023, at 03:03, Christo Lolov wrote: > Hello! > > This proposal will address problems with configuration dependencies which I &

Re: [DISCUSS] KIP-938: Add more metrics for measuring KRaft performance

2023-06-05 Thread Colin McCabe
On Sun, Jun 4, 2023, at 04:10, Divij Vaidya wrote: > Thanks for the KIP Colin. I liked the rationale section which clearly > explains why the metrics are required and what they might indicate. > > 1. I have a question about the "CurrentMetadataVersion" metric. Correct >

[VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-05 Thread Colin McCabe
Hi all, I'd like to open the vote for KIP-938: Add more metrics for measuring KRaft performance. Take a look here: https://cwiki.apache.org/confluence/x/gBU0Dw Thanks to everyone who reviewed the proposal. best, Colin

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-06 Thread Colin McCabe
Hi Divij, Yes, I am referring to the feature level. I changed the description of CurrentMetadataVersion to reference the feature level specifically. best, Colin On Tue, Jun 6, 2023, at 05:56, Divij Vaidya wrote: > "Each metadata version has a corresponding intege

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-06 Thread Colin McCabe
Hi all, I added two new metrics to the list: * LatestSnapshotGeneratedBytes * LatestSnapshotGeneratedAgeMs These will help monitor the period snapshot generation process. best, Colin On Tue, Jun 6, 2023, at 22:21, Colin McCabe wrote: > Hi Divij, > > Yes, I am referring to the feat

Re: [DISCUSS] KIP-935: Extend AlterConfigPolicy with existing configurations

2023-06-06 Thread Colin McCabe
On Tue, Jun 6, 2023, at 06:57, Jorge Esteban Quilcate Otoya wrote: > Thanks Colin. > >> I would suggest renaming the "configs" parameter to "proposedConfigs," in > both the new and old RequestMetadata constructors, to make things clearer. > This would be a bi

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-07 Thread Colin McCabe
Hi Luke, Thanks for the review and the suggestion. I think we will add more "handling time" metrics later, but for now I don't want to make this KIP any bigger than it is already... best, Colin On Wed, Jun 7, 2023, at 03:12, Luke Chen wrote: > Hi Colin, > > One co

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-08 Thread Colin McCabe
On Thu, Jun 8, 2023, at 10:00, David Arthur wrote: > Colin, thanks for the KIP! These all seem like pretty useful additions. A > few quick questions > > 1) Will the value of TimedOutBrokerHeartbeatCount be zero for inactive > controllers? No. It will just stay at whatever

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-08 Thread Colin McCabe
One note. I added ForwardingManager queue metrics. This should be the last addition! best, Colin On Thu, Jun 8, 2023, at 14:47, Colin McCabe wrote: > On Thu, Jun 8, 2023, at 10:00, David Arthur wrote: >> Colin, thanks for the KIP! These all seem like pretty useful additions. A >

Re: [VOTE] KIP-938: Add more metrics for measuring KRaft performance

2023-06-09 Thread Colin McCabe
Hi all, Thanks for the votes and discussion. I'm going to close the vote. With a binding +1 from David Arthur, Ron Dagostino, and Luke Chen, and non-binding +1s from Divij Vaidya and Igor Soarez, the vote passes. regards, Colin On Thu, Jun 8, 2023, at 20:17, David Arthur wrote: > Ok

Re: [DISCUSS] KIP-935: Extend AlterConfigPolicy with existing configurations

2023-06-12 Thread Colin McCabe
See KAFKA-14195. Some deletions are not handled correctly. And this cannot be fixed without a kip because of backwards compatibility. Colin On Wed, Jun 7, 2023, at 17:07, Jorge Esteban Quilcate Otoya wrote: > Thank Colin. > > I've took a closer look on how configs are passed to t

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-06-14 Thread Colin McCabe
my/log/dir2=JLEIRzVKR7iJ0-JgQm8niA We would have to have some way of escaping the equals sign if it appeared in a path, of course. I'm not sure, the directory.ids issue is a frustrating one. best, Colin On Tue, Jun 13, 2023, at 00:56, ziming deng wrote: > Hi Igor, Thanks for this work. &

Re: [DISCUSS] KIP-935: Extend AlterConfigPolicy with existing configurations

2023-06-15 Thread Colin McCabe
;changed" map whose values are Optionals, and express deletions as Optional.empty The old API should just stay the same, bugs and all, for compatibility reasons. But for the new API we should choose one of the above, I think. I'm not completely sure which... best, Colin On Mon, Jun 12

Re: [DISCUSS] KIP-942: Add Power(ppc64le) support

2023-07-03 Thread Colin McCabe
shipped in 2005....) best, Colin On Mon, Jun 19, 2023, at 23:12, Vaibhav Nazare wrote: > Thank you for response Divij. > > 1. We are going to use ASF infra provided nodes for better availability > and stability as there are 3 power9 nodes managed officially by ASF > infra

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-07-03 Thread Colin McCabe
On Mon, Jun 26, 2023, at 05:08, Igor Soarez wrote: > Hi Colin, > > Thanks for your support with getting this over the line and that’s > great re the preliminary pass! Thanks also for sharing your > thoughts, I've had a careful look at each of these and sharing my > comments

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-07 Thread Colin McCabe
and that it's frustrating to not get a quick response. However, overall I think this one needs a lot more discussion before getting anywhere near a vote. I will leave a -1 just as a procedural step. Maybe some of the people working in the client area can also chime in. best, Colin On Thu, Ju

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-08 Thread Colin McCabe
On Sat, Jul 8, 2023, at 02:41, Erik van Oosten wrote: > Hi Colin, > > Thanks for your thoughts and taking the time to reply. > > Let me take away your concerns. None of your worries are an issue with > the algorithm described in KIP-944. Here it goes: > > > It's n

Re: [DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-07-08 Thread Colin McCabe
On Wed, Jun 7, 2023, at 07:07, Christo Lolov wrote: > Hey Colin, > > I tried the following setup: > > * Create 3 EC2 machines. > * EC2 machine named A acts as a KRaft Controller. > * EC2 machine named B acts as a KRaft Broker. (The only configurations > differe

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-13 Thread Colin McCabe
draft on the wiki for KIP-945 but haven't posted a DISCUSS thread yet, so I assume it's not ready for review yet ;) best, Colin On Tue, Jul 11, 2023, at 12:24, Philip Nee wrote: > Hey Erik - Another thing I want to add to my comment is. We are in-process > of re-writing the K

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-20 Thread Colin McCabe
On Tue, Jul 4, 2023, at 04:46, Tom Bentley wrote: > Hi Colin, > > Thanks for the KIP. > > 1. It mentions kafka-configs.sh as one of the affected tools, but doesn't > mention that ControllerApis doesn't currently support DESCRIBE_CONFIGS. I > think this is worth notin

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-20 Thread Colin McCabe
upported via the alterClientQuotas API. > > 5. Do we have any plan for this feature to be completed? v3.6.0? > Yes, I would like to target 3.6. If time gets tight one or two command conversions might slip. The most critical command line tools to support are the ones for getting the quorum

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-20 Thread Colin McCabe
On Tue, Jul 18, 2023, at 09:30, Mickael Maison wrote: > H Colin, > > Thanks for the KIP. > > Just a few points: > 1. As Tom mentioned it would be good to clarify the APIs we expect > available on controllers. I assume we want to add DESCRIBE_CONFIGS as > part of this KIP.

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-21 Thread Colin McCabe
On Fri, Jul 21, 2023, at 08:14, David Arthur wrote: > Hey Colin, thanks for the KIP! Some questions > Hi David, Thanks for reviewing. > 1) "This registration will include information about the endpoints which > they possess" Will this include all endpoints, or on

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-21 Thread Colin McCabe
On Fri, Jul 21, 2023, at 09:43, José Armando García Sancio wrote: > Thanks for the KIP Colin. Apologies if some of these points have > already been made. I have not followed the discussion closely: > > 1. Re: Periodically, each controller will check that the controller > registratio

[VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-24 Thread Colin McCabe
Hi all, I'd like to start the vote for KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration. The KIP is here: https://cwiki.apache.org/confluence/x/Owo0Dw Thanks to everyone who reviewed the proposal. best, Colin

Re: Apache Kafka 3.6.0 release

2023-07-24 Thread Colin McCabe
) I also added "KIP-938: Add more metrics for measuring KRaft performance," which is a new KIP we are implemeting in 3.6 (The JIRA is open now for review.) Same for KIP-919 which is being voted on now. best, Colin On Mon, Jul 24, 2023, at 03:59, Satish Duggana wrote: > A gentle remi

Re: We want to remove Zookeeper from our Kafka cluster which version to use?

2021-01-20 Thread Colin McCabe
a features, but it will let you take a look and try it out. cheers, Colin On Tue, Jan 19, 2021, at 01:26, Manojbvn Barthipudi wrote: > Hi All, > > We have a Kafka cluster [5-10 nodes] with multiple topics [with multi > partitions] managed by the Zookeeper cluster. We want to r

Re: Please help | KIP-500 | KAFKA-9119

2021-02-08 Thread Colin McCabe
Hi Gaurav, There will be a preview of KIP-500 in Apache Kafka 2.8, like we discussed earlier. Hope this helps. best, Colin On Wed, Jan 27, 2021, at 22:57, gaurav chhabra wrote: > Hi Team, > > Can you please help on the timelines of the below? > > Is it confirmed for Apach

Re: [DISCUSS] KIP-631: The Quorum-based Kafka Controller

2021-02-08 Thread Colin McCabe
Hi Gwen, Thanks for taking a look. Yes, I do think unregisterBroker would be a better name than decommissionBroker. Let's do that, and also rename the associated RPC. cheers, Colin On Sat, Feb 6, 2021, at 21:13, Gwen Shapira wrote: > I realize that I'm very very late to a pre

Re: [ANNOUNCE] New committer: Tom Bentley

2021-03-19 Thread Colin McCabe
Congratulations, Tom! Colin On Fri, Mar 19, 2021, at 08:09, Viktor Somogyi-Vass wrote: > Congrats Tom! :) > > On Wed, Mar 17, 2021 at 3:47 PM Chia-Ping Tsai wrote: > > > Congratulations!!! > > > > On 2021/03/15 17:59:56, Mickael Maison wrote: > > >

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-22 Thread Colin McCabe
ld help to know a bit more about your configuration. You are using SSL, right? I think if you used plaintext, sendfile would avoid this issue. What kind of disks are you using? We may find that increasing buffering in the SSL layer would avoid this issue without the drawbacks of enabling Nagl

Re: [VOTE] KIP-720 Deprecate MirrorMaker v1

2021-04-01 Thread Colin McCabe
t that MM2 reaches feature parity with MM1 before deprecating MM1. Or if we can't reach feature parity, we should explain why the unsupported features are not needed going forward. Do we have a list of all the gaps? best, Colin On Thu, Apr 1, 2021, at 09:44, Ismael Juma wrote: > OK. :) Ma

Re: [DISCUSS] KIP-712: Shallow Mirroring

2021-04-01 Thread Colin McCabe
. The usage of EOS is increasing. Also, one can't tell from the > metadata of a topic whether it has EOS data or not. So, there is no easy > way to skip EOS data from the source. I also agree... we should not create more technical debt here. Colin > > Jun > > On Thu, Apr 1

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-04-01 Thread Colin McCabe
+1 (binding). Thanks for the KIP. Colin On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote: > Thanks for this KIP. +1 (binding) > > On 2021/03/29 15:34:55, Tom Bentley wrote: > > Hi, > > > > I'd like to start a vote on KIP-707, which proposes to add &

Re: [VOTE] KIP-720 Deprecate MirrorMaker v1

2021-04-02 Thread Colin McCabe
a non-deprecated way, the non-deprecated way is the recommended way. If we are onboarding more users to the deprecated code path (for example, because there's major features missing in the new code path), we're doing something wrong. best, Colin On Thu, Apr 1, 2021, at 15:48, Rya

Re: [DISCUSS] KIP-729 Custom validation of records on the broker prior to log append

2021-04-02 Thread Colin McCabe
in public APIs. best, Colin On Thu, Apr 1, 2021, at 14:18, Soumyajit Sahu wrote: > Hello All, > I would like to start a discussion on the KIP-729. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-729%3A+Custom+validation+of+records+on+the+broker+prior+to+log+append > > Thanks! > Soumyajit >

Re: [DISCUSS] KIP-729 Custom validation of records on the broker prior to log append

2021-04-06 Thread Colin McCabe
. ApiRecordError is also an internal class, so it can't be used in a public API. I think most likely if we were going to do this, we would just catch an exception and use the exception text as the validation error. best, Colin On Tue, Apr 6, 2021, at 15:57, Soumyajit Sahu wrote: > Hi Tom, &g

Re: [VOTE] 2.8.0 RC2

2021-04-17 Thread Colin McCabe
en created. cheers, Colin On Fri, Apr 16, 2021, at 17:08, Randall Hauch wrote: > Hey, John. > > +1 (binding) > > I've performed the following: > 1. Validated the signatures and checksums > 2. Built the project from the src tgz file, and ran some of the unit tests

Re: Requesting review of PR 10377

2021-04-22 Thread Colin McCabe
Hi feyman2009, Thanks for the PR. I pinged a few people about reviewing it. I don't know if anyone will be able to look at it this week, but probably next week we can. The good news is that this field is optional (tagged) so the protocol will still work with older clients. best, Colin

Re: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2021-04-22 Thread Colin McCabe
Hi Sarwar, It seems like we didn't reach a consensus last time about this KIP. So I would suggest revising the KIP, and then creating a new DISCUSS thread when it's ready for review. regards, Colin On Wed, Apr 14, 2021, at 01:26, Sarwar Bhuiyan wrote: > Forgive me while I find

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Colin McCabe
. On the other hand, as you mention, we only really need the highest one for correctness. best, Colin On Thu, May 6, 2021, at 11:53, Tom Bentley wrote: > Hi David, > > Thanks for the KIP, +1 binding. > > Tom > > On Thu, May 6, 2021 at 7:16 PM Guozhang Wang wrote:

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Colin McCabe
Sorry, I meant to write "AllocateProducerIdsRecord" in the previous message. -C. On Thu, May 6, 2021, at 12:58, Colin McCabe wrote: > Hi David, > > Thanks for the KIP -- it looks good. > > It seems like we should be clear that the new RPC should be used for > bot

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-11 Thread Colin McCabe
Thanks, David. I don't feel strongly about preserving the extra records in the snapshot, so let's just leave it as is. +1 (binding) cheers, Colin On Fri, May 7, 2021, at 09:51, David Arthur wrote: > Colin, thanks for the feedback. I like the record name you proposed. I've

Re: [VOTE] KIP-720 Deprecate MirrorMaker v1

2021-05-24 Thread Colin McCabe
Thanks, Ryanne. Can you add information about this way forward to the KIP? Also it would be good to clarify that this work needs to get done before removing MM1. best, Colin On Thu, May 20, 2021, at 16:00, Ryanne Dolan wrote: > Hey y'all, reviving this thread because it seems we ha

Re: [DISCUSS] KIP-739: Block Less on KafkaProducer#send

2021-05-24 Thread Colin McCabe
e this, but we could offer it as a possibility for async purists (which might include certain frameworks). The big problem the users would have to solve is what to do with the record that they were unable to produce due to the buffer full issue. best, Colin On Thu, May 20, 2021, at 10:35, Na

<    7   8   9   10   11   12   13   14   15   16   >