Sorry, I meant to write "AllocateProducerIdsRecord" in the previous message. -C.
On Thu, May 6, 2021, at 12:58, Colin McCabe wrote: > Hi David, > > Thanks for the KIP -- it looks good. > > It seems like we should be clear that the new RPC should be used for > both the ZK and KRaft cases. I think that is implied, but it would be > good to spell it out just to be clear. As the KIP explains, this is > needed for the bridge release. > > I think AllocateProducersIdRecord would be a nicer name than > ProducerIdRecord -- what do you think? > > In the snapshot, does it make sense to store the latest producer ID > allocation record for every broker? This might be useful for debugging > purposes, and it's unlikely to be that many records.... On the other > hand, as you mention, we only really need the highest one for > correctness. > > best, > Colin > > > On Thu, May 6, 2021, at 11:53, Tom Bentley wrote: > > Hi David, > > > > Thanks for the KIP, +1 binding. > > > > Tom > > > > On Thu, May 6, 2021 at 7:16 PM Guozhang Wang <wangg...@gmail.com> wrote: > > > > > LGTM! Thanks David. > > > > > > On Thu, May 6, 2021 at 10:03 AM Ron Dagostino <rndg...@gmail.com> wrote: > > > > > > > Thanks again for the KIP, David. +1 (non-binding) from me. > > > > > > > > Ron > > > > > > > > On Tue, May 4, 2021 at 11:21 AM David Arthur <mum...@gmail.com> wrote: > > > > > > > > > Hello everyone, I'd like to start the vote on KIP-730 which adds a new > > > > RPC > > > > > for producer ID generation in KRaft mode. > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-730%3A+Producer+ID+generation+in+KRaft+mode > > > > > > > > > > > > > > > > > > > > -- > > > > > David Arthur > > > > > > > > > > > > > > > > > > -- > > > -- Guozhang > > > > > >
