[GitHub] kafka pull request #3786: MINOR: preparing for bug fix release

2017-09-05 Thread dguy
Github user dguy closed the pull request at: https://github.com/apache/kafka/pull/3786 ---

[jira] [Created] (KAFKA-5835) CommitFailedException message is misleading and cause is swallowed

2017-09-05 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-5835: --- Summary: CommitFailedException message is misleading and cause is swallowed Key: KAFKA-5835 URL: https://issues.apache.org/jira/browse/KAFKA-5835 Project: Kafka

[GitHub] kafka pull request #3788: MINOR: update docs

2017-09-05 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/3788 MINOR: update docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka RULE-DOC Alternatively you can review and apply these change

[GitHub] kafka pull request #3789: MINOR: Fix a couple of ftp related issues in relea...

2017-09-05 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3789 MINOR: Fix a couple of ftp related issues in release.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka ftp-release-py-fixes Alternat

[GitHub] kafka pull request #3789: MINOR: Fix sftp_mkdir in release.py

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3789 ---

[jira] [Created] (KAFKA-5836) Kafka Streams - API for specifying internal stream name on join

2017-09-05 Thread JIRA
Lovro Pandžić created KAFKA-5836: Summary: Kafka Streams - API for specifying internal stream name on join Key: KAFKA-5836 URL: https://issues.apache.org/jira/browse/KAFKA-5836 Project: Kafka

Jenkins build is back to normal : kafka-trunk-jdk7 #2706

2017-09-05 Thread Apache Jenkins Server
See

[GitHub] kafka pull request #3790: MINOR: fix scalaVersion variable in templateData.j...

2017-09-05 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3790 MINOR: fix scalaVersion variable in templateData.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/dguy/kafka fix-js-tempate Alternatively you ca

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Ismael Juma
Hi Edoardo, Do you intend to update the KIP to avoid the introduction of another interface? Ismael On Fri, Jun 23, 2017 at 5:47 PM, Edoardo Comar wrote: > Thanks for the thoughts Ismael > > > 1. Have you considered extending RequestMetadata with the additional > > information you need? We coul

[GitHub] kafka pull request #3790: MINOR: fix scalaVersion variable in templateData.j...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3790 ---

Build failed in Jenkins: kafka-0.11.0-jdk7 #295

2017-09-05 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: Fix sftp_mkdir in release.py -- [...truncated 2.44 MB...] org.apache.kafka.streams.state.internals.ChangeLoggingKeyValueBytesStoreTest >

Build failed in Jenkins: kafka-trunk-jdk7 #2707

2017-09-05 Thread Apache Jenkins Server
See -- [...truncated 922.92 KB...] kafka.server.epoch.LeaderEpochFileCacheTest > shouldUpdateSavedOffsetWhenOffsetToClearToIsBetweenEpochs PASSED kafka.server.epoch.LeaderEpochFileCache

Build failed in Jenkins: kafka-trunk-jdk7 #2708

2017-09-05 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: fix scalaVersion variable in templateData.js -- [...truncated 922.02 KB...] kafka.server.ServerGenerateBrokerIdTest > testMultipleLogDirs

Jenkins build is back to normal : kafka-0.11.0-jdk7 #296

2017-09-05 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #1972

2017-09-05 Thread Apache Jenkins Server
See Changes: [damian.guy] MINOR: fix scalaVersion variable in templateData.js -- [...truncated 2.65 MB...] org.apache.kafka.connect.runtime.distributed.DistributedHerderT

[GitHub] kafka pull request #3791: MINOR: Update dependencies for 1.0.0 release

2017-09-05 Thread andrasbeni
GitHub user andrasbeni opened a pull request: https://github.com/apache/kafka/pull/3791 MINOR: Update dependencies for 1.0.0 release Updates dependencies to their latest versions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/an

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-09-05 Thread Randall Hauch
Thanks for taking into account my suggestions/concerns. I had a few very minor suggestions on the PR regarding documentation, but overall everything looks great to me. I'd encourage anyone else to review https://cwiki.apache.org/confluence/display/KAFKA/KIP-131+-+Add+access+to+OffsetStorageReader+

[jira] [Created] (KAFKA-5837) ReassignPartitionsCommand fails if default throttle/timeout used

2017-09-05 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-5837: - Summary: ReassignPartitionsCommand fails if default throttle/timeout used Key: KAFKA-5837 URL: https://issues.apache.org/jira/browse/KAFKA-5837 Project: Kafka

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Ismael Juma
Thanks Rajini, +1 (binding) from me. Just a few minor comments: 1. FetchDownConversionsPerSec should probably be MessageConversionsPerSec with a request tag for consistency with MessageConversionsTimeMs. The text in that paragraph should also be updated to talk about message conversions instead of

[GitHub] kafka pull request #3792: KAFKA-5837: Set defaults for ReassignPartitionsCom...

2017-09-05 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3792 KAFKA-5837: Set defaults for ReassignPartitionsCommand correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka KAFKA

[GitHub] kafka pull request #3793: MINOR: add mvn-pgp-plugin to sign streams quicksta...

2017-09-05 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3793 MINOR: add mvn-pgp-plugin to sign streams quickstart jars You can merge this pull request into a Git repository by running: $ git pull https://github.com/dguy/kafka sign-mvn-jars Alternatively y

[GitHub] kafka-site pull request #73: Add coding guidelines for Streams API

2017-09-05 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/73#discussion_r137037867 --- Diff: coding-guide.html --- @@ -102,6 +102,47 @@ We should attempt to maintain API compatibility when possible, though at this point in

Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient

2017-09-05 Thread Tom Bentley
I've revised this KIP again: * Change the alterPartitionCounts() API to support passing an optional assignment for the new partitions (which is already supported by kafka-topics.sh). At the same time I didn't want the API to suggest it was possible to change the existing assignments in the same ca

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Rajini Sivaram
Hi Ismael, 1. At the moment FetchDownConversionsPerSec is a topic metric while MessageConversionTimeMs is a request metric which indicates Produce/Fetch as a tag. Are you suggesting that we should convert FetchDownConversionsPerSec to a request metric called MessageConversionsPerSec for fetch requ

Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient

2017-09-05 Thread Ted Yu
bq. What about startPartitionAssignment() ? Make sense. startPartitionReassignment() seems to be better since the API deals with reassignment. Cheers On Tue, Sep 5, 2017 at 9:39 AM, Tom Bentley wrote: > I've revised this KIP again: > > * Change the alterPartitionCounts() API to support passing

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Ismael Juma
Thanks Rajini. 1. I meant a topic metric, but we could have one for fetch and one for produce differentiated by the additional tag. The advantage is that the name would be consistent with the request metric for message conversions. However, on closer inspection, this would make the name inconsiste

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

2017-09-05 Thread Rajini Sivaram
+1 (binding) Thank you for the KIP, Jason. On Thu, Aug 31, 2017 at 8:33 PM, Mickael Maison wrote: > +1 (non binding) > > Thanks for the KIP > > On Thu, Aug 31, 2017 at 10:10 AM, Jun Rao wrote: > > That's also fine as long as it's documented in the interface somehow. The > > only thing with jav

Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient

2017-09-05 Thread Colin McCabe
On Tue, Sep 5, 2017, at 09:39, Tom Bentley wrote: > I've revised this KIP again: > > * Change the alterPartitionCounts() API to support passing an optional > assignment for the new partitions (which is already supported by > kafka-topics.sh). At the same time I didn't want the API to suggest it >

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Rajini Sivaram
Hi Ismael, 1. Yes, that makes sense. Updated the KIP to use FetchMessageConversionsPerSec and ProduceMessageConversionsPerSec. Thank you, Rajini On Tue, Sep 5, 2017 at 6:20 PM, Ismael Juma wrote: > Thanks Rajini. > > 1. I meant a topic metric, but we could have one for fetch and one for > pro

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Edoardo Comar
Hi Ismael, I was on leave for a long while. I will update the KIP. Edo On 5 September 2017 at 11:42, Ismael Juma wrote: > Hi Edoardo, > > Do you intend to update the KIP to avoid the introduction of another > interface? > > Ismael > > On Fri, Jun 23, 2017 at 5:47 PM, Edoardo Comar wrote: > > >

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Jason Gustafson
+1 Lots of good stuff in here. One minor nit: in the name `FetchDownConversionsPerSec`, it's implicit that down-conversion is for messages. Could we do the same for `MessageConversionsTimeMs` and drop the `Message`? Then we don't have to decide if it should be 'Record' instead. On Tue, Sep 5, 201

[GitHub] kafka pull request #3793: MINOR: add mvn-pgp-plugin to sign streams quicksta...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3793 ---

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Mickael Maison
+1 (non binding) On Tue, Sep 5, 2017 at 6:51 PM, Jason Gustafson wrote: > +1 Lots of good stuff in here. > > One minor nit: in the name `FetchDownConversionsPerSec`, it's implicit that > down-conversion is for messages. Could we do the same for > `MessageConversionsTimeMs` and drop the `Message`?

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Tom Bentley
Hi Edoardo, KIP-179 will support changing topic configurations via the AdminClient and this would open a loophole to avoid the current CreateTopicPolicy: 1. Create a topic that sticks to the policy 2. Modify the topic after creation to something which would have violated the policy. For this rea

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Ismael Juma
I was wondering about the message versus record question. The fact that we already have MessagesInPerSec seemed to favour the former. The other aspect is that for produce requests, we can up convert as well, so it seemed better to keep it generic. Ismael On Tue, Sep 5, 2017 at 6:51 PM, Jason Gust

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

2017-09-05 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Wed, Aug 30, 2017 at 4:51 PM, Jason Gustafson wrote: > I'd like to open the vote for KIP-189: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL. > Thanks to everyone who help

[jira] [Created] (KAFKA-5838) Speed up running system tests in docker a bit

2017-09-05 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5838: -- Summary: Speed up running system tests in docker a bit Key: KAFKA-5838 URL: https://issues.apache.org/jira/browse/KAFKA-5838 Project: Kafka Issue Type: B

[GitHub] kafka pull request #3794: KAFKA-5838. Speed up running system tests in docke...

2017-09-05 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3794 KAFKA-5838. Speed up running system tests in docker a bit with better… … sshd options You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Jason Gustafson
The proposal looks good. Two minor comments: 1. Can we call out how we handle the duplicate case? This is a change in behavior since we currently raise OutOfOrderSequence in this case. 2. Instead of passing through `idempotenceLevel` in the ProduceRequest, I wonder if we should have a field for t

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Jason Gustafson
> > I was wondering about the message versus record question. The fact that we > already have MessagesInPerSec seemed to favour the former. The other aspect > is that for produce requests, we can up convert as well, so it seemed > better to keep it generic. Yeah, so I thought maybe we could bypas

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Ismael Juma
If we add the message format version (a topic config) in the response of TopicMetadata, we should consider adding the max message bytes as well. That would allow us to later improve the implementation of KIP-126 to split the batch _before_ sending. Ismael On Tue, Sep 5, 2017 at 7:17 PM, Jason Gus

Build failed in Jenkins: kafka-trunk-jdk8 #1973

2017-09-05 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: add mvn-pgp-plugin to sign streams quickstart jars -- [...truncated 892.47 KB...] kafka.security.auth.SimpleAclAuthorizerTest > testAclInhe

Build failed in Jenkins: kafka-trunk-jdk8 #1974

2017-09-05 Thread Apache Jenkins Server
See -- [...truncated 86.33 KB...] ^

Jenkins build is back to normal : kafka-trunk-jdk7 #2709

2017-09-05 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-0.11.0-jdk7 #297

2017-09-05 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: add mvn-pgp-plugin to sign streams quickstart jars -- [...truncated 971.43 KB...] kafka.admin.ResetConsumerGroupOffsetTest > testResetOffset

[GitHub] kafka pull request #3328: KAFKA-5559: Metrics should throw if two client reg...

2017-09-05 Thread mjsax
Github user mjsax closed the pull request at: https://github.com/apache/kafka/pull/3328 ---

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Ted Yu
For enable.idempotence=safe, it seems giving user impression that idempotence would be safe. However, since it really means best effort, the 'safety' is debatable. Why not just call the new mode besteffort ? Cheers On Tue, Sep 5, 2017 at 11:24 AM, Ismael Juma wrote: > If we add the message fo

Jenkins build is back to normal : kafka-0.11.0-jdk7 #298

2017-09-05 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-05 Thread Guozhang Wang
+1 On Fri, Sep 1, 2017 at 3:45 PM, Matthias J. Sax wrote: > +1 > > On 9/1/17 2:53 PM, Bill Bejeck wrote: > > +1 > > > > On Thu, Aug 31, 2017 at 10:20 AM, Damian Guy > wrote: > > > >> Thanks everyone for voting! Unfortunately i've had to make a bit of an > >> update based on some issues found du

[VOTE] 0.11.0.1 RC0

2017-09-05 Thread Damian Guy
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 0.11.0.1. This is a bug fix release and it includes fixes and improvements from 49 JIRAs (including a few critical bugs). Release notes for the 0.11.0.1 release: http://home.apache.org/~d

Re: [VOTE] KIP-138: Change punctuate semantics

2017-09-05 Thread Guozhang Wang
Thanks for your inputs. The main motivation is indeed to achieve consistency as we use "wall-clock-time" in some existing classes already, e.g. http://kafka.apache.org/0101/javadoc/index.html?org/apache/kafka/streams/processor/WallclockTimestampExtractor.html . Since there is no objections I will

[GitHub] kafka-site pull request #73: Add coding guidelines for Streams API

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/73 ---

[GitHub] kafka-site issue #73: Add coding guidelines for Streams API

2017-09-05 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/73 LGTM. Merged to `asf-site`. ---

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Ismael Juma
Hi Ted, The current proposal has 3 options: requested, required, off ("safe" was in an earlier proposal). I think these convey the meaning more clearly IMO. Ismael On 5 Sep 2017 9:22 pm, "Ted Yu" wrote: > For enable.idempotence=safe, it seems giving user impression that > idempotence > would b

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Ted Yu
Sounds good. Please update the KIP and: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Exactly+Once+-+Dealing+with+older+message+formats+when+idempotence+is+enabled On Tue, Sep 5, 2017 at 2:03 PM, Ismael Juma wrote: > Hi Ted, > > The current proposal has 3 options: requested, required

Re: [DISCUSS] KIP-192 - Provide cleaner semantics when idempotence is enabled

2017-09-05 Thread Ismael Juma
Agreed, we should make it consistent across the various pages. On Tue, Sep 5, 2017 at 10:06 PM, Ted Yu wrote: > Sounds good. > > Please update the KIP and: > > https://cwiki.apache.org/confluence/display/KAFKA/ > Kafka+Exactly+Once+-+Dealing+with+older+message+formats+ > when+idempotence+is+enab

[GitHub] kafka pull request #2612: KAFKA-4819: Expose states for active tasks to publ...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2612 ---

Re: [DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-09-05 Thread Colin McCabe
On Mon, Sep 4, 2017, at 04:54, Tom Bentley wrote: > The KIP has been adopted after a successful vote. Thanks for working on this, Tom. It's a nice improvement. > > Unfortunately I've discovered that there's an annoying detail in the > handling of the case that electPreferredLeaders() is called

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-05 Thread Sriram Subramanian
+1 On Tue, Sep 5, 2017 at 1:33 PM, Guozhang Wang wrote: > +1 > > On Fri, Sep 1, 2017 at 3:45 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 9/1/17 2:53 PM, Bill Bejeck wrote: > > > +1 > > > > > > On Thu, Aug 31, 2017 at 10:20 AM, Damian Guy > > wrote: > > > > > >> Thanks everyone for voting!

[GitHub] kafka pull request #3795: KAFKA-5783: Add KafkaPrincipalBuilder with support...

2017-09-05 Thread hachikuji
GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/3795 KAFKA-5783: Add KafkaPrincipalBuilder with support for SASL (KIP-189) You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-57

[GitHub] kafka-site pull request #74: Adding portoseguro, micronauticsresearch & cj l...

2017-09-05 Thread manjuapu
GitHub user manjuapu opened a pull request: https://github.com/apache/kafka-site/pull/74 Adding portoseguro, micronauticsresearch & cj logos to powered by page You can merge this pull request into a Git repository by running: $ git pull https://github.com/manjuapu/kafka-site a

[GitHub] kafka pull request #3719: KAFKA-5603: Don't abort TX for zombie tasks

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3719 ---

[GitHub] kafka pull request #3771: MINOR: logging improvements

2017-09-05 Thread guozhangwang
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3771 ---

[GitHub] kafka pull request #2649: KAFKA-4860: Allow spaces in paths on windows

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2649 ---

[jira] [Resolved] (KAFKA-5837) ReassignPartitionsCommand fails if default throttle/timeout used

2017-09-05 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-5837. --- Resolution: Fixed Issue resolved by pull request 3792 [https://github.com/apache/kafka/pull/37

[GitHub] kafka pull request #3792: KAFKA-5837: Set defaults for ReassignPartitionsCom...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3792 ---

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Rajini Sivaram
I am ok with dropping 'Message'. So the names would be FetchConversionsPerSec, ProduceConversionsPerSec and ConversionsTimeMs. The first two sound fine. Not so sure about ConversionsTimeMs, but since it appears with Produce/Fetch as the request tag, it should be ok. I haven't updated the KIP yet. I

[jira] [Created] (KAFKA-5839) Upgrade Guide doc changes for KIP-130

2017-09-05 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-5839: Summary: Upgrade Guide doc changes for KIP-130 Key: KAFKA-5839 URL: https://issues.apache.org/jira/browse/KAFKA-5839 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-5840) TransactionsTest#testBasicTransactions hangs

2017-09-05 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5840: - Summary: TransactionsTest#testBasicTransactions hangs Key: KAFKA-5840 URL: https://issues.apache.org/jira/browse/KAFKA-5840 Project: Kafka Issue Type: Test Rep

[GitHub] kafka pull request #3787: KAFKA-5823: Extend upgrade section for KIP-120

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3787 ---

Jenkins build is back to normal : kafka-trunk-jdk8 #1975

2017-09-05 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-05 Thread Sumant Tambe
I've updated the kip-91 writeup to capture some of the discussion here. Please confirm if it's sufficiently accurate. Feel free to edit it if you think some explanation can be better and has b

[jira] [Created] (KAFKA-5841) Open old index files with read-only permission

2017-09-05 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-5841: -- Summary: Open old index files with read-only permission Key: KAFKA-5841 URL: https://issues.apache.org/jira/browse/KAFKA-5841 Project: Kafka Issue Type:

[GitHub] kafka pull request #3796: MINOR: KIP-138 renaming of string names

2017-09-05 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3796 MINOR: KIP-138 renaming of string names You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka kip-138-minor-renames Alternati

Build failed in Jenkins: kafka-0.11.0-jdk7 #299

2017-09-05 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: logging improvements on StreamThread -- [...truncated 2.09 MB...] org.apache.kafka.clients.admin.KafkaAdminClientTest > testDescribeAcls PA

[jira] [Resolved] (KAFKA-3856) Cleanup Kafka Streams builder API

2017-09-05 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-3856. Resolution: Fixed > Cleanup Kafka Streams builder API > - >

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Ismael Juma
I think I prefer the names with `Message` in them. For people less familiar with Kafka, it makes it a bit clearer, I think. Ismael On Wed, Sep 6, 2017 at 12:39 AM, Rajini Sivaram wrote: > I am ok with dropping 'Message'. So the names would be > FetchConversionsPerSec, > ProduceConversionsPerSec

Re: [VOTE] KIP-188 - Add new metrics to support health checks

2017-09-05 Thread Jason Gustafson
> > I think I prefer the names with `Message` in them. For people less familiar > with Kafka, it makes it a bit clearer, I think. Works for me. On Tue, Sep 5, 2017 at 5:19 PM, Ismael Juma wrote: > I think I prefer the names with `Message` in them. For people less familiar > with Kafka, it make

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-09-05 Thread Ismael Juma
Thanks for updating the KIP, Sumant. A couple of points: 1. I think the default for delivery.timeout.ms should be higher than 30 seconds given that we previously would reset the clock once the batch was sent. The value should be large enough that batches are not expired due to expected events like

[GitHub] kafka pull request #3535: KAFKA-5597: Autogenerate producer sender metrics.

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3535 ---

Build failed in Jenkins: kafka-trunk-jdk7 #2711

2017-09-05 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-4819: Expose states for active tasks to public API -- [...truncated 689.33 KB...] kafka.api.LegacyAdminClientTest > testListAllBrokerVersion

Build failed in Jenkins: kafka-0.11.0-jdk7 #300

2017-09-05 Thread Apache Jenkins Server
See Changes: [wangguoz] HOTFIX: remove unused imports -- [...truncated 2.08 MB...] org.apache.kafka.clients.producer.MockProducerTest > shouldThrowOnAbortTransactionIfPr

integration between pull request and JIRA

2017-09-05 Thread Ted Yu
Hi, Currently the conversations on pull request are not posted back to JIRA. Is there technical hurdle preventing this from being done ? Other Apache projects, such as Flink, establish automatic post from pull request to JIRA. Cheers

[jira] [Created] (KAFKA-5842) QueryableStateIntegrationTest may fail with JDK 7

2017-09-05 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5842: - Summary: QueryableStateIntegrationTest may fail with JDK 7 Key: KAFKA-5842 URL: https://issues.apache.org/jira/browse/KAFKA-5842 Project: Kafka Issue Type: Test

Jenkins build is back to normal : kafka-trunk-jdk7 #2712

2017-09-05 Thread Apache Jenkins Server
See

Re: integration between pull request and JIRA

2017-09-05 Thread Matthias J. Sax
This integration was never set up for Kafka. I personally don't see any advantage in this, as it just duplicates everything and does not add value IMHO. The PRs are linked and one can go to the PR to read the discussion if interested. Or what do you think the value would be? -Matthias On 9/5/

Re: integration between pull request and JIRA

2017-09-05 Thread Ted Yu
If a person watches github PR, that person watches conversations on all PRs, not just the one he / she intends to pay attention to. Quite often this leads to ton of emails in his / her inbox which is distracting. If the conversation is posted from PR to JIRA, watcher is per PR / JIRA. This is muc

[GitHub] kafka pull request #3188: KAFKA-5358: Consumer perf tool should count rebala...

2017-09-05 Thread huxihx
GitHub user huxihx reopened a pull request: https://github.com/apache/kafka/pull/3188 KAFKA-5358: Consumer perf tool should count rebalance time. Added 'join.group.ms' for new consumer to calculate the time of joining group. @hachikuji Please review the PR. Thanks. You c

[GitHub] kafka pull request #3723: KAFKA-5358: Consumer perf tool should count rebala...

2017-09-05 Thread huxihx
Github user huxihx closed the pull request at: https://github.com/apache/kafka/pull/3723 ---

Re: integration between pull request and JIRA

2017-09-05 Thread Matthias J. Sax
>> If a person watches github PR, that person watches conversations on all >> PRs, One can just "not watch" Kafka's Github repo. I don't watch it either and thus I get emails for only those PRs I did get tagged or I did comment on etc. Would this not work for you? -Matthias On 9/5/17 7:31 PM,

Re: integration between pull request and JIRA

2017-09-05 Thread Ted Yu
bq. I did get tagged or I did comment on etc. What if nobody tags me on the PR and I don't comment on it ? Cheers On Tue, Sep 5, 2017 at 8:55 PM, Matthias J. Sax wrote: > >> If a person watches github PR, that person watches conversations on all > >> PRs, > > One can just "not watch" Kafka's G

Permissions to create a KIP?

2017-09-05 Thread Matthias Margush
Hi, Can I be set up with access to author a KIP ( https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals)? My ID is matthias.margush. Thanks, Matthias -- *Matthias Margush* *matthias.marg...@fundingcircle.com * | 415.813.5245 (d) | 415.236.2884. (m) 747 Front St, 4th F

Re: Permissions to create a KIP?

2017-09-05 Thread Guozhang Wang
Hi Matthias, I have granted you the permission. Cheers. Guozhang On Tue, Sep 5, 2017 at 2:21 PM, Matthias Margush < matthias.marg...@fundingcircle.com> wrote: > Hi, > > Can I be set up with access to author a KIP ( > https://cwiki.apache.org/confluence/display/KAFKA/ > Kafka+Improvement+Propo

[jira] [Created] (KAFKA-5843) Mx4jLoader.maybeLoad should only be executed if kafka_mx4jenable is set to true

2017-09-05 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5843: --- Summary: Mx4jLoader.maybeLoad should only be executed if kafka_mx4jenable is set to true Key: KAFKA-5843 URL: https://issues.apache.org/jira/browse/KAFKA-5843 Project: Kafka

[GitHub] kafka pull request #3797: KAFKA-5843; Mx4jLoader.maybeLoad should only be ex...

2017-09-05 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3797 KAFKA-5843; Mx4jLoader.maybeLoad should only be executed if kafka_mx4jenable is set to true You can merge this pull request into a Git repository by running: $ git pull https://github.com/l

[GitHub] kafka pull request #3798: KAFKA-5841: AbstractIndex should offer `makeReadOn...

2017-09-05 Thread huxihx
GitHub user huxihx opened a pull request: https://github.com/apache/kafka/pull/3798 KAFKA-5841: AbstractIndex should offer `makeReadOnly` method AbstractIndex should offer `makeReadOnly` method that changed the underlying MappedByteBuffer read-only. You can merge this pull request