Hi Ismael, 1. At the moment FetchDownConversionsPerSec is a topic metric while MessageConversionTimeMs is a request metric which indicates Produce/Fetch as a tag. Are you suggesting that we should convert FetchDownConversionsPerSec to a request metric called MessageConversionsPerSec for fetch requests?
2. TemporaryMessageSize for Produce/Fetch would indicate the space allocated for conversions. For other requests, this metric will not be created (unless we find a request where the size is large and this information is useful). Thank you, Rajini On Tue, Sep 5, 2017 at 4:55 PM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks Rajini, +1 (binding) from me. Just a few minor comments: > > 1. FetchDownConversionsPerSec should probably be MessageConversionsPerSec > with a request tag for consistency with MessageConversionsTimeMs. The text > in that paragraph should also be updated to talk about message conversions > instead of down conversions only. > > 2. What will TemporaryMemorySize represent for requests other than > `ProduceRequest`? > > Ismael > > On Mon, Sep 4, 2017 at 2:09 PM, Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > > All the suggestions on the discuss thread have been incorporated into the > > KIP. Please let me know if you have any more concerns or else can we > > proceed with voting for this KIP? > > > > Thank you, > > > > Rajini > > > > On Thu, Aug 24, 2017 at 6:50 PM, Rajini Sivaram <rajinisiva...@gmail.com > > > > wrote: > > > > > Hi all, > > > > > > I would like to start the vote on KIP-188 that adds additional metrics > to > > > support health checks for Kafka Ops. Details are here: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 188+-+Add+new+metrics+to+support+health+checks > > > > > > Thank you, > > > > > > Rajini > > > > > > > > >
