[jira] [Assigned] (KAFKA-4916) Add streams tests with brokers failing

[ https://issues.apache.org/jira/browse/KAFKA-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eno Thereska reassigned KAFKA-4916: --- Assignee: Eno Thereska > Add streams tests with brokers failing > ---

[GitHub] kafka pull request #2709: MINOR: Map `mkString` format updated to default ja...

GitHub user Kamal15 opened a pull request: https://github.com/apache/kafka/pull/2709 MINOR: Map `mkString` format updated to default java format This is a minor change but it helps to improve the log readability. You can merge this pull request into a Git repository by running:

[jira] [Updated] (KAFKA-4920) Stamped should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Juchli updated KAFKA-4920: --- Description: We ran FundBug, which resulted in the "Bad practice warning": Bug type EQ_COMPARETO_USE

[jira] [Updated] (KAFKA-4920) Stamped should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Juchli updated KAFKA-4920: --- Description: We ran FundBug, which resulted in the "Bad practice warning": `Bug type EQ_COMPARETO_USE

[jira] [Created] (KAFKA-4920) Stamped should implement equals

Marc Juchli created KAFKA-4920: -- Summary: Stamped should implement equals Key: KAFKA-4920 URL: https://issues.apache.org/jira/browse/KAFKA-4920 Project: Kafka Issue Type: Improvement C

[jira] [Updated] (KAFKA-4920) Stamped should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Juchli updated KAFKA-4920: --- Description: We ran FundBug, which resulted in the "Bad practice warning": ```Bug type EQ_COMPARETO_U

[jira] [Created] (KAFKA-4921) AssignedPartition should implement equals

Marc Juchli created KAFKA-4921: -- Summary: AssignedPartition should implement equals Key: KAFKA-4921 URL: https://issues.apache.org/jira/browse/KAFKA-4921 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-82 - Add Record Headers

Hi Jun, Thanks the comments I’ve updated the KIP a little where agreement. My comments: 1) Good point, removed from the interface. See updated KIP 2) I think, Radai’s suggested header(String key) is a cleaner method name, but happy to change if community believe lastHeader is better. I’ll keep

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Description: Four easy to fix warnings (not a complete set of the current FindBugs warnings) as i

Re: [DISCUSS] KIP-82 - Add Record Headers

Hi Ismael, Sorry, The response below was in regards to your comments, got my wires crossed, apologies. Hi Jun, I’m happy with the change, I see Jason updated our KIP, many thanks for this, and thanks for implementing for us ☺ Cheers Mike On 20/03/2017, 13:19, "Michael Pearce" wrote:

[jira] [Created] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

Daan Rennings created KAFKA-4922: Summary: Fix several FindBugs warnings in Clients and Connect Key: KAFKA-4922 URL: https://issues.apache.org/jira/browse/KAFKA-4922 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Reviewer: Daan Rennings > Fix several FindBugs warnings in Clients and Connect > -

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Reviewer: (was: Daan Rennings) > Fix several FindBugs warnings in Clients and Connect >

[jira] [Commented] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932623#comment-15932623 ] Daan Rennings commented on KAFKA-4922: -- I would like to tackle this issue myself. How

[GitHub] kafka pull request #2710: Fix-KAFKA-4922 - Minor FindBugs warning fixes

GitHub user drennings opened a pull request: https://github.com/apache/kafka/pull/2710 Fix-KAFKA-4922 - Minor FindBugs warning fixes Minor one line adaptations to one bad practice and three performance warnings https://issues.apache.org/jira/browse/KAFKA-4922 You can merge this

Re: [DISCUSS] KIP-132: Augment KStream.print to allow extra parameters in the printed string

Hi Marc, Thanks for the KIP. It mostly looks good to me. The only thing i'd change is using a null argument to use a default mapping. IMO it would be better if the existing print() method delegates to the new one supplying a KeyValueMapper that does the right thing. Thanks, Damian On Sat, 18 Mar

[jira] [Commented] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932680#comment-15932680 ] ASF GitHub Bot commented on KAFKA-4922: --- GitHub user drennings opened a pull request

[jira] [Commented] (KAFKA-4890) State directory being deleted when another thread holds the lock

[ https://issues.apache.org/jira/browse/KAFKA-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932701#comment-15932701 ] Yunus Olgun commented on KAFKA-4890: Happy to help, but I wasn't so helpful this time,

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Flags: Patch > Fix several FindBugs warnings in Clients and Connect >

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Flags: (was: Patch) > Fix several FindBugs warnings in Clients and Connect > ---

[jira] [Updated] (KAFKA-4922) Fix several FindBugs warnings in Clients and Connect

[ https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daan Rennings updated KAFKA-4922: - Status: Patch Available (was: Open) > Fix several FindBugs warnings in Clients and Connect >

Re: [VOTE] KIP-111 Kafka should preserve the Principal generated by the PrincipalBuilder while processing the request received on socket channel, on the broker.

Hi, Mayuresh, One reason to have KafkaPrincipal in ACL is that we can extend it to support group in the future. Have you thought about how to support that in your new proposal? Another reason that we had KafkaPrincipal is simplicity. It can be constructed from a simple string and makes matching e

Re: [DISCUSS] KIP-113: Support replicas movement between log directories

Hi, Dong, Thanks for the update. A few replies inlined below. On Thu, Mar 16, 2017 at 12:28 AM, Dong Lin wrote: > Hey Jun, > > Thanks for your comment! Please see my reply below. > > On Wed, Mar 15, 2017 at 9:45 PM, Jun Rao wrote: > > > Hi, Dong, > > > > Thanks for the reply. > > > > 10. Could

[VOTE] KIP-124: Request rate quotas

I would like to initiate the voting process for KIP-124: https://cwiki.apache.org/confluence/display/KAFKA/KIP-124+-+Request+rate+quotas The KIP proposes to add request processing time quota to limit CPU utilization at **, ** or ** levels similar to the current bandwidth limiting quotas. The quot

[GitHub] kafka pull request #2711: Stamped implements equals

GitHub user backender opened a pull request: https://github.com/apache/kafka/pull/2711 Stamped implements equals Solves: [KAFKA-4920](https://issues.apache.org/jira/browse/KAFKA-4920) Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) In class org.apache.kafka.stream

[jira] [Commented] (KAFKA-4920) Stamped should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932840#comment-15932840 ] ASF GitHub Bot commented on KAFKA-4920: --- GitHub user backender opened a pull request

[GitHub] kafka pull request #2712: KAFKA-4921: AssignedPartition implements equals

GitHub user backender opened a pull request: https://github.com/apache/kafka/pull/2712 KAFKA-4921: AssignedPartition implements equals Solves: [KAFKA-4921](https://issues.apache.org/jira/browse/KAFKA-4921) Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) In cl

[jira] [Commented] (KAFKA-4921) AssignedPartition should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932859#comment-15932859 ] ASF GitHub Bot commented on KAFKA-4921: --- GitHub user backender opened a pull request

[GitHub] kafka pull request #2713: KAFKA-4863: [Follow Up] Querying window store may ...

GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/2713 KAFKA-4863: [Follow Up] Querying window store may return unwanted keys iterate over all keys returned from the rocksdb iterator so we don't miss any results You can merge this pull request into a Git

[jira] [Commented] (KAFKA-4863) Querying window store may return unwanted keys

[ https://issues.apache.org/jira/browse/KAFKA-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932980#comment-15932980 ] ASF GitHub Bot commented on KAFKA-4863: --- GitHub user dguy opened a pull request:

[GitHub] kafka pull request #2714: Fix ZKSec Migrate example

GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2714 Fix ZKSec Migrate example Incorrect option in example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala#L71 You can merge this pull re

Re: [DISCUSS] KIP-113: Support replicas movement between log directories

Hey Jun, Thanks for the response! It seems that we have only two remaining issues. Please see my reply below. On Mon, Mar 20, 2017 at 7:45 AM, Jun Rao wrote: > Hi, Dong, > > Thanks for the update. A few replies inlined below. > > On Thu, Mar 16, 2017 at 12:28 AM, Dong Lin wrote: > > > Hey Jun,

Re: [DISCUSS] KIP-132: Augment KStream.print to allow extra parameters in the printed string

Sound reasonable Damian, but I guess, that's more a PR than KIP discussion. @Marc, I guess you can start a VOTE thread if there is no further feedback. -Matthias On 3/20/17 7:06 AM, Damian Guy wrote: > Hi Marc, > > Thanks for the KIP. It mostly looks good to me. The only thing i'd change > is

[VOTE] KIP-129: Kafka Streams Exactly-Once Semantics

Hi, I would like to start the vote for KIP-129. Of course, feel free to provide some more feedback on the DISCUSS thread. Thanks a lot! -Matthias signature.asc Description: OpenPGP digital signature

Re: [DISCUSS] KIP-120: Cleanup Kafka Streams builder API

I want to push this discussion further. Guozhang's argument about "exposing" the Topology class is valid. It's a public class anyway, so it's not as issue. However, I think the question is not too much about exposing but about "advertising" (ie, putting it into the focus) or not at DSL level. If

Re: Re: [DISCUSS] KIP-120: Cleanup Kafka Streams builder API

Hmm, I must admit I don't like this last update all too much. Basically we would have: StreamsBuilder builder = new StreamsBuilder(); // And here you'd define your...well, what actually? // Ah right, you are composing a topology here, though you are not aware of it. KafkaStreams

[jira] [Commented] (KAFKA-4862) Kafka client connect to a shutdown node will block for a long time

[ https://issues.apache.org/jira/browse/KAFKA-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933400#comment-15933400 ] Colin P. McCabe commented on KAFKA-4862: +1 for adding a configurable connect() ti

[jira] [Created] (KAFKA-4923) Add Exactly-Once Semantics

Matthias J. Sax created KAFKA-4923: -- Summary: Add Exactly-Once Semantics Key: KAFKA-4923 URL: https://issues.apache.org/jira/browse/KAFKA-4923 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-4924) Fix findbugs warnings in Kafka-Connect-API

Colin P. McCabe created KAFKA-4924: -- Summary: Fix findbugs warnings in Kafka-Connect-API Key: KAFKA-4924 URL: https://issues.apache.org/jira/browse/KAFKA-4924 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-4924) Fix findbugs warnings in Kafka-Connect-API

[ https://issues.apache.org/jira/browse/KAFKA-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933506#comment-15933506 ] Colin P. McCabe commented on KAFKA-4924: * {{connect/api/src/main/java/org/apache/

[GitHub] kafka pull request #2715: KAFKA-4924: Fix Kafka Connect API findbugs warning...

GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/2715 KAFKA-4924: Fix Kafka Connect API findbugs warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka KAFKA-4924 Alternatively you

[jira] [Commented] (KAFKA-4924) Fix findbugs warnings in Kafka-Connect-API

[ https://issues.apache.org/jira/browse/KAFKA-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933507#comment-15933507 ] ASF GitHub Bot commented on KAFKA-4924: --- GitHub user cmccabe opened a pull request:

[jira] [Resolved] (KAFKA-4894) Fix findbugs "default character set in use" warnings

[ https://issues.apache.org/jira/browse/KAFKA-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-4894. Resolution: Fixed Fix Version/s: 0.11.0.0 Issue resolved by pull request 2683 [https://github.com/apa

[GitHub] kafka pull request #2683: KAFKA-4894. Fix findbugs "default character set in...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (KAFKA-4894) Fix findbugs "default character set in use" warnings

[ https://issues.apache.org/jira/browse/KAFKA-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933523#comment-15933523 ] ASF GitHub Bot commented on KAFKA-4894: --- Github user asfgit closed the pull request

Re: [DISCUSS] KIP-132: Augment KStream.print to allow extra parameters in the printed string

Hi Marc, Could you add more information in the motivation of the KIP as to what problems this would solve? I can see how it can be done, but I don't yet grok why it's useful. The KIP should contain more pain points/problems and pose this as a solution. I know it's a small modification, but it's

Re: [DISCUSS] KIP-129: Kafka Streams Exactly-Once Semantics

Hi Matthias, I'd like to see some more info on how you propose to handle transactions that involve state stores in the KIP itself. The design doc has info about various optimisations like RocksDb snapshots and transactions and such, but will there be a user-visible interface that indicates whet

Build failed in Jenkins: kafka-trunk-jdk7 #2024

See Changes: [junrao] KAFKA-4894; Fix findbugs "default character set in use" warnings -- [...truncated 856.72 KB...] org.apache.kafka.streams.integration.KStreamsFineGrai

[jira] [Commented] (KAFKA-4921) AssignedPartition should implement equals

[ https://issues.apache.org/jira/browse/KAFKA-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933935#comment-15933935 ] Matthias J. Sax commented on KAFKA-4921: I am not sure if we need this. {{StreamPa

[jira] [Commented] (KAFKA-2729) Cached zkVersion not equal to that in zookeeper, broker not recovering.

[ https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933991#comment-15933991 ] Ronghua Lin commented on KAFKA-2729: [~junrao], we also have this problem in a small c

Build failed in Jenkins: kafka-trunk-jdk8 #1361

See Changes: [junrao] KAFKA-4894; Fix findbugs "default character set in use" warnings -- [...truncated 1.46 MB...] org.apache.kafka.streams.state.internals.RocksDBKeyValu

[jira] [Assigned] (KAFKA-4750) KeyValueIterator returns null values

[ https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-4750: --- Assignee: Kamal Chandraprakash > KeyValueIterator returns null values > -

[GitHub] kafka pull request #2642: KAFKA-4848: Fix retryWithBackoff deadlock issue

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2642 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (KAFKA-4848) Stream thread getting into deadlock state while trying to get rocksdb lock in retryWithBackoff

[ https://issues.apache.org/jira/browse/KAFKA-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934096#comment-15934096 ] ASF GitHub Bot commented on KAFKA-4848: --- Github user asfgit closed the pull request

[jira] [Resolved] (KAFKA-4848) Stream thread getting into deadlock state while trying to get rocksdb lock in retryWithBackoff

[ https://issues.apache.org/jira/browse/KAFKA-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-4848. -- Resolution: Fixed Fix Version/s: 0.11.0.0 > Stream thread getting into deadlock state whi

Build failed in Jenkins: kafka-trunk-jdk7 #2025

See Changes: [wangguoz] KAFKA-4848: Fix retryWithBackoff deadlock issue -- [...truncated 163.82 KB...] kafka.producer.ProducerTest > testSendNullMessage STARTED kafka.pr