[ 
https://issues.apache.org/jira/browse/KAFKA-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932680#comment-15932680
 ] 

ASF GitHub Bot commented on KAFKA-4922:
---------------------------------------

GitHub user drennings opened a pull request:

    https://github.com/apache/kafka/pull/2710

    Fix-KAFKA-4922 - Minor FindBugs warning fixes

    Minor one line adaptations to one bad practice and three performance 
warnings
    https://issues.apache.org/jira/browse/KAFKA-4922

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/delftswa2017/kafka fix-KAFKA-4922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2710
    
----
commit 5fcc4584d2f325034eb1e6e8708bd7db2dabb08b
Author: Steven Schlansker <sschlans...@opentable.com>
Date:   2017-02-16T05:19:15Z

    KAFKA-2740: Add a KStream#peek(ForeachAction<K, V>) in DSL
    
    https://issues.apache.org/jira/browse/KAFKA-4720
    
    Peek is a handy method to have to insert diagnostics that do not affect the 
stream itself, but some external state such as logging or metrics collection.
    
    Author: Steven Schlansker <sschlans...@opentable.com>
    
    Reviewers: Damian Guy, Matthias J. Sax, Eno Thereska, Guozhang Wang
    
    Closes #2493 from stevenschlansker/kafka-4720-peek

commit 6a6f488108a5b89f694f2c40b2d18b279c248d85
Author: daan rennings <daanrenni...@hotmail.com>
Date:   2017-03-20T13:37:19Z

    Fixed adherence to java.lang.Object.equals in Bytes.java

commit a4c83ec0b286ddc813d13951b57cccda6e5a4d98
Author: daan rennings <daanrenni...@hotmail.com>
Date:   2017-03-20T13:43:48Z

    Fixed boxed primitive in Decimal.java

commit 92342a953c006a997180ebb6289249e390dc8c47
Author: daan rennings <daanrenni...@hotmail.com>
Date:   2017-03-20T13:48:21Z

    Fixed two boxed primitives in Worker.java

commit 6c38737049c4eaedfad3cfb87fc227825402f315
Author: daan rennings <daanrenni...@hotmail.com>
Date:   2017-03-20T13:51:08Z

    Fixed boxed primitive in ConnectorTaskId.java

----


> Fix several FindBugs warnings in Clients and Connect
> ----------------------------------------------------
>
>                 Key: KAFKA-4922
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4922
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, KafkaConnect
>    Affects Versions: 0.10.2.0
>         Environment: Identified by FindBugs, non-software and -platform 
> specific
>            Reporter: Daan Rennings
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10.2.1
>
>         Attachments: ClientsFindBugsReport.html, 
> ConnectAPIFindBugsReport.html, ConnectRuntimeFindBugsReport.html
>
>
> Four easy to fix warnings (not a complete set of the current FindBugs 
> warnings) as identified by FindBugs and stated in the attached reports:
> -org.apache.kafka.common.utils.Bytes.equals(Object) does not check for null 
> argument (Low priority, Bad Practice)
> -Primitive boxed just to call toString in 
> org.apache.kafka.connect.data.Decimal.builder(int) (High Priority, 
> Performance)
> -Primitive boxed just to call toString in new 
> org.apache.kafka.connect.runtime.Worker(String, Time, ConnectorFactory, 
> WorkerConfig, OffsetBackingStore) (High Priority, Performance)
> -Primitive is boxed to call Integer.compareTo(Integer): use 
> Integer.compare(int, int) instead (High Priority, Performance)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to