[ 
https://issues.apache.org/jira/browse/KAFKA-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933935#comment-15933935
 ] 

Matthias J. Sax commented on KAFKA-4921:
----------------------------------------

I am not sure if we need this. {{StreamPartitionAssignor}} is never 
hashed/compared or similar. It would add dead code if I am not wrong. Or can 
you point out where equals or hashcode would be called?

> AssignedPartition should implement equals
> -----------------------------------------
>
>                 Key: KAFKA-4921
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4921
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Marc Juchli
>            Priority: Minor
>
> We ran FundBug, which resulted in the "Bad practice warning":
>       
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) 
> In class 
> org.apache.kafka.streams.processor.internals.StreamPartitionAssignor$AssignedPartition
> In method 
> org.apache.kafka.streams.processor.internals.StreamPartitionAssignor$AssignedPartition.compareTo(StreamPartitionAssignor$AssignedPartition)
> At StreamPartitionAssignor.java:[line 75]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to