[jira] [Commented] (KAFKA-4145) Avoid redundant integration testing in ProducerSendTests

2016-09-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479337#comment-15479337 ] ASF GitHub Bot commented on KAFKA-4145: --- Github user asfgit closed the pull request

[GitHub] kafka pull request #1842: KAFKA-4145: Avoid redundant integration testing in...

2016-09-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Updated] (KAFKA-4145) Avoid redundant integration testing in ProducerSendTests

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4145: --- Resolution: Fixed Reviewer: Ismael Juma Fix Version/s: 0.10.1.0 Status: Reso

[jira] [Updated] (KAFKA-4145) Avoid redundant integration testing in ProducerSendTests

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4145: --- Issue Type: Test (was: Improvement) > Avoid redundant integration testing in ProducerSendTests >

Re: [DISCUSS] Kafka 0.10.1.0 Release Plan

2016-09-10 Thread Ismael Juma
Jason, thanks for putting this together and driving the release. Your proposal sounds good to me. It would be nice to create a wiki page with the information in this email. See the following for the one that Gwen put together for 0.10.0: https://cwiki.apache.org/confluence/display/KAFKA/Release+Pl

Re: [VOTE] KIP-78 Cluster Id (second attempt)

2016-09-10 Thread Ismael Juma
+1 from me too. Thanks to everyone that voted and participated in the discussion. The KIP passed with 7 binding +1s (Sriram, Neha, Jason, Guozhang, Gwen, Jun, myself) and 2 non-binding +1s (Rajini, Grant). Ismael On Fri, Sep 9, 2016 at 1:32 AM, Jun Rao wrote: > Thanks for the writeup. +1. > >

[jira] [Updated] (KAFKA-4093) Cluster id

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4093: --- Status: Patch Available (was: Open) > Cluster id > -- > > Key: KAFKA-4093 >

[jira] [Commented] (KAFKA-4093) Cluster id

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479361#comment-15479361 ] Ismael Juma commented on KAFKA-4093: Pull request: https://github.com/apache/kafka/pul

[jira] [Commented] (KAFKA-4093) Cluster id

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479360#comment-15479360 ] Ismael Juma commented on KAFKA-4093: Pull request: https://github.com/apache/kafka/pul

[jira] [Updated] (KAFKA-4093) Cluster id

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4093: --- Fix Version/s: 0.10.1.0 > Cluster id > -- > > Key: KAFKA-4093 >

[jira] [Issue Comment Deleted] (KAFKA-4093) Cluster id

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4093: --- Comment: was deleted (was: Pull request: https://github.com/apache/kafka/pull/1830) > Cluster id > --

Re: [DISCUSS] KIP-79 - ListOffsetRequest v1 and offsetForTime() method in new consumer.

2016-09-10 Thread Ismael Juma
Becket, comments inline. On Fri, Sep 9, 2016 at 6:55 PM, Becket Qin wrote: > Completely agree that we should have a consistent representation of > something missing/unknown in the code. > > My understanding of the convention is that -1 means "not > available"/"unknown". For example, when produce

Re: [DISCUSS] Kafka 0.10.1.0 Release Plan

2016-09-10 Thread Rajini Sivaram
Would it be possible to include KIP-55: Secure Quotas as well? The KIP was approved a while ago and the PR was submitted several weeks ago. I was hoping it would get reviewed in time for the next rel

Build failed in Jenkins: kafka-trunk-jdk7 #1531

2016-09-10 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-4145; Avoid redundant integration testing in ProducerSendTests -- [...truncated 3422 lines...] kafka.network.SocketServerTest > tooBigRequestIsRejected PASSED kafka.

Build failed in Jenkins: kafka-trunk-jdk8 #874

2016-09-10 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-4145; Avoid redundant integration testing in ProducerSendTests -- [...truncated 13777 lines...] org.apache.kafka.connect.runtime.WorkerSinkTaskThreadedTest > testPoll

[jira] [Created] (KAFKA-4149) java.lang.NoSuchMethodError when running streams tests

2016-09-10 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-4149: -- Summary: java.lang.NoSuchMethodError when running streams tests Key: KAFKA-4149 URL: https://issues.apache.org/jira/browse/KAFKA-4149 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-4149) java.lang.NoSuchMethodError when running streams tests

2016-09-10 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479599#comment-15479599 ] Ismael Juma commented on KAFKA-4149: The problem seems to go away if the `jarAll` task

Re: [DISCUSS] KIP-79 - ListOffsetRequest v1 and offsetForTime() method in new consumer.

2016-09-10 Thread Becket Qin
Hi Ismael, Got it. I agree that it is safer to use java.lang.Long instead of primitive long. Returning a null sounds reasonable in our case where performance is not a major concern. I will make the change in the KIP wiki. Regarding the consistency, I am not sure how big impact it would be if we g