Re: Review Request 34766: Patch for KAFKA-2229

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/ --- (Updated June 30, 2015, 1:59 p.m.) Review request for kafka. Bugs: KAFKA-2229

[jira] [Updated] (KAFKA-2229) Phase 1: Requests and KafkaApis

[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2229: Attachment: KAFKA-2229_2015-06-30_16:59:17.patch > Phase 1: Requests and KafkaApis > ---

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608307#comment-14608307 ] Andrii Biletskyi commented on KAFKA-2229: - Updated reviewboard https://reviews.apa

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608309#comment-14608309 ] Andrii Biletskyi commented on KAFKA-2229: - Rebased to include KAFKA-2195. > Phase

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review89677 --- Thanks for the patch. A few comments below. Also, we need to handle

Re: Review Request 35231: Address Onur and Jason's comments

> On June 18, 2015, 12:50 a.m., Jason Gustafson wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 229-236 > > > > > > In manual group management, would we expect consumerId and gene

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608572#comment-14608572 ] Rajasekar Elango commented on KAFKA-1690: - [~harsha_ch] Thanks for working on this

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608583#comment-14608583 ] Sriharsha Chintalapani commented on KAFKA-1690: --- [~erajasekar] you can try t

Re: Review Request 36030: Patch for KAFKA-972

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review89907 --- Thanks for the patch. A few comments below. 1. Could you add a unit

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-972: -- Status: In Progress (was: Patch Available) > MetadataRequest returns stale list of brokers > ---

Re: Review Request 35820: Patch for KAFKA-1367

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review89911 --- Thanks for the patch. A few comments below. Also, could we add a un

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1367: --- Status: In Progress (was: Patch Available) > Broker topic metadata not kept in sync with ZooKeeper >

Re: Review Request 35231: Address Onur and Jason's comments

> On June 18, 2015, 12:50 a.m., Jason Gustafson wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 229-236 > > > > > > In manual group management, would we expect consumerId and gene

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review89919 --- Thanks for the patch. Just a few minor comments below. build.gradl

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review89922 --- I have a few other comments which I can add later or discuss offline

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review89910 --- clients/src/main/java/org/apache/kafka/clients/ClientUtils.java (li

Re: Review Request 34789: Patch for KAFKA-2168

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/ --- (Updated June 30, 2015, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-2168

[jira] [Updated] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2168: --- Attachment: KAFKA-2168_2015-06-30_10:54:22.patch > New consumer poll() can block other calls l

[jira] [Commented] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608743#comment-14608743 ] Jason Gustafson commented on KAFKA-2168: Updated reviewboard https://reviews.apach

[jira] [Commented] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608753#comment-14608753 ] Jason Gustafson commented on KAFKA-2168: [~ewencp], there were some minor issues f

Re: Review Request 33614: Patch for KAFKA-2132

> On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > Thanks for the patch. Just a few minor comments below. Thanks Jun for the review. > On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > build.gradle, lines 389-391 > > > > >

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 30, 2015, 7:07 p.m.) Review request for kafka. Bugs: KAFKA-2132

[jira] [Commented] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608883#comment-14608883 ] Ashish K Singh commented on KAFKA-2132: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2132) Move Log4J appender to a separate module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132_2015-06-30_12:07:23.patch > Move Log4J appender to a separate module > --

Re: Review Request 34494: Patch for KAFKA-2212

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34494/#review89940 --- core/src/main/scala/kafka/admin/AclCommand.scala (line 48)

[jira] [Commented] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609046#comment-14609046 ] Ewen Cheslack-Postava commented on KAFKA-2304: -- Patch works and looks fine to

[jira] [Updated] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated KAFKA-2304: Attachment: KAFKA-2304-JMX.patch Makes sense, changed. Attached updated [^KAFKA-2304-JMX.patch] wit

Re: Review Request 34789: Patch for KAFKA-2168

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review89971 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609220#comment-14609220 ] Michael Sandrof commented on KAFKA-2078: We are experiencing the same issue in tha

Re: Review Request 34789: Patch for KAFKA-2168

> On June 30, 2015, 10:24 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > lines 933-937 > > > > > > Wondering why we want to fetch for all assigned parti

Re: Review Request 35231: Address Onur and Jason's comments

> On June 18, 2015, 12:50 a.m., Jason Gustafson wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 229-236 > > > > > > In manual group management, would we expect consumerId and gene

Re: Review Request 35231: Address Onur and Jason's comments

> On June 18, 2015, 12:50 a.m., Jason Gustafson wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines > > 229-236 > > > > > > In manual group management, would we expect consumerId and gene

Re: Review Request 36030: Patch for KAFKA-972

> On June 30, 2015, 4:14 p.m., Jun Rao wrote: > > Thanks for the patch. A few comments below. > > > > 1. Could you add a unit test for this? > > > > 2. Also, we may have a similar issue when handling the failure of the > > broker. Currently, the logic in the controller is that the controller w

Re: Review Request 36030: Patch for KAFKA-972

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 1, 2015, 1:42 a.m.) Review request for kafka. Bugs: KAFKA-972

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-06-30_18:42:13.patch > MetadataRequest returns stale list of brokers > -

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609426#comment-14609426 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Status: Patch Available (was: In Progress) > MetadataRequest returns stale list of brokers > -

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated July 1, 2015, 2:44 a.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated July 1, 2015, 2:44 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609476#comment-14609476 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard https://reviews.a

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-06-30_19:43:55.patch > Client side protocol changes to return

Re: Review Request 33378: Patch for KAFKA-2136

> On June 25, 2015, 10:55 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 40 > > > > > > I think we should add throttle time metrics to the old producer and > > consumer a

Re: Review Request 36030: Patch for KAFKA-972

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90005 --- Thanks for the patch. A couple more comments. core/src/test/scala/

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609591#comment-14609591 ] Ross Black commented on KAFKA-873: -- A more general mechanism could also support KAFKA-1793