----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review89911 -----------------------------------------------------------
Thanks for the patch. A few comments below. Also, could we add a unit test for this? core/src/main/scala/kafka/common/TopicAndPartition.scala (line 38) <https://reviews.apache.org/r/35820/#comment142801> Perhaps we should add a version field in anticipation for future format evolution. core/src/main/scala/kafka/controller/KafkaController.scala (lines 1302 - 1304) <https://reviews.apache.org/r/35820/#comment142794> This needs to be done while holding a controller lock. core/src/main/scala/kafka/controller/KafkaController.scala (line 1303) <https://reviews.apache.org/r/35820/#comment142795> We should just update the isr cache for partitions that have changed. core/src/main/scala/kafka/controller/KafkaController.scala (line 1307) <https://reviews.apache.org/r/35820/#comment142792> Can this be private? core/src/main/scala/kafka/controller/KafkaController.scala (line 1315) <https://reviews.apache.org/r/35820/#comment142797> Can this be private? core/src/main/scala/kafka/controller/KafkaController.scala (line 1327) <https://reviews.apache.org/r/35820/#comment142799> Could we include the ZK path as well? Also, we probably should just log this as an error and then continue, instead of throwing an exception. core/src/main/scala/kafka/utils/ReplicationUtils.scala (line 44) <https://reviews.apache.org/r/35820/#comment142790> This probably should be debug. - Jun Rao On June 24, 2015, 5:10 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35820/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 5:10 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1367 > https://issues.apache.org/jira/browse/KAFKA-1367 > > > Repository: kafka > > > Description > ------- > > KAFKA-1367: Broker topic metadata not kept in sync with ZooKeeper > > > Diffs > ----- > > core/src/main/scala/kafka/common/TopicAndPartition.scala > df3db912f5daef6a25b4b2dd2220d2cc3795bce6 > core/src/main/scala/kafka/controller/KafkaController.scala > 36350579b16027359d237b64699003358704ac6f > core/src/main/scala/kafka/utils/ReplicationUtils.scala > 60687332b4c9bee4d4c0851314cfb4b02d5d3489 > core/src/main/scala/kafka/utils/ZkUtils.scala > 78475e3d5ec477cef00caeaa34ff2d196466be96 > core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala > c96c0ffd958d63c09880d436b2e5ae96f51ead36 > > Diff: https://reviews.apache.org/r/35820/diff/ > > > Testing > ------- > > Tested on a test cluster with 3 Kafka brokers > > > Thanks, > > Ashish Singh > >
