[jira] [Commented] (KAFKA-2200) kafkaProducer.send() should not call callback.onCompletion()

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591531#comment-14591531 ] Manikumar Reddy commented on KAFKA-2200: In KafkaProducer.send() method, on ApiExc

[jira] [Created] (KAFKA-2284) ConsumerRebalanceListener receives wrong type in partitionOwnership values

2015-06-18 Thread E. Sammer (JIRA)
E. Sammer created KAFKA-2284: Summary: ConsumerRebalanceListener receives wrong type in partitionOwnership values Key: KAFKA-2284 URL: https://issues.apache.org/jira/browse/KAFKA-2284 Project: Kafka

[jira] [Created] (KAFKA-2285) Logging trait destroy call site information

2015-06-18 Thread E. Sammer (JIRA)
E. Sammer created KAFKA-2285: Summary: Logging trait destroy call site information Key: KAFKA-2285 URL: https://issues.apache.org/jira/browse/KAFKA-2285 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread E. Sammer (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] E. Sammer updated KAFKA-2285: - Summary: Logging trait obfuscates call site information (was: Logging trait destroy call site information

Review Request 35610: Patch for KAFKA-2265

2015-06-18 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35610/ --- Review request for kafka. Bugs: KAFKA-2265 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2265: --- Attachment: KAFKA-2265.patch > creating a topic with large number of partitions takes a long t

[jira] [Updated] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2265: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > creating a topic with l

[jira] [Commented] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591963#comment-14591963 ] Manikumar Reddy commented on KAFKA-2265: Created reviewboard https://reviews.apach

[jira] [Commented] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591976#comment-14591976 ] Manikumar Reddy commented on KAFKA-2265: For each partition, we are parsing /brok

[jira] [Comment Edited] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591976#comment-14591976 ] Manikumar Reddy edited comment on KAFKA-2265 at 6/18/15 3:36 PM: ---

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591990#comment-14591990 ] Grant Henke commented on KAFKA-2285: It looks like it's where the call to _logger.*_ i

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-06-18 Thread Jay Kreps
1. We were calling the plugins connectors (which is kind of a generic way to say either source or sink) and the framework copycat. The pro of copycat is it is kind of fun. The con is that it doesn't really say what it does. The Kafka Connector Framework would be a duller but more intuitive name, bu

[jira] [Created] (KAFKA-2286) Cannot produce messages remotely: No partition metadata for topic test due to kafka.common.LeaderNotAvailableException

2015-06-18 Thread Mike Bridge (JIRA)
Mike Bridge created KAFKA-2286: -- Summary: Cannot produce messages remotely: No partition metadata for topic test due to kafka.common.LeaderNotAvailableException Key: KAFKA-2286 URL: https://issues.apache.org/jira/bro

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88131 --- This looks good to me. Just have a minor comment below, and one orth

Review Request 35615: Patch for KAFKA-1782

2015-06-18 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- Review request for kafka. Bugs: KAFKA-1782 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-06-18 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592268#comment-14592268 ] Alexander Pakulov commented on KAFKA-1782: -- Created reviewboard https://reviews.a

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

2015-06-18 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-1782: - Status: Patch Available (was: Open) > Junit3 Misusage > --- > >

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

2015-06-18 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-1782: - Attachment: KAFKA-1782.patch > Junit3 Misusage > --- > > Key:

Re: Review Request 35615: Patch for KAFKA-1782

2015-06-18 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated June 18, 2015, 6:39 p.m.) Review request for kafka. Bugs: KAFKA-1782

Re: Review Request 35615: Patch for KAFKA-1782

2015-06-18 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated June 18, 2015, 6:53 p.m.) Review request for kafka. Bugs: KAFKA-1782

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

2015-06-18 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-1782: - Attachment: KAFKA-1782_2015-06-18_11:52:49.patch > Junit3 Misusage > --- > >

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-06-18 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592310#comment-14592310 ] Alexander Pakulov commented on KAFKA-1782: -- Updated reviewboard https://reviews.a

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread E. Sammer (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592390#comment-14592390 ] E. Sammer commented on KAFKA-2285: -- The if guard isn't the issue. Any invocation of a log

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592415#comment-14592415 ] Grant Henke commented on KAFKA-2285: I agree. My suggestion was a way to move the call

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-06-18 Thread Otis Gospodnetic
Just a comment on the name. KopyKat? More unique, easy to write, pronounce, remember... Otis > On Jun 18, 2015, at 13:36, Jay Kreps wrote: > > 1. We were calling the plugins connectors (which is kind of a generic way > to say either source or sink) and the framework copycat. The pro of copy

[jira] [Updated] (KAFKA-2249) KafkaConfig does not preserve original Properties

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2249: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Resolved] (KAFKA-2279) add a main method in LogConfig to generate topic level configs in html

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2279. Resolution: Implemented Fix Version/s: 0.8.3 This is already fixed in KAFKA-2249. > add a main metho

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2210: --- Status: In Progress (was: Patch Available) [~parth.brahmbhatt], KAFKA-2249 is now committed. Could you rebase

[jira] [Commented] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

2015-06-18 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592582#comment-14592582 ] Jason Gustafson commented on KAFKA-2168: Updated reviewboard https://reviews.apach

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/ --- (Updated June 18, 2015, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-2168

[jira] [Updated] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

2015-06-18 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2168: --- Attachment: KAFKA-2168_2015-06-18_14:39:36.patch > New consumer poll() can block other calls l

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review88441 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

[jira] [Reopened] (KAFKA-2249) KafkaConfig does not preserve original Properties

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reopened KAFKA-2249: [~gwenshap], with this patch, an issue that I realized is that we print out the configs in LogConfig for every

Re: [DISCUSS] KIP-26 - Add Copycat, a connector framework for data import/export

2015-06-18 Thread Jay Kreps
I think the only problem we came up with was that Kafka KopyKat abbreviates as KKK which is not ideal in the US. Copykat would still be googlable without that issue. :-) -Jay On Thu, Jun 18, 2015 at 1:20 PM, Otis Gospodnetic < otis.gospodne...@gmail.com> wrote: > Just a comment on the name. Kopy

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Ewen Cheslack-Postava
> On June 18, 2015, 9:59 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1364 > > > > > > This seems like one of these things that is clever but inva

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Jason Gustafson
> On June 18, 2015, 9:59 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1364 > > > > > > This seems like one of these things that is clever but inva

[jira] [Updated] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2265: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. This is great finding

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review88451 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

[jira] [Updated] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2234: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88462 --- Ship it! (Discussed comments offline with Onur) - Joel Koshy On

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Jason Gustafson
> On June 18, 2015, 11:13 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1379 > > > > > > This doesn't handle nested calls properly, e.g

[jira] [Commented] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592757#comment-14592757 ] Jun Rao commented on KAFKA-2234: The patch introduced a unit test failure. Checked in a tr

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-18 Thread Ewen Cheslack-Postava
> On June 18, 2015, 11:13 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1379 > > > > > > This doesn't handle nested calls properly, e.g

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 --- Thanks for the patch. A couple of comments below. core/src/main/sc

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2012: --- Status: In Progress (was: Patch Available) > Broker should automatically handle corrupt index files > ---

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-06-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1758: --- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.3 Status: Resolved

Re: Review Request 33204: Patch for KAFKA-1646 Fix2TestCasesAndLogClean

2015-06-18 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 19, 2015, 5:55 a.m.) Review request for kafka. Summary (updated

Re: Review Request 33204: Improve 1646 fix by add log.preallocate

2015-06-18 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 19, 2015, 5:56 a.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150618_225612.patch > Improve consumer read performance for Windows > -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593050#comment-14593050 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 33204: Improve 1646 fix by add log.preallocate

2015-06-18 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 19, 2015, 6:53 a.m.) Review request for kafka. Bugs: KAFKA-1646

[jira] [Resolved] (KAFKA-1465) kafka-reassign-partitions.sh fails when topic name contains dash/hyphen

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1465. Resolution: Fixed Fix Version/s: 0.8.3 Not able to reproduce this issue on trunk. Mig

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150618_235231.patch > Improve consumer read performance for Windows > -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593116#comment-14593116 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150618_225612.patch) > Improve consumer read performance for Wind

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

2015-06-18 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593116#comment-14593116 ] Honghai Chen edited comment on KAFKA-1646 at 6/19/15 6:57 AM: --