-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
-----------------------------------------------------------
(Updated June 18, 2015, 6:39 p.m.)
Review request for kafka.
Bugs: KAFKA-1782
https://issues.apache.org/jira/browse/KAFKA-1782
Repository: kafka
Description (updated)
-------
KAFKA-1782; Junit3 Misusage
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/Metadata.java
07f1cdb1fe920b0c7a5f2d101ddc40c689e1b247
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
1e905240e7459a4a0a0573ae5d8ac19217cae197
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
d1d1ec178f60dc47d408f52a89e52886c1a093a2
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
c1496a0851526f3c7d3905ce4bdff2129c83a6c1
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
e66491cc82f11641df6516e7d7abb4a808c27368
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
07e65d4a54ba4eef5b787eba3e71cbe9f6a920bd
clients/src/main/java/org/apache/kafka/common/network/Selector.java
effb1e63081ed2c1fff6d08d4ecdf8a3cb43e40a
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
5e5308ec0e333179a9abbf4f3b750ea25ab57967
clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataRequest.java
04b90bfe62456a6739fe0299f1564dbd1850fe58
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
8686d83aa52e435c6adafbe9ff4bd1602281072a
clients/src/main/java/org/apache/kafka/common/requests/HeartbeatRequest.java
51d081fa296fd7c170a90a634d432067afcfe772
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java
6795682258e6b329cc3caa245b950b4dbcf0cf45
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java
8d418cd24cf6d105e9687a4a2492b8ed13738338
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetRequest.java
19267ee8aad5a2f5a84cecd6fc563f00329d5035
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
7e0ce159a2ddd041fc06116038bd5831bbca278b
clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java
44e2ce61899889601b6aee71fa7f7ddb4a65a255
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java
8bf6cbb79a92b0878096e099ec9169d21e6d7023
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
deec1fa480d5a5c5884a1c007b076aa64e902472
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java
fabeae3083a8ea55cdacbb9568f3847ccd85bab4
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
928087d29deb80655ca83726c1ebc45d76468c1f
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java
b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb
clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java
6372f1a7f7f77d96ba7be05eb927c004f7fefb73
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
d23b4b6a7060eeefa9f47f292fd818c881d789c1
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
e3cc1967e407b64cc734548c19e30de700b64ba8
clients/src/test/java/org/apache/kafka/test/MockSerializer.java
e75d2e4e58ae0cdbe276d3a3b652e47795984791
core/src/main/scala/kafka/cluster/EndPoint.scala
e9008e6d758be04bebe3cc70952c13dc55dc58fb
core/src/main/scala/kafka/log/LogConfig.scala
a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/network/RequestChannel.scala
357d8b97cb336857500213efade77950833c2096
core/src/main/scala/kafka/server/DelayedOperation.scala
123078d97a7bfe2121655c00f3b2c6af21c53015
core/src/main/scala/kafka/server/KafkaApis.scala
d63bc18d795a6f0e6994538ca55a9a46f7fb8ffd
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
b31b432a226ba79546dd22ef1d2acbb439c2e9a3
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
f56096b826bdbf760411a54ba067a6a83eca8a10
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
17b17b9b1520c7cc2e2ba96cdb1f9ff06e47bcad
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
07b1ff47bfc3cd3f948c9533c8dc977fa36d996f
core/src/test/scala/integration/kafka/api/ProducerBounceTest.scala
ce70a0a449883723a9b59ea48da34ba30b3f6daf
core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala
83de81cb3f79a6966dd5ef462733d8a22cd6d467
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
ee94011894b46864614b97bbd2a98375a7d3f20b
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala
9ce4bd5ee130ce3cb252b2883a3fd3c9acd742a5
core/src/test/scala/unit/kafka/KafkaConfigTest.scala
4cb92de169d465ccdafb8c24b5b46b0f259c8e43
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
df5c6ba20f01e497ce896af790cbab40369f1776
core/src/test/scala/unit/kafka/admin/AdminTest.scala
efb2f8e79b3faef78722774b951fea828cd50374
core/src/test/scala/unit/kafka/admin/DeleteConsumerGroupTest.scala
1913ad6d3e6eb29a0c939c4f59f6b688c8c925fa
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
fa8ce259a2832ab86f9dda8c1d409b2c42d43ae9
core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
c7136f20972614ac47aa57ab13e3c94ef775a4b7
core/src/test/scala/unit/kafka/api/ApiUtilsTest.scala
255442526d94157b7a0b5a92e1d6a900aacb7536
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
5717165f2344823fabe8f7cfafae4bb8af2d949a
core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala
bb2506ca186bb2e5a606263fb0c50ae95769ff68
core/src/test/scala/unit/kafka/common/ConfigTest.scala
7bff96caca1dc715a81b48cec84cb3c163f7faa3
core/src/test/scala/unit/kafka/common/TopicTest.scala
0fb25880c24adef906cd06359b624e7c8eb94ca6
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala
db5302ff02851f9f1a59419b1e071286bff0e142
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala
1910fcbfb4353fa6adba0ba125c49f1aa8132770
core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala
4f124af5c3e946045a78ad1519c37372a72c8985
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
359b0f5d14f82d14ee423cde271bb35b7034766d
core/src/test/scala/unit/kafka/coordinator/ConsumerGroupMetadataTest.scala
b69c993a3fa49f7f01dd28e13ce465c2a89eeba5
core/src/test/scala/unit/kafka/coordinator/CoordinatorMetadataTest.scala
08854c5e6ec249368206298b2ac2623df18f266a
core/src/test/scala/unit/kafka/coordinator/PartitionAssignorTest.scala
887cee5a582b5737ba838920399bb9b24bf22382
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala
139dc9a104c024e35fd9bc5ac9333e6bd208b571
core/src/test/scala/unit/kafka/integration/FetcherTest.scala
facebd8f81c67f26f41a96bce343227bc9b55893
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala
87c631573aa1e0275d6618c4ac3b33e76fa6abd3
core/src/test/scala/unit/kafka/integration/MinIsrConfigTest.scala
70a5b3aa00a1f647f23ad353b8b1fb1ece020505
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
6a758a7db71bdc4794b1e5f264f8ca6d410ff2ba
core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala
4614a922e739098dbb0ff560d831e26045e32023
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala
12d0733f5edf436315f884bc193da533d9d4a4ee
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
995b05901491bb0dbf0df210d44bd1d7f66fdc82
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
e4bf2df48dd59a251b646b7f96d63ec4b924fc0b
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala
74c761dec7afc98667032bdec8359a9aa7c2ecc2
core/src/test/scala/unit/kafka/javaapi/message/BaseMessageSetTestCases.scala
726399e3c7a4157223b5037ff2a03da51236e876
core/src/test/scala/unit/kafka/javaapi/message/ByteBufferMessageSetTest.scala
383fcef02994fde07e669651e522b9e5ee239dd8
core/src/test/scala/unit/kafka/log/CleanerTest.scala
8b8249a35322a60ca94cb385a6cad25943dd1cc9
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
471ddff9bff1bdfa277c071e59e5c6b749b9c74f
core/src/test/scala/unit/kafka/log/LogConfigTest.scala
f3546adee490891e0d8d0214bef00b1dd7f42227
core/src/test/scala/unit/kafka/log/LogManagerTest.scala
01dfbc4f8d21f6905327cd4ed6c61d657adc0143
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
03fb3512c4a4450eac83d4cd4b0919baeaa22942
core/src/test/scala/unit/kafka/log/LogTest.scala
8e095d652851f05365e1d3bbe3e9e1c3345b7a40
core/src/test/scala/unit/kafka/log/OffsetIndexTest.scala
9213a5d9e95d0a5f3009b2cf50baa99765e4cfef
core/src/test/scala/unit/kafka/log/OffsetMapTest.scala
12ce39e665afd4cb1d8aa8d7d4d7df18b219a141
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala
41366a14590d318fced0e83d6921d8035fa882da
core/src/test/scala/unit/kafka/message/BaseMessageSetTestCases.scala
dd8847f5f709a0a7b2e7037d5beda9a0dfc054d6
core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala
07bc317bcd40cf40fbff1cbd5039672508f293d9
core/src/test/scala/unit/kafka/message/MessageCompressionTest.scala
76987d4fa68fd39cf0ce6bc47b05eb32b17bbedb
core/src/test/scala/unit/kafka/message/MessageTest.scala
11c0f817ca06e4a53bce1009ad6a36aa007cf93a
core/src/test/scala/unit/kafka/message/MessageWriterTest.scala
b08a3432ad1ae49372e4b6cea9b247f6be2889da
core/src/test/scala/unit/kafka/metrics/KafkaTimerTest.scala
7df74050f99567395d4d01c1600ca77cd917652e
core/src/test/scala/unit/kafka/metrics/MetricsTest.scala
b42101b85fa4aa6a2249e7b04ec0f61e51c81c3f
core/src/test/scala/unit/kafka/network/SocketServerTest.scala
7dc2fad542ea553ee888543dd215eb41ea57d509
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
be4bb878dc49f05caf55b36e9218ed19b1c56253
core/src/test/scala/unit/kafka/producer/ProducerTest.scala
4d2536b462c030f4f269bad024847839e63337c2
core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
8c3fb7a393db019a29b284b26670f63c25d6a4c6
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala
e899b023b3153542f481b82e92b258e4595b23dc
core/src/test/scala/unit/kafka/server/DelayedOperationTest.scala
f3ab3f4ff8eb1aa6b2ab87ba75f72eceb6649620
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala
7877f6ca1845c2edbf96d4a9783a07a552db8f07
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
60cd8249e6ec03349e20bb0a7226ea9cd66e6b17
core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala
90529faf11dca65c3ef6bcb27ad72557bc36f939
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala
ace6321b36d809946554d205bc926c9c76a43bd6
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
2428dbd7197a58cf4cad42ef82b385dab3a2b15e
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
f1977d850a5bf1125260949101fa3485b29bd4e6
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala
e57c1dec2dee4b9a64ffe5906d12676fd877319b
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
7688f26fe42c4481fe2da7a1d50459805be0ebc1
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
528525b719ec916e16f8b3ae3715bec4b5dcc47d
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala
a3a03db88c4c3b2949c4ff7f26f2f00498884b18
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
12269cde06aab953dcd898821a8afaa5c4290e77
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
95534e36c29023565fedf6bf0fe537ef270c2420
core/src/test/scala/unit/kafka/server/ServerStartupTest.scala
60e10b3d5adda152a01425d98d45ca373a63bebd
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
09a0961f73969aca3b054ed3ff6b181a6500364a
core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala
fe8d2aeb642bc075b65ae19d3c85ef4b3f00104a
core/src/test/scala/unit/kafka/utils/CommandLineUtilsTest.scala
e832a0179c721546abc725d8b1ee5d78fccdad1f
core/src/test/scala/unit/kafka/utils/IteratorTemplateTest.scala
fbd245cad0afab146354fdcc76193d784e1997d9
core/src/test/scala/unit/kafka/utils/JsonTest.scala
93550e8f24071f88eb1ea5b41373efee27e4b8b7
core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala
c96c0ffd958d63c09880d436b2e5ae96f51ead36
core/src/test/scala/unit/kafka/utils/SchedulerTest.scala
cfea63b88e2590cbd7a1e7cb2c8cacf054bd5568
core/src/test/scala/unit/kafka/utils/TestUtils.scala
17e9fe4c159a29033fe9a287db6ced2fdc3fa9d1
core/src/test/scala/unit/kafka/utils/timer/TimerTaskListTest.scala
052aecdc32ae14afe6aabf942ed7c0028ed9f979
core/src/test/scala/unit/kafka/utils/timer/TimerTest.scala
8507592d1f374248cc7f56ef786544562ca8ad9c
core/src/test/scala/unit/kafka/zk/ZKEphemeralTest.scala
2be161985657293e83a3fd4d3d15faa30e9a119e
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala
64c3ba28614a94f7126aa5ec5fa1f99845f45259
core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala
1f4d10d25ab3b907689ead7701d2c868ba703952
system_test/system_test_runner.py 5078d4479fab71722751a28c3c8f5c0f61baadec
Diff: https://reviews.apache.org/r/35615/diff/
Testing
-------
Thanks,
Alexander Pakulov
