----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 -----------------------------------------------------------
Thanks for the patch. A couple of comments below. core/src/main/scala/kafka/log/Log.scala (line 178) <https://reviews.apache.org/r/35503/#comment141004> Is this correct? The mmapping of the index file happens in the initialization of OffsetIndex. It seems that we need to re-create the LogSegment after the index file is deleted. core/src/main/scala/kafka/log/Log.scala (lines 225 - 227) <https://reviews.apache.org/r/35503/#comment141005> Do we still need this now that we have verified the index consistency earlier? - Jun Rao On June 16, 2015, 9:57 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35503/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 9:57 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2012 > https://issues.apache.org/jira/browse/KAFKA-2012 > > > Repository: kafka > > > Description > ------- > > handle corrupt index files during server startup > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 > core/src/test/scala/unit/kafka/log/LogTest.scala > 8e095d652851f05365e1d3bbe3e9e1c3345b7a40 > > Diff: https://reviews.apache.org/r/35503/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
