Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20370/ --- Review request for kafka. Bugs: KAFKA-1323 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1323: - Attachment: KAFKA-1323.patch > log.dirs server property no longer supports relative directories >

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969698#comment-13969698 ] Guozhang Wang commented on KAFKA-1323: -- Created reviewboard https://reviews.apache.or

Re: Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20370/ --- (Updated April 15, 2014, 4:36 p.m.) Review request for kafka. Bugs: KAFKA-132

[jira] [Assigned] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1362: - Assignee: Joel Koshy Will upload a patch today. > Publish sources and javadoc jars > ---

Review Request 20372: Patch for KAFKA-1390

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20372/ --- Review request for kafka. Bugs: KAFKA-1390 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1390) TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs

[ https://issues.apache.org/jira/browse/KAFKA-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969769#comment-13969769 ] Jun Rao commented on KAFKA-1390: Created reviewboard https://reviews.apache.org/r/20372/

[jira] [Updated] (KAFKA-1390) TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs

[ https://issues.apache.org/jira/browse/KAFKA-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1390: --- Attachment: KAFKA-1390.patch > TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs > --

Re: Review Request 20372: Patch for KAFKA-1390

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20372/#review40411 --- Ship it! Apply patch: passed Unit test: passed Minor comments belo

Re: Review Request 20050: Fix KAFKA-1359: incorporate Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review40433 --- The first question is whether we should we centralize all the metric

[jira] [Commented] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969911#comment-13969911 ] Balaji Seshadri commented on KAFKA-1365: I can help fix this as its happening for

[jira] [Comment Edited] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969911#comment-13969911 ] Balaji Seshadri edited comment on KAFKA-1365 at 4/15/14 7:02 PM: ---

Review Request 20376: Publish source jars and javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/ --- Review request for kafka. Bugs: KAFKA-1362 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969975#comment-13969975 ] Joel Koshy commented on KAFKA-1362: --- Created reviewboard https://reviews.apache.org/r/20

[jira] [Updated] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1362: -- Attachment: KAFKA-1362.patch > Publish sources and javadoc jars > > >

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969978#comment-13969978 ] Joel Koshy commented on KAFKA-1362: --- The above patch should apply to trunk as well, but

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970024#comment-13970024 ] Andrew Olson commented on KAFKA-493: Due to some concerns about partition count scalabi

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970049#comment-13970049 ] Jay Kreps commented on KAFKA-493: - Hmm, this definitely sounds like a bug. > High CPU usag

[jira] [Updated] (KAFKA-1395) fix AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1395: --- Summary: fix AutoOffsetResetTest (was: fix ServerShutdownTest.testCleanShutdownWithDeleteTopicEnabled) > fi

[jira] [Created] (KAFKA-1395) fix ServerShutdownTest.testCleanShutdownWithDeleteTopicEnabled

Jun Rao created KAFKA-1395: -- Summary: fix ServerShutdownTest.testCleanShutdownWithDeleteTopicEnabled Key: KAFKA-1395 URL: https://issues.apache.org/jira/browse/KAFKA-1395 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1395: --- Summary: fix unit tests in AutoOffsetResetTest (was: fix AutoOffsetResetTest) > fix unit tests in AutoOffse

[jira] [Created] (KAFKA-1396) fix unit test ProducerFailureHandlingTest.testBrokerFailure

Jun Rao created KAFKA-1396: -- Summary: fix unit test ProducerFailureHandlingTest.testBrokerFailure Key: KAFKA-1396 URL: https://issues.apache.org/jira/browse/KAFKA-1396 Project: Kafka Issue Type: Bu

[jira] [Created] (KAFKA-1397) delete topic is not working

Jun Rao created KAFKA-1397: -- Summary: delete topic is not working Key: KAFKA-1397 URL: https://issues.apache.org/jira/browse/KAFKA-1397 Project: Kafka Issue Type: Bug Affects Versions: 0.8.2

[jira] [Resolved] (KAFKA-1390) TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs

[ https://issues.apache.org/jira/browse/KAFKA-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1390. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Jun Rao Thanks for the review. Committed t

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review40262 --- Some general comments: 1. Do we need to take parameters for positio

[jira] [Commented] (KAFKA-1396) fix unit test ProducerFailureHandlingTest.testBrokerFailure

[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970090#comment-13970090 ] Guozhang Wang commented on KAFKA-1396: -- 1. I tried the test several times but cannot

Review Request 20380: Fix KAFKA-1395

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- Review request for kafka. Bugs: KAFKA-1395 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1395: - Attachment: KAFKA-1395.patch > fix unit tests in AutoOffsetResetTest > --

[jira] [Commented] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970114#comment-13970114 ] Guozhang Wang commented on KAFKA-1395: -- Created reviewboard https://reviews.apache.or

Re: Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20370/#review40466 --- Ship it! core/src/test/scala/unit/kafka/server/ReplicaManagerTest.

Review Request 20392: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20392/ --- Review request for kafka. Bugs: KAFKA-1323 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1323: - Attachment: KAFKA-1323.patch > log.dirs server property no longer supports relative directories >

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970174#comment-13970174 ] Guozhang Wang commented on KAFKA-1323: -- Created reviewboard https://reviews.apache.or

Review Request 20393: Fix KAFKA-1323: rebase on 0.8.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20393/ --- Review request for kafka. Bugs: KAFKA-1323 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1323: - Attachment: KAFKA-1323.patch > log.dirs server property no longer supports relative directories >

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970189#comment-13970189 ] Guozhang Wang commented on KAFKA-1323: -- Created reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970191#comment-13970191 ] Guozhang Wang commented on KAFKA-1323: -- Please ignore the RB 20392, that was a messed

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970215#comment-13970215 ] Jay Kreps commented on KAFKA-1359: -- I'm +1 on the 1st patch. I think let's have a separat

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970217#comment-13970217 ] Joel Koshy commented on KAFKA-1323: --- [~guozhang] You can mark that RB as discarded > lo

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970236#comment-13970236 ] Guozhang Wang commented on KAFKA-1323: -- Thanks Joel. Done. > log.dirs server propert

Build failed in Jenkins: Kafka-trunk #165

See Changes: [junrao] kafka-1390; TestUtils.waitUntilLeaderIsElectedOrChanged may wait longer than it needs; patched by Jun Rao; reviewed by Guozhang Wang -- [...truncated 332 lines...] kafka.log.Lo

[jira] [Created] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

Joel Koshy created KAFKA-1398: - Summary: Topic config changes can be lost and cause fatal exceptions on broker restarts Key: KAFKA-1398 URL: https://issues.apache.org/jira/browse/KAFKA-1398 Project: Kafka

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970323#comment-13970323 ] Joel Koshy commented on KAFKA-1380: --- Adding another issue we just ran into. I think this

Re: Review Request 20376: Publish source jars and javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40490 --- build.gradle

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970367#comment-13970367 ] Joe Stein commented on KAFKA-1362: -- ./gradlew srcJar worked great however the docsJar_2

[jira] [Commented] (KAFKA-1396) fix unit test ProducerFailureHandlingTest.testBrokerFailure

[ https://issues.apache.org/jira/browse/KAFKA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970388#comment-13970388 ] Jun Rao commented on KAFKA-1396: Basically what I did was to disable the rest of the tests

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970390#comment-13970390 ] Joe Stein commented on KAFKA-1362: -- i ran with stacktrace, debug and info https://gist.g

Re: Review Request 20376: Publish source jars and javadoc

> On April 16, 2014, 2:35 a.m., Joe Stein wrote: > > build.gradle, line 325 > > > > > > curious why you removed these? do they get included from another path? These were moved above (to ~ line 70) under subprojects.

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970427#comment-13970427 ] Sam Meder commented on KAFKA-493: - Do you know if VisualVM uses sampling to arrive at that

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970458#comment-13970458 ] Joel Koshy commented on KAFKA-493: -- I would echo Sam's comment. Personally, I prefer using