> On April 16, 2014, 2:35 a.m., Joe Stein wrote:
> > build.gradle, line 325
> > <https://reviews.apache.org/r/20376/diff/1/?file=558372#file558372line325>
> >
> >     curious why you removed these?  do they get included from another path?

These were moved above (to ~ line 70) under subprojects. I did this since it 
applied to all the projects.


- Joel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20376/#review40490
-----------------------------------------------------------


On April 15, 2014, 7:39 p.m., Joel Koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20376/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 7:39 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1362
>     https://issues.apache.org/jira/browse/KAFKA-1362
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Scaladoc and javadoc
> 
> 
> Add scaladoc
> 
> 
> Generate src jar
> 
> 
> Diffs
> -----
> 
>   README.md d0cdde9ec07fb8d7874a8cd1273388ae6f22d57f 
>   build.gradle 3db5f67d801d65157683b5a4b18955b4475b9d3f 
>   contrib/LICENSE PRE-CREATION 
>   contrib/NOTICE PRE-CREATION 
>   contrib/hadoop-consumer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1 
>   contrib/hadoop-producer/LICENSE 6b0b1270ff0ca8f03867efcd09ba6ddb6392b1e1 
>   core/src/main/scala/kafka/utils/VerifiableProperties.scala 
> b070bb4df117df8542a651b4f0b6bc476855308b 
> 
> Diff: https://reviews.apache.org/r/20376/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joel Koshy
> 
>

Reply via email to