[ 
https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970215#comment-13970215
 ] 

Jay Kreps commented on KAFKA-1359:
----------------------------------

I'm +1 on the 1st patch. I think let's have a separate discussion on how to 
best model the hierarchical metrics. I'd prefer to avoid the global Metrics 
class if possible.

> Add topic/broker metrics once new topic/broker is discovered
> ------------------------------------------------------------
>
>                 Key: KAFKA-1359
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1359
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: producer 
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>             Fix For: 0.8.2
>
>         Attachments: KAFKA-1359.patch, KAFKA-1359_2014-04-10_10:11:40.patch, 
> KAFKA-1359_2014-04-11_14:20:45.patch
>
>
> Today some topic/broker level metrics are only added the first time such an 
> event (record-retry, record-error, etc) happens. This has a potential issue 
> for customized mbean reporter which needs to register all the sensors at the 
> time the new broker/topic is discovered. It is better to add such metrics at 
> the very beginning when new topic/brokers are discovered.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to