[jira] [Commented] (KAFKA-1124) Sending to a new topic (with auto.create.topics.enable) returns ERROR

[ https://issues.apache.org/jira/browse/KAFKA-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826418#comment-13826418 ] Anuj Mehta commented on KAFKA-1124: --- Hi Jason Rosenberg Just checked again. Yes there

[jira] [Commented] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826647#comment-13826647 ] Jun Rao commented on KAFKA-1074: Removing the old replica log from the disk itself is simp

[jira] [Updated] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1074: --- Attachment: KAFKA-1074.patch > Reassign partitions should delete the old replicas from disk > ---

Review Request 15674: Reassign partitions should delete the old replicas from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- Review request for kafka. Bugs: KAFKA-1074 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826648#comment-13826648 ] Jun Rao commented on KAFKA-1074: Created reviewboard https://reviews.apache.org/r/15674/

Re: Review Request 15665: Patch for KAFKA-1135

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29116 --- core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review29118 --- core/src/main/scala/kafka/log/LogSegment.scala

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review29123 --- What happens if I am doing a read or write concurrently with a delet

Re: Review Request 15665: Patch for KAFKA-1135

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29126 --- Ship it! Ship It! - Neha Narkhede On Nov. 19, 2013, 3:21 a.m., S

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

> On Nov. 19, 2013, 6:40 p.m., Jay Kreps wrote: > > What happens if I am doing a read or write concurrently with a delete? > > > > Would it be simpler just to have the delete log work like the segment > > delete where rather than trying to lock we remove it from the segment list > > and then j

Re: Review Request 15665: Patch for KAFKA-1135

> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15659: Patch for KAFKA-1103

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/#review29134 --- Looks good to me except for minor comments. I'll leave open for now

Re: Review Request 15659: Patch for KAFKA-1103

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/#review29139 --- core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala

Re: Review Request 15659: Patch for KAFKA-1103

> On Nov. 19, 2013, 9:48 p.m., Joel Koshy wrote: > > Looks good to me except for minor comments. I'll leave open for now in case > > anyone else wants to review. Also, could you run the mirror-maker system test suite to make sure there are no obvious issues? - Joel

Re: Review Request 15665: Patch for KAFKA-1135

> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15665: Patch for KAFKA-1135

> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- Review request for kafka. Bugs: KAFKA-930 https://issues.apache.org/jira/br

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930.patch > Integrate preferred replica election logic into kafka >

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827208#comment-13827208 ] Sriram Subramanian commented on KAFKA-930: -- Created reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 20, 2013, 1:37 a.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827217#comment-13827217 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2013-11-19_17:37:29.patch > Integrate preferred replica election log

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 20, 2013, 1:38 a.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2013-11-19_17:38:49.patch > Integrate preferred replica election log

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827218#comment-13827218 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15665: Patch for KAFKA-1135

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29159 --- Ship it! - Guozhang Wang On Nov. 19, 2013, 3:21 a.m., Swapnil Ghi

Re: Review Request 15665: Patch for KAFKA-1135

> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i