----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/#review29134 -----------------------------------------------------------
Looks good to me except for minor comments. I'll leave open for now in case anyone else wants to review. core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala <https://reviews.apache.org/r/15659/#comment56262> So the config is no longer required. core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala <https://reviews.apache.org/r/15659/#comment56263> Typo in message; however, I think we can just drop the entire else block. - Joel Koshy On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15659/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 11:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1103 > https://issues.apache.org/jira/browse/KAFKA-1103 > > > Repository: kafka > > > Description > ------- > > KAFKA-1103.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/TopicFilter.scala > cf3853b223095e1fe0921175c407a906828b8113 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > c0350cd05cf1b59866a1fedccbeb700b3e828d44 > core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala > a67c193df9f7cbfc52f75dc1b71dc017de1b5fe2 > core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala > 40a2bf7a9277eb5f94bc07b40d7726d81860cefc > > Diff: https://reviews.apache.org/r/15659/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
