----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review29123 -----------------------------------------------------------
What happens if I am doing a read or write concurrently with a delete? Would it be simpler just to have the delete log work like the segment delete where rather than trying to lock we remove it from the segment list and then just enqueue a delete in 60 seconds. My concern is just that reasoning about the various locking strategies in the log is getting increasingly difficult. - Jay Kreps On Nov. 19, 2013, 4:28 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15674/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2013, 4:28 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1074 > https://issues.apache.org/jira/browse/KAFKA-1074 > > > Repository: kafka > > > Description > ------- > > kafka-1074; fix 3 > > > kafka-1074; fix 2 > > > kafka-1074 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 02ccc17c79b6d44c75f9bb6ca7cda8c51ae6f6fb > core/src/main/scala/kafka/log/Log.scala > 1883a53de112ad08449dc73a2ca08208c11a2537 > core/src/main/scala/kafka/log/LogManager.scala > 81be88aa618ed5614703d45a0556b77c97290085 > core/src/main/scala/kafka/log/LogSegment.scala > 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8 > core/src/main/scala/kafka/server/ReplicaManager.scala > 161f58134f20f9335dbd2bee6ac3f71897cbef7c > core/src/test/scala/unit/kafka/admin/AdminTest.scala > c30069e837e54fb91bf1d5b75b133282a28dedf8 > > Diff: https://reviews.apache.org/r/15674/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
