Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 3

2013-11-11 Thread David Arthur
+0 overall. The quality of the build seems good, but I have a few minor nits/questions. 1) java.lang.NoClassDefFoundError in ./bin/kafka-simple-consumer-perf-test.sh $ ./bin/kafka-simple-consumer-perf-test.sh Exception in thread "main" java.lang.NoClassDefFoundError: kafka/perf/SimpleConsume

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/ --- (Updated Nov. 11, 2013, 4:44 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819103#comment-13819103 ] Jun Rao commented on KAFKA-1117: Updated reviewboard https://reviews.apache.org/r/15201/

[jira] [Updated] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1117: --- Attachment: KAFKA-1117_2013-11-11_08:44:25.patch > tool for checking the consistency among replicas > ---

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Jun Rao
> On Nov. 5, 2013, 10:41 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 73 > > > > > > We do not need () after withRequiredArg here. done > On Nov. 5, 2013, 10:41 p

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Jun Rao
> On Nov. 5, 2013, 6:27 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 66 > > > > > > Default max.message.size is (1MB + header). Default fetch size should > > be a l

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Neha Narkhede
> On Nov. 5, 2013, 6:27 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 247 > > > > > > map{ -> map { > > Jun Rao wrote: > Not sure this is the standard. We do ma

[jira] Subscription: outstanding kafka patches

2013-11-11 Thread jira
Issue Subscription Filter: outstanding kafka patches (73 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1127 kafka and zookeeper server should start in daemon mode and log to correct position https://issues.apache.org/jira/brows

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28665 --- core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Manoj Kunar
Hi Administrators, Can you help me get out of this email-dlist? I do not see any URL to unsubscribe. thanks manoj On 11/11/2013 11:06 AM, Neha Narkhede wrote: --- This is an automatically generated e-mail. To reply, visit: https://revi

[jira] [Created] (KAFKA-1130) "log.dirs" is a confusing property name

2013-11-11 Thread David Arthur (JIRA)
David Arthur created KAFKA-1130: --- Summary: "log.dirs" is a confusing property name Key: KAFKA-1130 URL: https://issues.apache.org/jira/browse/KAFKA-1130 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1130) "log.dirs" is a confusing property name

2013-11-11 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819398#comment-13819398 ] Joe Stein commented on KAFKA-1130: -- data.dirs is less confusing, yup. we should keep b

[jira] [Created] (KAFKA-1131) copy some more files into the release tar and zip that are needed/desired

2013-11-11 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1131: Summary: copy some more files into the release tar and zip that are needed/desired Key: KAFKA-1131 URL: https://issues.apache.org/jira/browse/KAFKA-1131 Project: Kafka

[jira] [Created] (KAFKA-1132) Reduce size and amount of server access logs

2013-11-11 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1132: Summary: Reduce size and amount of server access logs Key: KAFKA-1132 URL: https://issues.apache.org/jira/browse/KAFKA-1132 Project: Kafka Issue Type: Improv

Re: Review Request 15201: address previous review comments

2013-11-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28715 --- Ship it! Ship It! - Guozhang Wang On Nov. 11, 2013, 4:44 p.m., J

[jira] [Commented] (KAFKA-1130) "log.dirs" is a confusing property name

2013-11-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819810#comment-13819810 ] Jay Kreps commented on KAFKA-1130: -- I agree this is a tad bit ambiguous. However the conc

[jira] [Commented] (KAFKA-1132) Reduce size and amount of server access logs

2013-11-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819811#comment-13819811 ] Jay Kreps commented on KAFKA-1132: -- Surely this is just for 0.8.1, no? Any change we nee