> On Nov. 5, 2013, 6:27 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 247 > > <https://reviews.apache.org/r/15201/diff/1/?file=377064#file377064line247> > > > > map{ -> map { > > Jun Rao wrote: > Not sure this is the standard. We do map(, instead of map (. So, it seems > that we should do map{, instead of map {?
So far, we have followed op<space><parantheses>. Let's change it everywhere or follow it for consistency. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28186 ----------------------------------------------------------- On Nov. 11, 2013, 4:44 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15201/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 4:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1117 > https://issues.apache.org/jira/browse/KAFKA-1117 > > > Repository: kafka > > > Description > ------- > > kafka-1117; fix 2 > > > kafka-1117; fix 1 > > > kafka-1117 > > > Diffs > ----- > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/15201/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
