Hi Administrators,

Can you help me get out of this email-dlist? I do not see any URL to unsubscribe.

thanks
manoj


On 11/11/2013 11:06 AM, Neha Narkhede wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201/#review28665
-----------------------------------------------------------



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment55581>

     This is pretty difficult to read. What we've learnt in the past is that error 
codes are not useful alone and should be converted to the string error name. Also, 
it is useful to print the partition -> ErrorCodeString only for partitions that 
have a non zero error code



core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
<https://reviews.apache.org/r/15201/#comment55583>

     expected ?


- Neha Narkhede


On Nov. 11, 2013, 4:44 p.m., Jun Rao wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 4:44 p.m.)


Review request for kafka.


Bugs: KAFKA-1117
     https://issues.apache.org/jira/browse/KAFKA-1117


Repository: kafka


Description
-------

kafka-1117; fix 2


kafka-1117; fix 1


kafka-1117


Diffs
-----

   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION

Diff: https://reviews.apache.org/r/15201/diff/


Testing
-------


Thanks,

Jun Rao




Reply via email to