> Chia-Ping, thanks for bringing this up. I assumed that was done by a Jira +
> GitHub integration, not Jenkins. I'll ask the Infra team for suggestions.
You are right, that is unrelated to INFRA
(https://issues.apache.org/jira/browse/INFRA-26174).
Apologies for asking a strange question :(
Bes
Chia-Ping, thanks for bringing this up. I assumed that was done by a Jira +
GitHub integration, not Jenkins. I'll ask the Infra team for suggestions.
A new GitHub Action is an option, but maybe there's some prior art we can
use here.
-David
On Sun, Sep 29, 2024 at 1:42β―PM Chia-Ping Tsai wrote:
hi David
There is no Jenkins job that automatically adds the PR link to the Jira issue.
Should we consider adding a GitHub action to handle this, or is it sufficient
for the committer to manually add the link when resolving the Jira issue?
Best,
Chia-Ping
On 2024/09/26 21:37:17 David Arthur wr
Josep, I've filed KAFKA-17628 and submitted a PR to partially automate the
workflow approval. With this change, we just need a committer to add a
label one time to a PR, then it will get auto-approved.
I've also wondered about a "triage" or "new" label that is automatically
added to new PRs. This
> I'm not sure caching is even that useful beyond the time
> between the branch point and the .0 release (since the rate of change slows
> way down after a release).
I try to keep us optimistic. π
With the restore keys provided by setup-gradle, CI will always find a cache to
restore. While some
We can probably get the new CI working on older release branches, it will
just take a bit of effort. As a start, we can just disable the build cache
for these builds. I'm not sure caching is even that useful beyond the time
between the branch point and the .0 release (since the rate of change slows
It seems we need to promote approve-workflows.py to all committers π
Josep Prat ζΌ 2024εΉ΄9ζ26ζ₯ ι±ε δΈε9:42ε―«ιοΌ
> I see you have the python script under "committer-tools", I guess I might
> need to get used to call that script instead of going to the "pulls" page.
>
> Best,
>
> On Thu, Sep 26, 2024 at
I see you have the python script under "committer-tools", I guess I might
need to get used to call that script instead of going to the "pulls" page.
Best,
On Thu, Sep 26, 2024 at 3:36β―PM Josep Prat wrote:
> Hi David,
> I think we need a way to flag in the PR list (
> github.com/apache/kafka/pul
Hi David,
I think we need a way to flag in the PR list (github.com/apache/kafka/pulls)
the ones that are waiting for a committer to approve the workflows. As an
example:
[image: image.png]
This PR has a green checkmark where the check status usually goes. But if
one navigates to the PR in question,
That's what I feared
On Thu, Sep 26, 2024 at 10:31β―AM Chia-Ping Tsai wrote:
> hi Josep
>
> > Do you see any potential impact if we backport the change to those?
>
> In my opinion, the main concern is that non-trunk PRs can't effectively
> leverage the cache, meaning they require more time and re
hi Josep
> Do you see any potential impact if we backport the change to those?
In my opinion, the main concern is that non-trunk PRs can't effectively
leverage the cache, meaning they require more time and resources to run CI.
Additionally, github-ci is triggered by trunk branch only, and we have
Thanks to David for providing us with an improved CI!
Cheers,
Chia-Ping
David Arthur ζΌ 2024εΉ΄9ζ26ζ₯ ι±ε δΈε8:51ε―«ιοΌ
> Today, we disabled the Jenkins build on trunk. With this change, we should
> now be expecting all green status checks on PRs before merging. Of course,
> flaky tests still exist, but
One thing that just occurred to me, David, should we backport this CI
change to 3.7, 3.8 and 3.9? These are the 3 active branches at the moment
(3.6 technically is still active, but will be EOL'd when 3.9 is released
soon).
Do you see any potential impact if we backport the change to those?
Best,
Cool! Thanks for the effort, David!
Luke
On Thu, Sep 26, 2024 at 1:26β―PM Josep Prat
wrote:
> Awesome David!
>
> Best,
> --
> Josep Prat
> Open Source Engineering Director, Aiven
> josep.p...@aiven.io | +491715557497 | aiven.io
> Aiven Deutschland GmbH
> Alexanderufer 3-7, 1
Awesome David!
Best,
--
Josep Prat
Open Source Engineering Director, Aiven
josep.p...@aiven.io | +491715557497 | aiven.io
Aiven Deutschland GmbH
Alexanderufer 3-7, 10117 Berlin
GeschΓ€ftsfΓΌhrer: Oskari Saarenmaa, Hannu Valtonen,
Anna Richardson, Kenneth Chen
Amtsgericht Charlott
This is amazing work David! You leveled up every contributor and committer on
the project.
Thanks
> On Sep 25, 2024, at 6:27β―PM, Chris Egerton wrote:
>
> David, you're a legend. Thanks for spearheading this effort!
>
> On Wed, Sep 25, 2024, 20:51 David Arthur wrote:
>
>> Today, we disa
David, you're a legend. Thanks for spearheading this effort!
On Wed, Sep 25, 2024, 20:51 David Arthur wrote:
> Today, we disabled the Jenkins build on trunk. With this change, we should
> now be expecting all green status checks on PRs before merging. Of course,
> flaky tests still exist, but ge
Today, we disabled the Jenkins build on trunk. With this change, we should
now be expecting all green status checks on PRs before merging. Of course,
flaky tests still exist, but generally speaking we should have green builds
(see KIP-1090 for some plans on flaky tests).
Any committer or "collabor
18 matches
Mail list logo
