I see you have the python script under "committer-tools", I guess I might need to get used to call that script instead of going to the "pulls" page.
Best, On Thu, Sep 26, 2024 at 3:36 PM Josep Prat <josep.p...@aiven.io> wrote: > Hi David, > I think we need a way to flag in the PR list ( > github.com/apache/kafka/pulls) the ones that are waiting for a committer > to approve the workflows. As an example: > [image: image.png] > This PR has a green checkmark where the check status usually goes. But if > one navigates to the PR in question, one can see that the CI tasks didn't > start and wait for a committer to approve and run. > [image: image.png] > Do you have another way to identify these PRs? Or should we maybe work on > auto labelling PRs from non-committers (the ones that would wait for CI to > run). > > On Thu, Sep 26, 2024 at 11:00 AM Josep Prat <josep.p...@aiven.io> wrote: > >> That's what I feared >> >> On Thu, Sep 26, 2024 at 10:31 AM Chia-Ping Tsai <chia7...@gmail.com> >> wrote: >> >>> hi Josep >>> >>> > Do you see any potential impact if we backport the change to those? >>> >>> In my opinion, the main concern is that non-trunk PRs can't effectively >>> leverage the cache, meaning they require more time and resources to run >>> CI. >>> Additionally, github-ci is triggered by trunk branch only, and we have >>> not >>> tested it on non-trunk branch yet. Given that 3.9.0 and 3.8.1 releases >>> are >>> processing, we could continue using Jenkins CI to avoid the additional >>> overhead of backporting. >>> >>> By the way, we'll eventually need to backport GitHub CI to the non-trunk >>> branches once the 4.1 branch is created. >>> >>> Best, >>> Chia-Ping >>> >>> >>> >>> Chia-Ping Tsai <chia7...@gmail.com> 於 2024年9月26日 週四 下午4:15寫道： >>> >>> > Thanks to David for providing us with an improved CI! >>> > >>> > Cheers, >>> > Chia-Ping >>> > >>> > David Arthur <mum...@gmail.com> 於 2024年9月26日 週四 上午8:51寫道： >>> > >>> >> Today, we disabled the Jenkins build on trunk. With this change, we >>> should >>> >> now be expecting all green status checks on PRs before merging. Of >>> course, >>> >> flaky tests still exist, but generally speaking we should have green >>> >> builds >>> >> (see KIP-1090 for some plans on flaky tests). >>> >> >>> >> Any committer or "collaborator" (as defined in .asf.yaml) is able to >>> >> manually re-run a GitHub Action via the UI. >>> >> >>> >> For non-committers, someone must approve the workflow. There is a >>> >> "approve-workflows.py" script in committer-tools to help with this. >>> I'm >>> >> still investigating options to improve this. >>> >> >>> >> We will keep the Jenkins build enabled for 3.9 and other release >>> branches. >>> >> >>> >> Cheers, >>> >> David A >>> >> >>> > >>> >> >> >> -- >> [image: Aiven] <https://www.aiven.io> >> >> *Josep Prat* >> Open Source Engineering Director, *Aiven* >> josep.p...@aiven.io | +491715557497 >> aiven.io <https://www.aiven.io> | >> <https://www.facebook.com/aivencloud> >> <https://www.linkedin.com/company/aiven/> >> <https://twitter.com/aiven_io> >> *Aiven Deutschland GmbH* >> Alexanderufer 3-7, 10117 Berlin >> Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, >> Anna Richardson, Kenneth Chen >> Amtsgericht Charlottenburg, HRB 209739 B >> > > > -- > [image: Aiven] <https://www.aiven.io> > > *Josep Prat* > Open Source Engineering Director, *Aiven* > josep.p...@aiven.io | +491715557497 > aiven.io <https://www.aiven.io> | > <https://www.facebook.com/aivencloud> > <https://www.linkedin.com/company/aiven/> <https://twitter.com/aiven_io> > *Aiven Deutschland GmbH* > Alexanderufer 3-7, 10117 Berlin > Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, > Anna Richardson, Kenneth Chen > Amtsgericht Charlottenburg, HRB 209739 B > -- [image: Aiven] <https://www.aiven.io> *Josep Prat* Open Source Engineering Director, *Aiven* josep.p...@aiven.io | +491715557497 aiven.io <https://www.aiven.io> | <https://www.facebook.com/aivencloud> <https://www.linkedin.com/company/aiven/> <https://twitter.com/aiven_io> *Aiven Deutschland GmbH* Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa, Hannu Valtonen, Anna Richardson, Kenneth Chen Amtsgericht Charlottenburg, HRB 209739 B
