Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-19 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/ --- (Updated June 20, 2015, 6:10 a.m.) Review request for kafka. Bugs: KAFKA-2245

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-19 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88630 --- Various tests under ReplicaManagerTest were failing only during batc

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-19 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88629 --- Ship it! Ship It! - Joel Koshy On June 20, 2015, 5:56 a.m., Onur

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-19 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/ --- (Updated June 20, 2015, 5:56 a.m.) Review request for kafka. Bugs: KAFKA-2245

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88462 --- Ship it! (Discussed comments offline with Onur) - Joel Koshy On

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-18 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88131 --- This looks good to me. Just have a minor comment below, and one orth

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-17 Thread Onur Karaman
> On June 17, 2015, 5:53 p.m., Guozhang Wang wrote: > > Hey Onur, > > > > I got some rebase errors applying the patch after applying KAFKA-1740. > > Could you double check? When I apply KAFKA-1740 first and then KAFKA-2245, I get: ``` > git apply ~/Downloads/rb35231.patch > git apply ~/Downloa

Re: Review Request 35086: add response tests for ConsumerCoordinator

2015-06-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88247 --- Hey Onur, I got some rebase errors applying the patch after applyin

Review Request 35086: add response tests for ConsumerCoordinator

2015-06-04 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/ --- Review request for kafka. Bugs: KAFKA-2245 https://issues.apache.org/jira/b