-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35086/#review88630
-----------------------------------------------------------
Various tests under ReplicaManagerTest were failing only during batch testing
(./gradlew cleanTest test). They were checking the existence of non daemon
threads. ConsumerCoordinatorResponseTest did not shutdown the
ConsumerCoordinator after each test, which led to each test leaving a thread
running for each of the two ConsumerCoordinator's purgatories. The tearDown I
just added should address this.
Here's one of the tests that failed from ReplicaManagerTest before the tearDown
was added:
```
kafka.server.ReplicaManagerTest > testIllegalRequiredAcks FAILED
junit.framework.AssertionFailedError: expected:<0> but was:<28>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:277)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:195)
at junit.framework.Assert.assertEquals(Assert.java:201)
at
kafka.utils.TestUtils$.verifyNonDaemonThreadsStatus(TestUtils.scala:724)
at
kafka.server.ReplicaManagerTest.testIllegalRequiredAcks(ReplicaManagerTest.scala:89)
```
- Onur Karaman
On June 20, 2015, 5:56 a.m., Onur Karaman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35086/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 5:56 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2245
> https://issues.apache.org/jira/browse/KAFKA-2245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> coordinator response test
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala
> 51e89c87ee2c20fc7f976536f01fa1055fb8e670
> core/src/main/scala/kafka/coordinator/CoordinatorMetadata.scala
> c39e6de34ee531c6dfa9107b830752bd7f8fbe59
>
> core/src/test/scala/unit/kafka/coordinator/ConsumerCoordinatorResponseTest.scala
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35086/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Onur Karaman
>
>
