> On June 17, 2015, 5:53 p.m., Guozhang Wang wrote: > > Hey Onur, > > > > I got some rebase errors applying the patch after applying KAFKA-1740. > > Could you double check?
When I apply KAFKA-1740 first and then KAFKA-2245, I get: ``` > git apply ~/Downloads/rb35231.patch > git apply ~/Downloads/rb35086.patch error: patch failed: core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala:46 error: core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala: patch does not apply ``` Is this what you're referring to? - Onur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/#review88247 ----------------------------------------------------------- On June 4, 2015, 7:57 p.m., Onur Karaman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35086/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 7:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2245 > https://issues.apache.org/jira/browse/KAFKA-2245 > > > Repository: kafka > > > Description > ------- > > add response tests for ConsumerCoordinator > > > Diffs > ----- > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala > 51e89c87ee2c20fc7f976536f01fa1055fb8e670 > core/src/main/scala/kafka/coordinator/CoordinatorMetadata.scala > c39e6de34ee531c6dfa9107b830752bd7f8fbe59 > > core/src/test/scala/unit/kafka/coordinator/ConsumerCoordinatorResponseTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/35086/diff/ > > > Testing > ------- > > > Thanks, > > Onur Karaman > >
