Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review79205 --- Ship it! LGTM, Jun do you want to take another look? - Guozhang Wa

Re: Review Request 31366: Patch for KAFKA-1461

> On March 24, 2015, 10:46 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, lines 81-86 > > > > > > Jun has a comment about the case when all partitions gets inactive, > > wh

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated April 7, 2015, 3:41 p.m.) Review request for kafka. Bugs: KAFKA-1461

Re: Review Request 31366: Patch for KAFKA-1461

> On March 24, 2015, 10:46 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, lines 81-86 > > > > > > Jun has a comment about the case when all partitions gets inactive, > > wh

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated April 4, 2015, 3:48 a.m.) Review request for kafka. Bugs: KAFKA-1461

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated March 28, 2015, 12:02 a.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 31366: Patch for KAFKA-1461

> On March 27, 2015, 10:52 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 276 > > > > > > Can you add some documentation for this class? Thanks for the review. Upda

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated March 27, 2015, 11:56 p.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review78120 --- Couple of comments. Thanks! core/src/main/scala/kafka/server/Abstr

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated March 27, 2015, 10:31 p.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 31366: Patch for KAFKA-1461

> On March 24, 2015, 10:46 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, lines 81-86 > > > > > > Jun has a comment about the case when all partitions gets inactive, > > wh

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review77674 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- (Updated March 17, 2015, 11:03 p.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74866 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

Re: Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74160 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

Review Request 31366: Patch for KAFKA-1461

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/ --- Review request for kafka. Bugs: KAFKA-1461 https://issues.apache.org/jira/b