----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74866 -----------------------------------------------------------
core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment121680> OffsetAndDelay / OffsetAndState is a bit confusing, maybe we can just use PartitionFetchState? core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment121689> It seems we do not need to pass in the OffsetAndDelay object here as we will create new one anyways. We can still pass in Long, and with that OffsetAndDelay is just internal to AbstractFetcherThread. core/src/main/scala/kafka/server/OffsetAndDelay.scala <https://reviews.apache.org/r/31366/#comment121685> Maybe we can just put this case class into AbstractFetcherThread and expose to AbstractFetcherManager. core/src/main/scala/kafka/server/ReplicaFetcherThread.scala <https://reviews.apache.org/r/31366/#comment121686> Are these imports necessary? core/src/main/scala/kafka/server/ReplicaFetcherThread.scala <https://reviews.apache.org/r/31366/#comment121688> Is this intentional? - Guozhang Wang On Feb. 24, 2015, 6:02 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31366/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 6:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 20c00cb8cc2351950edbc8cb1752905a0c26e79f > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 8c281d4668f92eff95a4a5df3c03c4b5b20e7095 > core/src/main/scala/kafka/server/KafkaConfig.scala > 14bf3216bae030331bdf76b3266ed0e73526c3de > core/src/main/scala/kafka/server/OffsetAndDelay.scala PRE-CREATION > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 6879e730282185bda3d6bc3659cb15af0672cecf > core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala > da4bafc1e2a94a436efe395aab1888fc21e55748 > > Diff: https://reviews.apache.org/r/31366/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
