----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review77674 -----------------------------------------------------------
core/src/main/scala/kafka/server/AbstractFetcherThread.scala <https://reviews.apache.org/r/31366/#comment125847> Jun has a comment about the case when all partitions gets inactive, which is common when the fetched broker has been just gone through leader migration. We can move the foreach statement before the if statement, and after foreach check if any partitions gets added, if not just backoff for fetchBackoffMs. - Guozhang Wang On March 17, 2015, 11:03 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31366/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 11:03 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > e731df4b2a3e44aa3d761713a09b1070aff81430 > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 96faa7b4ed7c9ba8a3f6f9f114bd94e19b3a7ac0 > > Diff: https://reviews.apache.org/r/31366/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
