Re: Review Request 28240: Follow-up KAFKA-1580

2014-11-21 Thread Guozhang Wang
> On Nov. 21, 2014, 1:48 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 193 > > > > > > I think it is more suitable to have this access control implemented > > inside ReplicaManager

Re: Review Request 28240: Follow-up KAFKA-1580

2014-11-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28240/#review62547 --- Ship it! Minor comment. core/src/main/scala/kafka/server/KafkaApi

Review Request 28240: Follow-up KAFKA-1580

2014-11-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28240/ --- Review request for kafka. Bugs: KAFKA-1580 https://issues.apache.org/jira/b