> On Nov. 21, 2014, 1:48 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 193 > > <https://reviews.apache.org/r/28240/diff/1/?file=770058#file770058line193> > > > > I think it is more suitable to have this access control implemented > > inside ReplicaManager. One can argue both ways though...
I was actually back and forth quite some times back then. The main reason I choose to do this in the Kafka API layer is that otherwise the offset manager / replica manager has to handle operations with clientId, which defeats the purpose of the refactoring effort. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28240/#review62547 ----------------------------------------------------------- On Nov. 19, 2014, 7:01 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28240/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 7:01 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1580 > https://issues.apache.org/jira/browse/KAFKA-1580 > > > Repository: kafka > > > Description > ------- > > Add the logic for checking internal topics in the replica manager layer > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala > 94c53320b768b83b0324336b73cc06537c0fe78d > core/src/main/scala/kafka/server/KafkaApis.scala > 968b0c4f809ea9f9c3f322aef9db105f9d2e0e23 > core/src/main/scala/kafka/server/OffsetManager.scala > 2957bc435102bc4004d8f100dbcdd56287c8ffae > core/src/main/scala/kafka/server/ReplicaManager.scala > 3007a6d89b637b93f71fdb7adab561a93d9c4c62 > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 8531f533f3a6431f4f9fc8cb1ad3e9f1f1b110e0 > > Diff: https://reviews.apache.org/r/28240/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
