Re: Review Request 26291: Patch for KAFKA-1648

2014-12-21 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Dec. 21, 2014, 10:45 p.m.) Review request for kafka. Bugs: KAFKA-164

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review56040 --- Ship it! Ship It! - Joel Koshy On Oct. 9, 2014, 6:56 p.m., Mayur

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review56036 --- Ship it! Ship It! - Neha Narkhede On Oct. 9, 2014, 6:56 p.m., Ma

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Oct. 9, 2014, 6:56 p.m.) Review request for kafka. Bugs: KAFKA-1648

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review56028 --- core/src/main/scala/kafka/consumer/PartitionAssignor.scala

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Neha Narkhede
> On Oct. 9, 2014, 6:21 p.m., Neha Narkhede wrote: > > Is this issue covered by a test case? Didn't see one with no topics for a > > wildcard consumer. Ignore that. I see that you modified the partition assignor. - Neha --- This is an

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review56025 --- Is this issue covered by a test case? Didn't see one with no topics

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-08 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Oct. 9, 2014, 12:46 a.m.) Review request for kafka. Bugs: KAFKA-1648

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-08 Thread Mayuresh Gharat
> On Oct. 4, 2014, 11:33 p.m., Neha Narkhede wrote: > > Can you try to add a unit test for this? Yes I will try and add unit test for this - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-08 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Oct. 9, 2014, 12:29 a.m.) Review request for kafka. Bugs: KAFKA-1648

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-08 Thread Mayuresh Gharat
> On Oct. 7, 2014, 9:06 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala, line 76 > > > > > > Did you mean to return this? yes. I did not want to change the return type. If there a

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review55702 --- core/src/main/scala/kafka/consumer/PartitionAssignor.scala

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-04 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- (Updated Oct. 5, 2014, 12:40 a.m.) Review request for kafka. Bugs: KAFKA-1648

Re: Review Request 26291: Patch for KAFKA-1648

2014-10-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review55456 --- Can you try to add a unit test for this? core/src/main/scala/kafka

Review Request 26291: Patch for KAFKA-1648

2014-10-02 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ --- Review request for kafka. Bugs: KAFKA-1648 https://issues.apache.org/jira/b