----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/ -----------------------------------------------------------
(Updated Oct. 9, 2014, 12:46 a.m.) Review request for kafka. Bugs: KAFKA-1648 https://issues.apache.org/jira/browse/KAFKA-1648 Repository: kafka Description (updated) ------- Removed the unnecessary comment Made a change to the way the condition for no topics is checked Cleaned unnecessary code and modified the test case to handle the no topic scenario Diffs (updated) ----- core/src/main/scala/kafka/consumer/PartitionAssignor.scala 8ea7368dc394a497164ea093ff8e9f2e6a94b1de core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 9ceae222ca5bf63e8131de0db2a94126c8b57b59 Diff: https://reviews.apache.org/r/26291/diff/ Testing ------- Thanks, Mayuresh Gharat