----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review55702 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/PartitionAssignor.scala <https://reviews.apache.org/r/26291/#comment96078> You could just do if (ctx.consumersForTopic.size <= 0) core/src/main/scala/kafka/consumer/PartitionAssignor.scala <https://reviews.apache.org/r/26291/#comment96080> Did you mean to return this? core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala <https://reviews.apache.org/r/26291/#comment96089> I don't think this is required. (Or if it is can you explain?) - Joel Koshy On Oct. 5, 2014, 12:40 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26291/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 12:40 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1648 > https://issues.apache.org/jira/browse/KAFKA-1648 > > > Repository: kafka > > > Description > ------- > > Removed the unnecessary comment > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala > 8ea7368dc394a497164ea093ff8e9f2e6a94b1de > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > fbc680fde21b02f11285a4f4b442987356abd17b > > Diff: https://reviews.apache.org/r/26291/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
