Re: Review Request 23692: Patch for KAFKA-1550

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/#review48455 --- Ship it! Ship It! - Guozhang Wang On July 22, 2014, 6:41 p.m., D

Re: Review Request 23692: Patch for KAFKA-1550

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/ --- (Updated July 22, 2014, 6:41 p.m.) Review request for kafka. Bugs: KAFKA-1550

Re: Review Request 23692: Patch for KAFKA-1550

> On July 22, 2014, 6:30 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 120 > > > > > > formatted patch is a little misleading and is a git specific command. > > diff is easier to understand. So I'd recomm

Re: Review Request 23692: Patch for KAFKA-1550

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/#review48392 --- Looks good. Thanks for improving our tools. I have a minor comment.

Review Request 23692: Patch for KAFKA-1550

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/ --- Review request for kafka. Bugs: KAFKA-1550 https://issues.apache.org/jira/b