> On July 22, 2014, 6:30 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 120 > > <https://reviews.apache.org/r/23692/diff/1/?file=635684#file635684line120> > > > > formatted patch is a little misleading and is a git specific command. > > diff is easier to understand. So I'd recommend we keep the message as is.
Thanks for the review! I have updated it now. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/#review48392 ----------------------------------------------------------- On July 22, 2014, 6:41 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23692/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1550 > https://issues.apache.org/jira/browse/KAFKA-1550 > > > Repository: kafka > > > Description > ------- > > KAFKA-1550 Patch review tool should use git format-patch to generate patch > (version 2) > > > Diffs > ----- > > kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef > > Diff: https://reviews.apache.org/r/23692/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
