Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43679 --- Ship it! Ship It! - Joel Koshy On May 21, 2014, 3:51 p.m., Sriha

Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43678 --- Ship it! Ship It! - Neha Narkhede On May 21, 2014, 3:51 p.m., Sr

Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/ --- (Updated May 21, 2014, 3:51 p.m.) Review request for kafka. Bugs: KAFKA-1446

Re: Review Request 21744: Patch for KAFKA-1446

> On May 21, 2014, 1:26 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 109 > > > > > > Can just call these -RebalancesPerMin and -RebalanceTime Thanks for th

Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/ --- (Updated May 21, 2014, 3:19 p.m.) Review request for kafka. Bugs: KAFKA-1446

Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43616 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43564 --- This looks good. One minor issue with the rebalance time metric in t

Review Request 21744: Patch for KAFKA-1446

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/ --- Review request for kafka. Bugs: KAFKA-1446 https://issues.apache.org/jira/b