> On May 21, 2014, 1:26 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 109 > > <https://reviews.apache.org/r/21744/diff/1/?file=585855#file585855line109> > > > > Can just call these -RebalancesPerMin and -RebalanceTime
Thanks for the review. I removed rebalancesRate meter as per Jun's comments. I am changing the timer label to -RebalaceRateAndTime. Please let me know if that looks good. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43564 ----------------------------------------------------------- On May 21, 2014, 3:19 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21744/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 3:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1446 > https://issues.apache.org/jira/browse/KAFKA-1446 > > > Repository: kafka > > > Description > ------- > > KAFKA-1446.Consumer mertics for rebalance. Removed rebalancesRate meter as > having timer is sufficent to track the rate. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > c032d263b5eedd8f3075e92cc9a9b0be864720ec > > Diff: https://reviews.apache.org/r/21744/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
