----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21744/#review43564 -----------------------------------------------------------
This looks good. One minor issue with the rebalance time metric in the patch is that if a consumer spends an excessive amount of time in rebalance (say due to retries and a lot of partitions it spends several minutes) then that will not get reflected in the stats until after the rebalance completes (or fails). That is probably why Clark was suggesting an update once a minute for these stats. However, I don't see a good place to "poke" the meter/timer during the rebalance. We do plan to add a consumer state metric that I think will cover almost the same thing - i.e., what Clark suggested and we can keep this patch as is. core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala <https://reviews.apache.org/r/21744/#comment77804> Can just call these -RebalancesPerMin and -RebalanceTime - Joel Koshy On May 21, 2014, 12:48 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21744/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 12:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1446 > https://issues.apache.org/jira/browse/KAFKA-1446 > > > Repository: kafka > > > Description > ------- > > KAFKA-1446.Consumer metrics for rebalance. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > c032d263b5eedd8f3075e92cc9a9b0be864720ec > > Diff: https://reviews.apache.org/r/21744/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
