Re: Review Request 21174: Fix KAFKA-1396

2014-05-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42576 --- core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTe

Review Request 21174: Fix KAFKA-1396

2014-05-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- Review request for kafka. Bugs: KAFKA-1396 https://issues.apache.org/jira/b

Re: Review Request 21174: Fix KAFKA-1396

2014-05-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42534 --- core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTe

Re: Review Request 21174: Fix KAFKA-1396

2014-05-12 Thread Guozhang Wang
> On May 8, 2014, 8:24 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 296-297 > > > > > > Should we check that after shutting down the producer schedule

Re: Review Request 21174: Fix KAFKA-1396

2014-05-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 7, 2014, 9:55 p.m.) Review request for kafka. Bugs: KAFKA-1396

Re: Review Request 21174: Fix KAFKA-1396

2014-05-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 8, 2014, 10:57 p.m.) Review request for kafka. Bugs: KAFKA-1396

Re: Review Request 21174: Fix KAFKA-1396

2014-05-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42665 --- core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTe

Re: Review Request 21174: Fix KAFKA-1396

2014-05-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 7, 2014, 9:17 p.m.) Review request for kafka. Bugs: KAFKA-1396

Re: Review Request 21174: Fix KAFKA-1396

2014-05-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 7, 2014, 9:56 p.m.) Review request for kafka. Bugs: KAFKA-1396

Re: Review Request 21174: Fix KAFKA-1396

2014-05-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 9, 2014, 5:35 p.m.) Review request for kafka. Bugs: KAFKA-1396