> On May 8, 2014, 8:24 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 296-297 > > <https://reviews.apache.org/r/21174/diff/2/?file=576364#file576364line296> > > > > Should we check that after shutting down the producer scheduler?
This check is to make sure no exceptions are thrown in the returned responses. If there is then we should just stop the test immediately. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/#review42534 ----------------------------------------------------------- On May 7, 2014, 9:56 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21174/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 9:56 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1396 > https://issues.apache.org/jira/browse/KAFKA-1396 > > > Repository: kafka > > > Description > ------- > > 1. Reduce bouncing test iterations from 5 to 2. > 2. Double check metadata is propagated after the bouncing iterations and > before fetching data. > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > a993e8c7531abca6b82d1718ac57ba6a295c1fc7 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > af11a4983599a20a33b6f1fc05738a59abfede63 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 034f36130a1d0669dda5ed53e9cee328806c811e > > Diff: https://reviews.apache.org/r/21174/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
